[Bug 27882] New: Move external search results links out of page heading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 Bug ID: 27882 Summary: Move external search results links out of page heading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 27740 When results are found in OverDrive, Recorded Books, or OpenLibrary collections the information is appended to the search results <h1>. I think the should be added just after the <h1> because they're not really part of the heading information. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117863&action=edit Bug 27882: Move external search results links out of page heading This patch modifies the JavaScript which adds search result information to the OPAC search results page which is returned from OverDrive, Recorded Books, or Open Library. The information now displays below the page heading instead of inside it. To test you must have OpenLibrarySearch enabled, OverDrive-related preferences populated (OverDriveClientKey, OverDriveClientSecret, OverDriveLibraryID), or RecordedBooks preferences (RecordedBooksClientSecret, RecordedBooksDomain, RecordedBooksLibraryID). This patch was written with OverDrive and Open Library results active. - Apply the patch and perform a search in the OPAC catalog. - On the search results page you should see results for your external services appear below the page heading ("You search returned..."), e.g. "Found 20257 results in the library's OpenLibrary collection" "Found 337 results in the library's OverDrive collection" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117863|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 120850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120850&action=edit Bug 27882: Move external search results links out of page heading This patch modifies the JavaScript which adds search result information to the OPAC search results page which is returned from OverDrive, Recorded Books, or Open Library. The information now displays below the page heading instead of inside it. To test you must have OpenLibrarySearch enabled, OverDrive-related preferences populated (OverDriveClientKey, OverDriveClientSecret, OverDriveLibraryID), or RecordedBooks preferences (RecordedBooksClientSecret, RecordedBooksDomain, RecordedBooksLibraryID). This patch was written with OverDrive and Open Library results active. - Apply the patch and perform a search in the OPAC catalog. - On the search results page you should see results for your external services appear below the page heading ("You search returned..."), e.g. "Found 20257 results in the library's OpenLibrary collection" "Found 337 results in the library's OverDrive collection" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120850|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120913&action=edit Bug 27882: Move external search results links out of page heading This patch modifies the JavaScript which adds search result information to the OPAC search results page which is returned from OverDrive, Recorded Books, or Open Library. The information now displays below the page heading instead of inside it. To test you must have OpenLibrarySearch enabled, OverDrive-related preferences populated (OverDriveClientKey, OverDriveClientSecret, OverDriveLibraryID), or RecordedBooks preferences (RecordedBooksClientSecret, RecordedBooksDomain, RecordedBooksLibraryID). This patch was written with OverDrive and Open Library results active. - Apply the patch and perform a search in the OPAC catalog. - On the search results page you should see results for your external services appear below the page heading ("You search returned..."), e.g. "Found 20257 results in the library's OpenLibrary collection" "Found 337 results in the library's OverDrive collection" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks good, no regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Enhancement not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org