[Bug 23681] New: Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Bug ID: 23681 Summary: Patron restrictions should be user definable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently the patron restrictions are hard coded as enums in borrower_debarments.type, the available values are 'SUSPENSION','OVERDUES','MANUAL','DISCHARGE'. We (PTFS Europe) have a customer requirement to: - Provide a select box when adding a patron restriction containing user defined values for restriction types, the user defined values should be defined as authorised values - Ensure a default value if no restriction type is selected - Allow the name of the default value to be modifiable - Ensure that if a restriction type authorised value is removed, any restrictions that use it should revert to the default value - Make the selection of restriction type optional via a syspref Currently, at the DB level, the default value is 'MANUAL'. The plan is to: DB MIGRATION ------------ - Add authorised_value_categories row for 'PATRON_RESTRICTIONS' - Add authorised_values.core, default value 0 - Implies AV cannot be deleted and authorised_values.authorised_value cannot be changed - Add new borrower_debarments.debarment_type column - Select distinct values from borrower_debarments.type - For each $value: - Create AV rows: - authorised_values.authorised_value = $value - authorised_values.lib = $value - authorised_values.core = 1 - ** Note id of each new row, associated with $value - update borrower_debarments.debarment_type to be appropriate AV id - Remove borrower_debarments.type OTHER STUFF ----------- - AV UI (and anything else that can bring about AV modification), should respect "core" - Modify Patron::Debarments appropriate functions to abstract underlying changes i.e. we maintain backward compatibility with the way they currently work, we just obfuscate the fact that the "type" comes from a different table - Overload AuthorisedValue::delete to allow us to call optional functions after delete - in a sane world this would be a trigger. This will allow us to set appropriate patron_debarments.debarment_type rows to default value upon AV deletion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- It has become increasingly apparent that using authorised values for this is not the most appropriate way forward. The number of modifications and additions to AV was increasing the scope of the work too much, it was clear that AV was not the correct place for this. Therefore, I am intending creating a table specifically for Patron Restrictions and building the management UI for it, which will be placed probably under "Koha administration" > "Patrons and circulation" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theod@lib.auth.gr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93769&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93770&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93771&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #5 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93772&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93773&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #7 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93774&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #8 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93775&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #9 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93776&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #10 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93777&action=edit Bug 23681: Add unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #11 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Test plan: - Apply bug - Rebuild CSS => TEST: Observe a new syspref exists "PatronRestrictionTypes" - Enable syspref "PatronRestrictionTypes" - Navigate to your currently logged in patron's "details" page - Choose More > Set permissions => TEST: Observe there is a new permission under "Manage Koha system settings" called "Manage patron restrictions (manage_patron_restrictions)" - Ensure you are logged in as either a superlibrarian, or assign yourself "manage_patron_restrictions" - Navigate to "Koha administration" => TEST: Observe a new menu option under "Patrons and circulation" called "Patron restrictions" - Navigate to "Patron restrictions" => TEST: Observe that 4 restrictions exist "DISCHARGE", "MANUAL", "OVERDUES", "SUSPENSION" - Click "New restriction" - Enter a code and label for the new restriction => TEST: Observe that the code can only be entered in uppercase - Click "Save" => TEST: Observe that the new restriction is listed in the table - On the row containing the new restriction, click "Edit" => TEST: Observe that the label can be edited, but the code cannot - Return to the table => TEST: Observe that none of the pre-existing restrictions can be deleted - Navigate to the details for an existing patron - Click on the "Restrictions" tab at the bottom - Click "Add manual restriction" => TEST: In the "Type" select box, observe that all 5 restriction types are available for selection - Select a restriction type - Enter a comment - Optionally, choose an expiration date - Click "Add restriction" - Return to the "Restrictions" tab => TEST: Observe that the newly added restriction is displayed - Navigate to the patron's "You summary" page in the OPAC => Observe that the newly added restriction's "comment" is displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93769|0 |1 is obsolete| | --- Comment #12 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93778&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93770|0 |1 is obsolete| | --- Comment #13 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93779&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93771|0 |1 is obsolete| | --- Comment #14 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93780&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93772|0 |1 is obsolete| | --- Comment #15 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93781&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93773|0 |1 is obsolete| | --- Comment #16 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93782&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93774|0 |1 is obsolete| | --- Comment #17 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93783&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93775|0 |1 is obsolete| | --- Comment #18 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93784&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93776|0 |1 is obsolete| | --- Comment #19 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93785&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93777|0 |1 is obsolete| | --- Comment #20 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 93786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93786&action=edit Bug 23681: Add unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- A couple things: * Can Koha::RestrictionType(s) be moved to Koha::Patron::RestrictionType(s) * Can the table debarment_types be renamed to patron_restriction_types so our internal and external terminology match? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #22 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Kyle Thanks for taking a look at this.
Can Koha::RestrictionType(s) be moved to Koha::Patron::RestrictionType(s)
That's actually how I had it originally. However I moved it since, as far as I could see, everything in Koha::Patron::* was related to a singular patron and represented properties of that patron, which was not the case of RestrictionTypes, which represents the canonical list of restriction types, or a restriction type, not at all related to a patron. I'm happy to move it back if you feel it would be better there, but wanted to explain the rationale.
Can the table debarment_types be renamed to patron_restriction_types so our internal and external terminology match?
Again, there is a rationale behind this. I named the table "debarment_types" because it was related to a pre-existing table "borrower_debarments" and I felt it would be confusing to name it "restriction_types". I realise that there is a move towards "restriction" rather than "debarment", and I have used the new term in the parts of this bug that are truly new, but where I'm interacting with stuff that's referring to debarments, it felt less confusing to use the same terminology for my bits. Hopefully, at some point, a full sweep of "debarment" => "restriction" will be done, so I felt this was a reasonable interim balance. Again, if you'd rather it be changed, I can do so. Many thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Now that my brain has caught up with Andrews explanation I'm happy here. Yes, the Object <-> DB naming is inconsistent.. BUT by doing so the DB <-> DB and the Object <-> Object levels are both consistent at their level. That makes reasonable sense to me, though in reality I'd love to have seen 'debartment' changed to 'restriction' at the DB level consistently at the time we decided to switch terms.. we're now dealing with legacy baggage. As for RestrictionTypes I'm less sure.. but had a chat with Katrin and she agreed it did make sense as a top level object.. Patron::Restrictions makes sense as they're directly related but Patrons::RestrictionTypes doesn't as it's the restriction itself that has a type and is a level distinct.. Koha::Patron::Restriction::RestrictionTypes seems a little too nested.. so happy to stick to top level object here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93778|0 |1 is obsolete| | --- Comment #24 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94862&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93779|0 |1 is obsolete| | --- Comment #25 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94863&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93780|0 |1 is obsolete| | --- Comment #26 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94864&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93781|0 |1 is obsolete| | --- Comment #27 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94865&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93782|0 |1 is obsolete| | --- Comment #28 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94866&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93783|0 |1 is obsolete| | --- Comment #29 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94867&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93784|0 |1 is obsolete| | --- Comment #30 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94868&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93785|0 |1 is obsolete| | --- Comment #31 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94869&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93786|0 |1 is obsolete| | --- Comment #32 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94870&action=edit Bug 23681: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94862|0 |1 is obsolete| | --- Comment #33 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94896&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94863|0 |1 is obsolete| | --- Comment #34 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94897&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94864|0 |1 is obsolete| | --- Comment #35 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94898&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94865|0 |1 is obsolete| | --- Comment #36 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94899&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94866|0 |1 is obsolete| | --- Comment #37 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94900&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94867|0 |1 is obsolete| | --- Comment #38 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94901&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94868|0 |1 is obsolete| | --- Comment #39 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94902&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94869|0 |1 is obsolete| | --- Comment #40 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94903&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94870|0 |1 is obsolete| | --- Comment #41 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94904&action=edit Bug 23681: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #42 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95148&action=edit Bug 23681: (follow-up) Fix typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |savitra.sirohi@osslabs.biz --- Comment #43 from Magnus Enger <magnus@libriotech.no> --- *** Bug 6775 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94896|0 |1 is obsolete| | --- Comment #44 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95255&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94897|0 |1 is obsolete| | --- Comment #45 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95256&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94898|0 |1 is obsolete| | --- Comment #46 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95257&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94899|0 |1 is obsolete| | --- Comment #47 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95258&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94900|0 |1 is obsolete| | --- Comment #48 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95259&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94901|0 |1 is obsolete| | --- Comment #49 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95260&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94902|0 |1 is obsolete| | --- Comment #50 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95261&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94903|0 |1 is obsolete| | --- Comment #51 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95262&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94904|0 |1 is obsolete| | --- Comment #52 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95263&action=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95148|0 |1 is obsolete| | --- Comment #53 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95264&action=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Isherwood from comment #1)
It has become increasingly apparent that using authorised values for this is not the most appropriate way forward. The number of modifications and additions to AV was increasing the scope of the work too much, it was clear that AV was not the correct place for this.
Why? Can you explain? That was my first reaction reading the patches. Using AV will make the feature translatable in the future (bug 20307). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So you are adding a regression, the restrictions are no longer translatable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is the "default" flag really useful? We could imagine a new "internal" flag (to replace ronly) for AVs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #57 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #54)
(In reply to Andrew Isherwood from comment #1)
It has become increasingly apparent that using authorised values for this is not the most appropriate way forward. The number of modifications and additions to AV was increasing the scope of the work too much, it was clear that AV was not the correct place for this.
Why? Can you explain? That was my first reaction reading the patches. Using AV will make the feature translatable in the future (bug 20307).
Clearly AV would have been the preferable route, which is why I spent some considerable time trying to implement using AV before reluctantly abandoning it, it certainly wasn't abandoned lightly. There were too many requirements of this work that were not provided by AV and working around them was becoming increasingly cludgy and unmaintainable. This work was done a few months ago, so my memory of it isn't what it was, but examples would be: - the ability to specify a default restriction type, which any restrictions would fall back to if the restriction type they were using was deleted - the ability to prevent certain restriction types from being edited - the ability to prevent certain restriction types from being deleted
So you are adding a regression, the restrictions are no longer translatable.
They were previously held in borrower_debarments.type, they are now in debarment_types, so I'm guessing adding translation support for the default values is not an insurmountable problem, I am happy to add whatever work is required to make that happen to this bug. Any additional values are added by the user anyway, so are by their nature translatable.
Is the "default" flag really useful? We could imagine a new "internal" flag (to replace ronly) for AVs.
I believe so. Restrictions need a type, even if one is not explicitly chosen. Also, we need an ability to say "if a restriction type is deleted, any restrictions that use this type should fall back to type X", the default flag indicates which type is X. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Isherwood from comment #57)
(In reply to Jonathan Druart from comment #54)
Is the "default" flag really useful? We could imagine a new "internal" flag (to replace ronly) for AVs.
I believe so. Restrictions need a type, even if one is not explicitly chosen. Also, we need an ability to say "if a restriction type is deleted, any restrictions that use this type should fall back to type X", the default flag indicates which type is X.
I do not remember I saw a way to modify it, it's hardcoded in DB (and so could be in the code). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #59 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- The default (In reply to Jonathan Druart from comment #58)
t I believe so. Restrictions need a type, even if one is not explicitly chosen. Also, we need an ability to say "if a restriction type is deleted, any restrictions that use this type should fall back to type X", the default flag indicates which type is X.
I do not remember I saw a way to modify it, it's hardcoded in DB (and so could be in the code).
You're absolutely right, the default must always be "MANUAL" due to the way the restrictions were originally implemented, however the name can be changed so as far as the user is concerned, it can be anything they wish. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95255|0 |1 is obsolete| | --- Comment #60 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 99893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99893&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95256|0 |1 is obsolete| | --- Comment #61 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 99894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99894&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95257|0 |1 is obsolete| | --- Comment #62 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 99895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99895&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95258|0 |1 is obsolete| | --- Comment #63 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 99896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99896&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95259|0 |1 is obsolete| | --- Comment #64 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 99897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99897&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95260|0 |1 is obsolete| | --- Comment #65 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 99898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99898&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95261|0 |1 is obsolete| | --- Comment #66 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 99899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99899&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95262|0 |1 is obsolete| | --- Comment #67 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 99900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99900&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95263|0 |1 is obsolete| | --- Comment #68 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 99901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99901&action=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95264|0 |1 is obsolete| | --- Comment #69 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 99902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99902&action=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Isherwood from comment #57)
(In reply to Jonathan Druart from comment #54)
So you are adding a regression, the restrictions are no longer translatable.
They were previously held in borrower_debarments.type, they are now in debarment_types, so I'm guessing adding translation support for the default values is not an insurmountable problem, I am happy to add whatever work is required to make that happen to this bug. Any additional values are added by the user anyway, so are by their nature translatable.
This is a blocker. Please provide a fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- To resume, We have 4 defaults 'SUSPENSION','OVERDUES','MANUAL','DISCHARGE'. Prior to this patch, they were translatable from the template (see SWITCH in borrower_debarments.inc). Now you can edit their description in the new admin view, but they cannot be correctly translated (depending on the language of the interface). I made one suggestion to Andrew: remove the ability to edit the lib for those 4 defaults. So we could still use the SWITCH and default to the description for the others. But it seems that it won't fit the need of the sponsor. I do not have another solution however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We need Ben to varify that they really want to change the description of any of the following types: 'Manual', 'Overdues', 'Suspension', 'Discharge' And, to be honest, those should be easily altered via JS if required.. I don't think this should block the rest of the work. So.. to me it feels like we just need to take the same approach as we now have with the accounts system, where the original system types are all coded in the template and thus translations are not lost and then we fallback to descriptions from the database for any new types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 99898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99898 Bug 23681: Allow for changes to debarments Review of attachment 99898: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23681&attachment=99898) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc @@ -26,5 @@
- Overdues - [% CASE 'SUSPENSION' %] - Suspension - [% CASE 'DISCHARGE' %] - Discharge
Simply adding [% CASE %] [% restriction_types.$dtype.display_text | html %] To the end of this SWITCH block instead of replacing the block entirely should get this passed QA in my opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart@bugs.koha-c | |ommunity.org | Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The customer requires being able to change the hard coded values.. as such this bug is blocked until we have translatable authorized values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 [Bug 24975] Refactor database translations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could we do something like an overwrite option? We use the default descriptions when the lib/lib_opac are empty and we use the description of those, if they are set? The other things is me wondering if using authorized value would not only be a temporary solution, making it necessary soon to move debarment types to their own table to be more flexible with configuration. In this case we could have a column for the description too - it would be even a little easier. And we could then develop the table further to have more columns that make the behavior of a debarment more granular (block renewals, block issuing, block holds, which category types can it be applied to, etc.). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #75)
Could we do something like an overwrite option?
We use the default descriptions when the lib/lib_opac are empty and we use the description of those, if they are set?
Nope, that would still break translations as Jonathan suggests. The issue is that you cant define that default for each language.. only a single language.
The other things is me wondering if using authorized value would not only be a temporary solution, making it necessary soon to move debarment types to their own table to be more flexible with configuration. In this case we could have a column for the description too - it would be even a little easier.
This development doesn't use AV's specifically for the reasons you suggest.
And we could then develop the table further to have more columns that make the behavior of a debarment more granular (block renewals, block issuing, block holds, which category types can it be applied to, etc.).
I've been waiting years for the AV translations proof work to work their way through.. their holding up a whole plethora of bugs including this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I thought we could do it similar to account types, just with the addition of allowing to overwrite the standard description. If the overwrite is empty, we use what is in the templates. So we could keep the standard ones translatable. For the table vs AV - I was didn't read far enough - sorry. But... if we are no longer translating an AV... shoudl this not be a little easier in terms of 'hugeness' of development? Maybe it would be easier to start here doing something similar than we have for itemtypes? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #78 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I see this bug is a bit stuck, but commenting to say I like the idea! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99893|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130373&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99894|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130374&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99895|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130375&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99896|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130376&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99897|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130377&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99898|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130378&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99899|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130379&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99900|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130380&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99901|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130381&action=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99902|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130382&action=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130383&action=edit Bug 23681: (follow-up) Fix rebase issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130384&action=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24975 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 [Bug 24975] Refactor database translations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased and added a follow-up to do as Katrin suggested.. we now use hardcoded translations in the template if the defaults are left unaltered in the existing debarment types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Starting here: 1) QA test tools Processing files before patches |========================>| 18 / 18 (100.00%) Processing files after patches No schema file found for table debarment_types at /kohadevbox/qa-test-tools/QohA/File/Specific/Kohastructure.pm line 118. No schema file found for table debarment_types at /kohadevbox/qa-test-tools/QohA/File/Specific/Kohastructure.pm line 118. |========================>| 18 / 18 (100.00%) FAIL Koha/RestrictionType.pm FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) FAIL Koha/RestrictionTypes.pm FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) FAIL admin/restrictions.pl FAIL critic Subroutine "new" called using indirect syntax at line 27, column 13. See page 349 of PBP. FAIL forbidden patterns forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 38) OK circ/circulation.pl OK installer/data/mysql/kohastructure.sql OK installer/data/mysql/mandatory/sysprefs.sql FAIL koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss FAIL css_and_scss_in_sync Found CSS file not in sync with its SCSS file, use yarn build. This is not blocker, testers can generate the .css file if they need it, see https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... OK koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt FAIL forbidden patterns forbidden pattern: Title elements must start with the unique information (bug 26703) (line 6) OK koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt OK koha-tmpl/intranet-tmpl/prog/js/restrictiontypes.js OK members/memberentry.pl OK members/mod_debarment.pl OK members/moremember.pl FAIL t/db_dependent/RestrictionType.t FAIL file permissions File must have the exec flag FAIL t/db_dependent/RestrictionTypes.t FAIL file permissions File must have the exec flag 2) Sample data for installer The sample data added here is .sql not a .yml, but they might contain strings to translate. Can you please verify? But we still need the .sql files to add to the remaining 'old style' installers. 3) Database structure ronly and dflt could be improved as column names. ronly = read only, but dlft? Otherwise as far as I can tell it all seems to match up between new and updated installations. 4) Preference So the preference is only about the pull down when adding a patron restriction, correct? If you want to make me really happy, please and with a . :) But I believe options need to be changed to 1 and 0? + - pref: PatronRestrictionTypes + choices: + yes: Allow + no: Don't allow + - "the type of patron restriction to be specified when applying manually" 5) Page title It needs to be updated to reflect the accessibility work starting with the most specific bits, but I think the QA tool already caught that: +<title>Koha › Administration › Patron restrictions › [% IF op == 'add_form' %][% IF ( restriction ) %]Modify restriction '[% restriction.display_text | html %]'[% ELSE %]New restriction[% END %][% END %] 6) New permission - OK I wondered if the new permission should be assigned to someone... but I guess it works ok. If the user has module permission already, they will have permission for the new page. Otherwise it will have to be assigned, but existing functionality keeps working meanwhile. So all good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130373|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132302&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130374|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132303&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130375|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132304&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130376|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132305&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130377|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132306&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130378|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132307&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130379|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132308&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130380|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132309&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130381|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132310&action=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130382|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132311&action=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130383|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132312&action=edit Bug 23681: (follow-up) Fix rebase issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130384|0 |1 is obsolete| | --- Comment #104 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132313&action=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #105 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132314&action=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #106 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132315&action=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #107 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132316&action=edit Bug 23681: CSS Build -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #108 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- QA Fixes Done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #109 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- More to do... I missed Katrins extra comments beyond the QA script failure.. oops -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132318&action=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132318|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132319&action=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #112 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132320&action=edit Bug 23681: (QA follow-up) Fix prefs Add the missing `.` and switch from `yes/no` to `1/0`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #113 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #92)
2) Sample data for installer
I think this is dealt with by having it in the templates instead
3) Database structure
ronly and dflt could be improved as column names. ronly = read only, but dlft?
dflt = default, but this is a reserved word so I updated it to is_system (which other places already use)
4) Preference
Done
5) Page title
Done
6) New permission - OK
I think this is OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #114 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, this got rather long again. It might not look like it, but I think we are really close and it WOULD make a great starting point for making the restriction system more granular. 1) Installer data again (In reply to Martin Renvoize from comment #113)
(In reply to Katrin Fischer from comment #92)
2) Sample data for installer
I think this is dealt with by having it in the templates instead
I had a closer look here and the installer file needs updating one way around or the other: I we don't want to translate it, it should be in https://git.koha-community.org/Koha-community/Koha/src/branch/master/install.... If we don't have it wrong, we should transform to .yml and also add it to fr-FR, the remaining SQL installer. The .yml file structure looks easy enough in how to mark the translatable bits and how to add a description for the installer: https://git.koha-community.org/Koha-community/Koha/src/branch/master/install... I either case the .txt needs to be removed. I think the latter would be the nicer solution, as the display text translated would still be nice for reports and such. (I'd also be in favor of moving account_credit_types and debit_types for that reason, but that's another story :) ) +INSERT INTO debarment_types (code, display_text, readonly, system) VALUES + ('MANUAL', 'Manual', 1, 1), + ('OVERDUES', 'Overdues', 1, 0), + ('SUSPENSION', 'Suspension', 1, 0), + ('DISCHARGE', 'Discharge', 1, 0); 2) CSS update I believe Bug 23681: CSS Build should be dropped. It's expected that you generate the CSS files locally. It might create conflicts, but I can just drop/skip it then. 3) Typo in database update / column names a) + system tinyint(1) NOT NULL DEFAULT 0 Should be: is_system. I've fixed it locally for testing further: alter table debarment_types rename column system to is_system; b) I have been thinking more about the different columns and I think there is an error there: +------------+--------------+----------+-----------+ | code | display_text | readonly | is_system | +------------+--------------+----------+-----------+ | DISCHARGE | Discharge | 1 | 0 | | MANUAL | Manual | 1 | 1 | | OVERDUES | Overdues | 1 | 0 | | SUSPENSION | Suspension | 1 | 0 | +------------+--------------+----------+-----------+ read_only should be is_system = It's internal, don't change it. Applies to all currently added ones. is_system, was dflt = default = means it's used when the pref is turned off. So it should be default actually. AND: I think we need another column: can_be_added_manually (see account_credit_types for comparison) Because right now the list of restrictions on the patron account will show ALL restrictions defined in debarment_types and I feel like we are asking for trouble if we allow to set restrictions manually that are supposed to be added automatically. Like a DISCHARGE restriction should be linked to an entry in the discharges table somehow, an OVERDUES restriction can be lifted automatically if all overdues are returned, SUSPENSION is calculated on late returns... I'd feel we might want to leave them out of the pulldown really to keep internal behaviors untouched. 4) System preference (sorry, only saw this in the GUI) Currently the pref appears under "Patrons > Patron relationships", but this is the section for guarantor and family account stuff. I suggest moving it into the "Accounting > Features" tab, that maybe didn't exist yet when this was first written. 5) Page title There is a > left at the beginning that should not be there if you look at the tab in the browser. 6) Deleting a restriction When I try to delete a newly created restriction, I see: Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237 7) Tests are failing :( prove t/db_dependent/RestrictionType.t t/db_dependent/RestrictionTypes.t t/db_dependent/RestrictionType.t ... 1/3 # Failed test 'keyed_on_code returns correctly' # at t/db_dependent/RestrictionType.t line 58. # Structures begin differing at: # $got->{MANUAL} = HASH(0x5618db704c68) # $expected->{MANUAL} = Does not exist # Looks like you failed 1 test of 3. t/db_dependent/RestrictionType.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests t/db_dependent/RestrictionTypes.t .. 1/6 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /kohadevbox/koha/Koha/Objects.pm line 96 Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237. # Looks like your test exited with 11 just after 3. t/db_dependent/RestrictionTypes.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 3/6 subtests Test Summary Report ------------------- t/db_dependent/RestrictionType.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 3 Non-zero exit status: 1 t/db_dependent/RestrictionTypes.t (Wstat: 2816 Tests: 3 Failed: 0) Non-zer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16223 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132302|0 |1 is obsolete| | CC| |emmi.takkinen@koha-suomi.fi --- Comment #115 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134512&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132303|0 |1 is obsolete| | --- Comment #116 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134513&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132304|0 |1 is obsolete| | --- Comment #117 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134514&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132305|0 |1 is obsolete| | --- Comment #118 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134515&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132306|0 |1 is obsolete| | --- Comment #119 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134516&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132307|0 |1 is obsolete| | --- Comment #120 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134517&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132308|0 |1 is obsolete| | --- Comment #121 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134518&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132309|0 |1 is obsolete| | --- Comment #122 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134519&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132310|0 |1 is obsolete| | --- Comment #123 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134520&action=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132311|0 |1 is obsolete| | --- Comment #124 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134521&action=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132312|0 |1 is obsolete| | --- Comment #125 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134522&action=edit Bug 23681: (follow-up) Fix rebase issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132313|0 |1 is obsolete| | --- Comment #126 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134523&action=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132314|0 |1 is obsolete| | --- Comment #127 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134524&action=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132315|0 |1 is obsolete| | --- Comment #128 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134525&action=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132319|0 |1 is obsolete| | --- Comment #129 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134526&action=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132320|0 |1 is obsolete| | --- Comment #130 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134527&action=edit Bug 23681: (QA follow-up) Fix prefs Add the missing `.` and switch from `yes/no` to `1/0`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #131 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134528&action=edit Bug 23681: Fix QA issues This patch fixes following QA issues: - convert intaller files as .yml - change column name readonly as is_system - change column name is_system as default_value - add column can_be_added_manually (testplan for this below) - move syspref "PatronRestrictionTypes" to "Accounting > Features" tab - tweak page title - tweak tests to apply these changes Also atomicupdate files have been updated. Issues with delete and tests is fixed with adding additional schema change file. To test: 1) Add new restriction type and make it manual. 2) Navigate to patron details page. 3) Add new restriction to patron. => Only selectable restriction should be the one you just created. Also prove t/db_dependent/RestrictionTypes.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #132 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 134529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134529&action=edit Bug 23681: DO NOT PUSH! Schema changes To be able to delete and pass tests we need to declare koha_object[s]_class to DebarmentType.pm. Otherwise following error is raised: "Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132316|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #133 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Rebased patches and added couple new ones where I hopefully catched up all QA issues from comment 114. Also I dropped and obsoleted CSS patch since it broke the UI in several pages and as Katrin stated:
It's expected that you generate the CSS files locally.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #134 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for jumping on this rebase and clean up Emmi, teamwork for the win! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #135 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Testing follow-ups now.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #136 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We're back to failing here.. whilst I understand the want to translate the system options, this follow-up breaks the ability to customise those same options for display... which was a core requirement for the original Sponsor. I'm torn.. I feel you should be able to customise those if you really want to. I also think that the 'Manual' option should be listed as one you can add manually ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #137 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I also disagree with the syspref move.. this isn't an accounting feature.. it has nothing to do with money. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #138 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think the pref should live under circulation or patron tabs somewhere.. we already have some Debartment/Restriction preferences it could perhaps go with. AutoRemoveOverduesRestrictions, RestrictionBlockRenewing, CumulativeRestrictionPeriods all appear under circulation.. so I reckon that's where if fits. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #139 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I can happily move the pref.. but the translation vs customisation is a wider issue.. it needs some cleaning up either way, but I need input. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #140 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- See coment 75, 76, 77 and 91 for details about the way translations were handled here.. it was a very deliberate choice to leave them as translations in the Templates and not move them to the Database.. but moving them to the database here we loose the ability to define custom display texts locally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #141 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Working on follow-ups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #142 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Martin Renvoize from comment #137)
I also disagree with the syspref move.. this isn't an accounting feature.. it has nothing to do with money.
Oof, I misunderstood "Accounting" part here. Accounting => account => everything that has something to do with handling patrons account :') But I agree, the syspref should probably be put either under Patron->General or maybe Circulation->Checkout, since most of the other similar sysprefs are there (personally I think we could have section for restrictions or even general section for patron account handling but that's a whole different thing). As for not being able to modify default restrictions, that's a mistake in code. This line
$restriction->display_text($display_text); should be above unless statement. After moving it system restrictions can at least be modified from UI.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #143 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- And I forgot to add to my first comment, I didn't include fr-FR translated files in these patches as Katrin suggested, since I'm not a native speaker/don't even speak french :D So they are still missing from here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #144 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hi Emmi, I do really appreciate your work here, hope I didn't come across mean in my comments.. it turned out a little more verbose than intended as I worked out how it all fits together again. Do you happen to still have a branch around for this? I've got a couple of follow-up patches to add but I've discovered that when trying to apply the patches from here I get some weird unexpected conflicts and the result is that we somehow drop a patch when applying at the moment. If you still have the branch, I could use that as a base to try and work on the fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #145 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Martin Renvoize from comment #144)
Hi Emmi,
I do really appreciate your work here, hope I didn't come across mean in my comments.. it turned out a little more verbose than intended as I worked out how it all fits together again.
You didn't sound mean at all, so don't worry :o And I understand perfectly that these thinks tend to turn out more complex than they first look :D
Do you happen to still have a branch around for this? I've got a couple of follow-up patches to add but I've discovered that when trying to apply the patches from here I get some weird unexpected conflicts and the result is that we somehow drop a patch when applying at the moment.
If you still have the branch, I could use that as a base to try and work on the fixes.
I do, here: https://github.com/emta001/Koha/tree/bug-23681 Can you get it from there? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #146 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome, that worked perfectly.. no idea why the patches on BZ apply weirdly. Right.. I'll add my follow-ups shortly.. may squash a few patches too, but keep enough that we get all the attributions after so many people have worked on this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134512|0 |1 is obsolete| | --- Comment #147 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134580&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134513|0 |1 is obsolete| | --- Comment #148 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134581&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134514|0 |1 is obsolete| | --- Comment #149 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134582&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134515|0 |1 is obsolete| | --- Comment #150 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134583&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134516|0 |1 is obsolete| | --- Comment #151 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134584&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134517|0 |1 is obsolete| | --- Comment #152 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134585&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134518|0 |1 is obsolete| | --- Comment #153 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134586&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134519|0 |1 is obsolete| | --- Comment #154 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134587&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134520|0 |1 is obsolete| | --- Comment #155 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134588&action=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134521|0 |1 is obsolete| | --- Comment #156 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134589&action=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134522|0 |1 is obsolete| | --- Comment #157 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134590&action=edit Bug 23681: (follow-up) Fix rebase issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134523|0 |1 is obsolete| | --- Comment #158 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134591&action=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134524|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134592&action=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134525|0 |1 is obsolete| | --- Comment #160 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134593&action=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134526|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134594&action=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134527|0 |1 is obsolete| | --- Comment #162 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134595&action=edit Bug 23681: (QA follow-up) Fix prefs Add the missing `.` and switch from `yes/no` to `1/0`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134528|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134596&action=edit Bug 23681: Fix QA issues This patch fixes following QA issues: - convert intaller files as .yml - change column name readonly as is_system - change column name is_system as default_value - add column can_be_added_manually (testplan for this below) - move syspref "PatronRestrictionTypes" to "Accounting > Features" tab - tweak page title - tweak tests to apply these changes Also atomicupdate files have been updated. Issues with delete and tests is fixed with adding additional schema change file. To test: 1) Add new restriction type and make it manual. 2) Navigate to patron details page. 3) Add new restriction to patron. => Only selectable restriction should be the one you just created. Also prove t/db_dependent/RestrictionTypes.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134529|0 |1 is obsolete| | --- Comment #164 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134597&action=edit Bug 23681: DO NOT PUSH! Schema changes To be able to delete and pass tests we need to declare koha_object[s]_class to DebarmentType.pm. Otherwise following error is raised: "Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #165 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134598&action=edit Bug 23681: (QA follow-up) Move preference again This patch removes the new PatronRestrictionTypes preference from the accounting area in preference to creating a new group for 'Patron restriction' related preferences in the circulation preferences tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #166 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134599&action=edit Bug 23681: (QA follow-up) Restore customisablity of description This patch restores the customisability of description for system restriction types. Translatability is not affected as you can translate the defaults via template translation and assuming the end users leave their descriptions at the default, the translations will be picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #167 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134600&action=edit Bug 23681: (QA follow-up) Merge update files This patch merges the three atomic update files into one and also adds a check for foreing key existance to make the update idempotent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #168 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134601&action=edit Bug 23681: (QA follow-up) Proper handling of default option This patch removes the 'can_be_added_manually' flag. Only non-system restriction types can be added manually, so we exclude is_system instead of having two flags. (And we set the 'Manual' that's added at install time to default but not system). We then add proper handling for setting the default manual restriction type in the management page and set the dropdown list to use that value by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #169 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134602&action=edit Bug 23681: DBIC Rebuild -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #170 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- That was "fun".. The patchset now all applies cleanly again and I believe the default handling now works as requested along with only displaying non system types as manually addable. The translation options are also fixed. Back to the QA queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #171 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is one fail in the QA test tools here: FAIL installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column debarment_types.is_system is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/DebarmentType.pm), see the SQL12 coding guideline The new column debarment_types.is_default is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/DebarmentType.pm), see the SQL12 coding guideline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #172 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also tests are failing: prove t/db_dependent/RestrictionType.t t/db_dependent/RestrictionTypes.t t/db_dependent/RestrictionType.t ... 1/3 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.default_value' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 96 # Looks like your test exited with 11 just after 2. t/db_dependent/RestrictionType.t ... Dubious, test returned 11 (wstat 2816, 0xb00) Failed 1/3 subtests t/db_dependent/RestrictionTypes.t .. 1/6 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.default_value' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 96 # Looks like your test exited with 11 just after 3. t/db_dependent/RestrictionTypes.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 3/6 subtests Test Summary Report ------------------- t/db_dependent/RestrictionType.t (Wstat: 2816 Tests: 2 Failed: 0) Non-zero exit status: 11 Parse errors: Bad plan. You planned 3 tests but ran 2. t/db_dependent/RestrictionTypes.t (Wstat: 2816 Tests: 3 Failed: 0) Non-zero exit status: 11 Parse errors: Bad plan. You planned 6 tests but ran 3. Files=2, Tests=5, 2 wallclock secs ( 0.01 usr 0.01 sys + 1.88 cusr 0.15 csys = 2.05 CPU) Result: FAIL I made sure to apply the database update before running the tests. Can you please check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134580|0 |1 is obsolete| | --- Comment #173 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134684&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134581|0 |1 is obsolete| | --- Comment #174 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134685&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134582|0 |1 is obsolete| | --- Comment #175 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134686&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134583|0 |1 is obsolete| | --- Comment #176 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134687&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134584|0 |1 is obsolete| | --- Comment #177 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134688&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134585|0 |1 is obsolete| | --- Comment #178 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134689&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134586|0 |1 is obsolete| | --- Comment #179 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134690&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134587|0 |1 is obsolete| | --- Comment #180 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134691&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134588|0 |1 is obsolete| | --- Comment #181 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134692&action=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134589|0 |1 is obsolete| | --- Comment #182 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134693&action=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134590|0 |1 is obsolete| | --- Comment #183 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134694&action=edit Bug 23681: (follow-up) Fix rebase issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134591|0 |1 is obsolete| | --- Comment #184 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134696&action=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134592|0 |1 is obsolete| | --- Comment #185 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134697&action=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134593|0 |1 is obsolete| | --- Comment #186 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134698&action=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134594|0 |1 is obsolete| | --- Comment #187 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134699&action=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134595|0 |1 is obsolete| | --- Comment #188 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134700&action=edit Bug 23681: (QA follow-up) Fix prefs Add the missing `.` and switch from `yes/no` to `1/0`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134596|0 |1 is obsolete| | --- Comment #189 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134701&action=edit Bug 23681: Fix QA issues This patch fixes following QA issues: - convert intaller files as .yml - change column name readonly as is_system - change column name is_system as default_value - add column can_be_added_manually (testplan for this below) - move syspref "PatronRestrictionTypes" to "Accounting > Features" tab - tweak page title - tweak tests to apply these changes Also atomicupdate files have been updated. Issues with delete and tests is fixed with adding additional schema change file. To test: 1) Add new restriction type and make it manual. 2) Navigate to patron details page. 3) Add new restriction to patron. => Only selectable restriction should be the one you just created. Also prove t/db_dependent/RestrictionTypes.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134597|0 |1 is obsolete| | --- Comment #190 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134702&action=edit Bug 23681: DO NOT PUSH! Schema changes To be able to delete and pass tests we need to declare koha_object[s]_class to DebarmentType.pm. Otherwise following error is raised: "Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134598|0 |1 is obsolete| | --- Comment #191 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134703&action=edit Bug 23681: (QA follow-up) Move preference again This patch removes the new PatronRestrictionTypes preference from the accounting area in preference to creating a new group for 'Patron restriction' related preferences in the circulation preferences tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134599|0 |1 is obsolete| | --- Comment #192 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134704&action=edit Bug 23681: (QA follow-up) Restore customisablity of description This patch restores the customisability of description for system restriction types. Translatability is not affected as you can translate the defaults via template translation and assuming the end users leave their descriptions at the default, the translations will be picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134600|0 |1 is obsolete| | --- Comment #193 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134705&action=edit Bug 23681: (QA follow-up) Merge update files This patch merges the three atomic update files into one and also adds a check for foreing key existance to make the update idempotent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134601|0 |1 is obsolete| | --- Comment #194 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134706&action=edit Bug 23681: (QA follow-up) Proper handling of default option This patch removes the 'can_be_added_manually' flag. Only non-system restriction types can be added manually, so we exclude is_system instead of having two flags. (And we set the 'Manual' that's added at install time to default but not system). We then add proper handling for setting the default manual restriction type in the management page and set the dropdown list to use that value by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134602|0 |1 is obsolete| | --- Comment #195 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134707&action=edit Bug 23681: DBIC Rebuild -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #196 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134708&action=edit Bug 23681: (follow-up) Mark fields at booleans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #197 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- One more little follow-up for the booleans issue and a rebase to fix the other problems. Hopefully it should all be passing now Katrin :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 MichaelaSieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #198 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134684|0 |1 is obsolete| | --- Comment #199 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136716&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134685|0 |1 is obsolete| | --- Comment #200 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136717&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134686|0 |1 is obsolete| | --- Comment #201 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136718&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134687|0 |1 is obsolete| | --- Comment #202 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136719&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134688|0 |1 is obsolete| | --- Comment #203 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136720&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134689|0 |1 is obsolete| | --- Comment #204 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136721&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134690|0 |1 is obsolete| | --- Comment #205 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136722&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134691|0 |1 is obsolete| | --- Comment #206 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136723&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134692|0 |1 is obsolete| | --- Comment #207 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136724&action=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134693|0 |1 is obsolete| | --- Comment #208 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136725&action=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134694|0 |1 is obsolete| | --- Comment #209 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136726&action=edit Bug 23681: (follow-up) Fix rebase issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134696|0 |1 is obsolete| | --- Comment #210 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136727&action=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134697|0 |1 is obsolete| | --- Comment #211 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136728&action=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134698|0 |1 is obsolete| | --- Comment #212 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136729&action=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134699|0 |1 is obsolete| | --- Comment #213 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136730&action=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134700|0 |1 is obsolete| | --- Comment #214 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136731&action=edit Bug 23681: (QA follow-up) Fix prefs Add the missing `.` and switch from `yes/no` to `1/0`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134701|0 |1 is obsolete| | --- Comment #215 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136732&action=edit Bug 23681: Fix QA issues This patch fixes following QA issues: - convert intaller files as .yml - change column name readonly as is_system - change column name is_system as default_value - add column can_be_added_manually (testplan for this below) - move syspref "PatronRestrictionTypes" to "Accounting > Features" tab - tweak page title - tweak tests to apply these changes Also atomicupdate files have been updated. Issues with delete and tests is fixed with adding additional schema change file. To test: 1) Add new restriction type and make it manual. 2) Navigate to patron details page. 3) Add new restriction to patron. => Only selectable restriction should be the one you just created. Also prove t/db_dependent/RestrictionTypes.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134702|0 |1 is obsolete| | --- Comment #216 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136733&action=edit Bug 23681: DO NOT PUSH! Schema changes To be able to delete and pass tests we need to declare koha_object[s]_class to DebarmentType.pm. Otherwise following error is raised: "Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134703|0 |1 is obsolete| | --- Comment #217 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136734&action=edit Bug 23681: (QA follow-up) Move preference again This patch removes the new PatronRestrictionTypes preference from the accounting area in preference to creating a new group for 'Patron restriction' related preferences in the circulation preferences tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134704|0 |1 is obsolete| | --- Comment #218 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136735&action=edit Bug 23681: (QA follow-up) Restore customisablity of description This patch restores the customisability of description for system restriction types. Translatability is not affected as you can translate the defaults via template translation and assuming the end users leave their descriptions at the default, the translations will be picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134705|0 |1 is obsolete| | --- Comment #219 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136736&action=edit Bug 23681: (QA follow-up) Merge update files This patch merges the three atomic update files into one and also adds a check for foreing key existance to make the update idempotent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134706|0 |1 is obsolete| | --- Comment #220 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136737&action=edit Bug 23681: (QA follow-up) Proper handling of default option This patch removes the 'can_be_added_manually' flag. Only non-system restriction types can be added manually, so we exclude is_system instead of having two flags. (And we set the 'Manual' that's added at install time to default but not system). We then add proper handling for setting the default manual restriction type in the management page and set the dropdown list to use that value by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134707|0 |1 is obsolete| | --- Comment #221 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136738&action=edit Bug 23681: DBIC Rebuild -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134708|0 |1 is obsolete| | --- Comment #222 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136739&action=edit Bug 23681: (follow-up) Mark fields at booleans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #223 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31095 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 [Bug 31095] Koha::Patron::Debarment should be updated to follow current Koha:: style -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #224 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Starting QA here: 0) Tests pass. QA script complains a lot about "added and removed in the same patch set", we could consider some squashing. Database update is missing execute permission. 1) The new patron restrictions configuration page is missing from the Administration side menu, visible when you are on any of the admin pages. It's ok on the start page of the module. 2) The delete confirmation question is missing a question mark :) (also might want to remove the additional spaces) Are you sure you want to delete " Test " I'd also make the button just "Delete" or "Yes, delete", but that's a personal preference and I see that this was 'copied' from how deleting a patron category looks like. 3) After installing/updating with this patch, MANUAL is marked es the default. You cannot change it, until you have added a new restriction, which makes sense, as the system internal ones should not be default. But: you cannot ever change the default back to MANUAL. I think this is because system internal values are excluded, but it might raise complaints for people experimenting with the feature that want to restore previous behavior. 4) Just a comment: Love the new Patron restrictions sub heading in patron preferences :) 5) When adding a manual restriction to the patron account, the default seems to be only used when PatronRestrictionTypes is off, when it's on and the pull down shows, the default is not preselected, but the first entry is. 6) Something super odd: In the patron account in the staff interface, on the checkout tab, the Restrictions shows as (0), while on the details tab the restrictions show the correct number (2) I have added. Only the tab heading is wrong, otherwise the restrictions show ok. 7) When editing the patron record, the pull down for restriction type is empty. 8) I notice that the type itself doesn't show up in the OPAC or the note on the patron account in staff, just the comments do. This is the case with and without the patches, maybe something so consider later. Or we could imagine adding a default comment? (no blocker, just loud thinking) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #225 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #224)
Starting QA here:
0) Tests pass. QA script complains a lot about "added and removed in the same patch set", we could consider some squashing. Database update is missing execute permission.
I think this is a QA script mis-identification.. the file it mentions is also mentioned in the git manip.. i.e. it no longer exists and the remaining renamed file does have the exec bit set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #226 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #225)
(In reply to Katrin Fischer from comment #224)
Starting QA here:
0) Tests pass. QA script complains a lot about "added and removed in the same patch set", we could consider some squashing. Database update is missing execute permission.
I think this is a QA script mis-identification.. the file it mentions is also mentioned in the git manip.. i.e. it no longer exists and the remaining renamed file does have the exec bit set.
I think you are right about this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136716|0 |1 is obsolete| | --- Comment #227 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137066&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136717|0 |1 is obsolete| | --- Comment #228 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137067&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136718|0 |1 is obsolete| | --- Comment #229 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137068&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136719|0 |1 is obsolete| | --- Comment #230 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137069&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136720|0 |1 is obsolete| | --- Comment #231 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137070&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136721|0 |1 is obsolete| | --- Comment #232 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137071&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136722|0 |1 is obsolete| | --- Comment #233 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137072&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136723|0 |1 is obsolete| | --- Comment #234 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137073&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136724|0 |1 is obsolete| | --- Comment #235 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137074&action=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136725|0 |1 is obsolete| | --- Comment #236 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137075&action=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136726|0 |1 is obsolete| | --- Comment #237 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137076&action=edit Bug 23681: (follow-up) Fix rebase issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136727|0 |1 is obsolete| | --- Comment #238 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137077&action=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136728|0 |1 is obsolete| | --- Comment #239 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137078&action=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136729|0 |1 is obsolete| | --- Comment #240 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137079&action=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136730|0 |1 is obsolete| | --- Comment #241 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137080&action=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136731|0 |1 is obsolete| | --- Comment #242 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137081&action=edit Bug 23681: (QA follow-up) Fix prefs Add the missing `.` and switch from `yes/no` to `1/0`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136732|0 |1 is obsolete| | --- Comment #243 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137082&action=edit Bug 23681: Fix QA issues This patch fixes following QA issues: - convert intaller files as .yml - change column name readonly as is_system - change column name is_system as default_value - add column can_be_added_manually (testplan for this below) - move syspref "PatronRestrictionTypes" to "Accounting > Features" tab - tweak page title - tweak tests to apply these changes Also atomicupdate files have been updated. Issues with delete and tests is fixed with adding additional schema change file. To test: 1) Add new restriction type and make it manual. 2) Navigate to patron details page. 3) Add new restriction to patron. => Only selectable restriction should be the one you just created. Also prove t/db_dependent/RestrictionTypes.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136733|0 |1 is obsolete| | --- Comment #244 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137083&action=edit Bug 23681: DO NOT PUSH! Schema changes To be able to delete and pass tests we need to declare koha_object[s]_class to DebarmentType.pm. Otherwise following error is raised: "Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136734|0 |1 is obsolete| | --- Comment #245 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137084&action=edit Bug 23681: (QA follow-up) Move preference again This patch removes the new PatronRestrictionTypes preference from the accounting area in preference to creating a new group for 'Patron restriction' related preferences in the circulation preferences tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136735|0 |1 is obsolete| | --- Comment #246 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137085&action=edit Bug 23681: (QA follow-up) Restore customisablity of description This patch restores the customisability of description for system restriction types. Translatability is not affected as you can translate the defaults via template translation and assuming the end users leave their descriptions at the default, the translations will be picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136736|0 |1 is obsolete| | --- Comment #247 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137086&action=edit Bug 23681: (QA follow-up) Merge update files This patch merges the three atomic update files into one and also adds a check for foreing key existance to make the update idempotent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136737|0 |1 is obsolete| | --- Comment #248 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137087&action=edit Bug 23681: (QA follow-up) Proper handling of default option This patch removes the 'can_be_added_manually' flag. Only non-system restriction types can be added manually, so we exclude is_system instead of having two flags. (And we set the 'Manual' that's added at install time to default but not system). We then add proper handling for setting the default manual restriction type in the management page and set the dropdown list to use that value by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136738|0 |1 is obsolete| | --- Comment #249 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137088&action=edit Bug 23681: DBIC Rebuild -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136739|0 |1 is obsolete| | --- Comment #250 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137089&action=edit Bug 23681: (follow-up) Mark fields at booleans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #251 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137090&action=edit Bug 23681: (QA follow-up) Add patron restrictions to admin menu This patch adds the patron restrictions page to the admin menu that appears to the left on all administration pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #252 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137091&action=edit Bug 23681: (QA follow-up) Remove spacing and add question mark This patch removes the superflous whitespace around the restriction descriptions and also adds the missing question mark into the delete question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #253 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137092&action=edit Bug 23681: (QA follow-up) Match default data to update The default data at install time didn't match the data added at update. This patch corrects that and by doing so it also adds back the ability to make MANUAL restriction types the default after any other type has been made default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #254 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137093&action=edit Bug 23681: (QA follow-up) Fix debarment count This patch fixes the debarment count displayed on the circulation page tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #255 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137094&action=edit Bug 23681: (QA follow-up) Fix memberentry page display We were missing some changes to the restriction types dropdown handling in the memberentry template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #256 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #224)
1) The new patron restrictions configuration page is missing from the Administration side menu, visible when you are on any of the admin pages. It's ok on the start page of the module.
Fixed in follow-up
2) The delete confirmation question is missing a question mark :) (also might want to remove the additional spaces) Are you sure you want to delete " Test "
Fixed in follow-up
I'd also make the button just "Delete" or "Yes, delete", but that's a personal preference and I see that this was 'copied' from how deleting a patron category looks like.
Hmm, I'd love to see us standardise on something and create a guideline about it.. at that time I'd be keen to go through and get everything consistent.
3) After installing/updating with this patch, MANUAL is marked es the default. You cannot change it, until you have added a new restriction, which makes sense, as the system internal ones should not be default. But: you cannot ever change the default back to MANUAL. I think this is because system internal values are excluded, but it might raise complaints for people experimenting with the feature that want to restore previous behavior.
I discovered the update and the install data were out of sync.. fixed in a follow-up. This resolves the defaulting issue.
4) Just a comment: Love the new Patron restrictions sub heading in patron preferences :)
Glad you like it :)
5) When adding a manual restriction to the patron account, the default seems to be only used when PatronRestrictionTypes is off, when it's on and the pull down shows, the default is not preselected, but the first entry is.
Hmm, I couldn't replicate this.
6) Something super odd: In the patron account in the staff interface, on the checkout tab, the Restrictions shows as (0), while on the details tab the restrictions show the correct number (2) I have added. Only the tab heading is wrong, otherwise the restrictions show ok.
Unrelated to this patchset I believe.. bit it is fixed in a follow-up now.
7) When editing the patron record, the pull down for restriction type is empty.
Fixed in follow-up.
8) I notice that the type itself doesn't show up in the OPAC or the note on the patron account in staff, just the comments do. This is the case with and without the patches, maybe something so consider later. Or we could imagine adding a default comment? (no blocker, just loud thinking)
Wow.. wierd.. I'd never noticed that.. can we submit a new bug for that one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31097 [Bug 31097] Patron restriction types should display in Staff and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #257 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #256)
(In reply to Katrin Fischer from comment #224)
I'd also make the button just "Delete" or "Yes, delete", but that's a personal preference and I see that this was 'copied' from how deleting a patron category looks like.
Hmm, I'd love to see us standardise on something and create a guideline about it.. at that time I'd be keen to go through and get everything consistent.
Agreed, I was just wondering, because in German such buttons tend to get huge.
3) After installing/updating with this patch, MANUAL is marked es the default. You cannot change it, until you have added a new restriction, which makes sense, as the system internal ones should not be default. But: you cannot ever change the default back to MANUAL. I think this is because system internal values are excluded, but it might raise complaints for people experimenting with the feature that want to restore previous behavior.
I discovered the update and the install data were out of sync.. fixed in a follow-up. This resolves the defaulting issue.
Good catch! Will retest.
5) When adding a manual restriction to the patron account, the default seems to be only used when PatronRestrictionTypes is off, when it's on and the pull down shows, the default is not preselected, but the first entry is.
Hmm, I couldn't replicate this.
I'll retest.
8) I notice that the type itself doesn't show up in the OPAC or the note on the patron account in staff, just the comments do. This is the case with and without the patches, maybe something so consider later. Or we could imagine adding a default comment? (no blocker, just loud thinking)
Wow.. wierd.. I'd never noticed that.. can we submit a new bug for that one?
Yes, loud thinking definitely warrants a separate bug. I'd also not noticed that before, but it's unchanged by this patch set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #258 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 0) QA script + unit tests RESOLVED 1) Side menu RESOLVED 2) Delete confirmation RESOLVED 3) Default behavior / MANUAL RESOLVED 4) :) 5) Pre-selection in pull down Retested and RESOLVED. 6) Number in restrictions tab RESOLVED 7) When editing the patron record, the pull down for restriction type is empty. RESOLVED 8) Show restriction type in places MOVE to separate bug later :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137066|0 |1 is obsolete| | --- Comment #259 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137102&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137067|0 |1 is obsolete| | --- Comment #260 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137103&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137068|0 |1 is obsolete| | --- Comment #261 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137104&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137069|0 |1 is obsolete| | --- Comment #262 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137105&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137070|0 |1 is obsolete| | --- Comment #263 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137106&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137071|0 |1 is obsolete| | --- Comment #264 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137107&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137072|0 |1 is obsolete| | --- Comment #265 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137108&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137073|0 |1 is obsolete| | --- Comment #266 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137109&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137074|0 |1 is obsolete| | --- Comment #267 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137110&action=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137075|0 |1 is obsolete| | --- Comment #268 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137111&action=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137076|0 |1 is obsolete| | --- Comment #269 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137112&action=edit Bug 23681: (follow-up) Fix rebase issues Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137077|0 |1 is obsolete| | --- Comment #270 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137113&action=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137078|0 |1 is obsolete| | --- Comment #271 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137114&action=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137079|0 |1 is obsolete| | --- Comment #272 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137115&action=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137080|0 |1 is obsolete| | --- Comment #273 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137116&action=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137081|0 |1 is obsolete| | --- Comment #274 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137117&action=edit Bug 23681: (QA follow-up) Fix prefs Add the missing `.` and switch from `yes/no` to `1/0`. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137082|0 |1 is obsolete| | --- Comment #275 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137118&action=edit Bug 23681: Fix QA issues This patch fixes following QA issues: - convert intaller files as .yml - change column name readonly as is_system - change column name is_system as default_value - add column can_be_added_manually (testplan for this below) - move syspref "PatronRestrictionTypes" to "Accounting > Features" tab - tweak page title - tweak tests to apply these changes Also atomicupdate files have been updated. Issues with delete and tests is fixed with adding additional schema change file. To test: 1) Add new restriction type and make it manual. 2) Navigate to patron details page. 3) Add new restriction to patron. => Only selectable restriction should be the one you just created. Also prove t/db_dependent/RestrictionTypes.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137083|0 |1 is obsolete| | --- Comment #276 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137119&action=edit Bug 23681: DO NOT PUSH! Schema changes To be able to delete and pass tests we need to declare koha_object[s]_class to DebarmentType.pm. Otherwise following error is raised: "Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237" Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137084|0 |1 is obsolete| | --- Comment #277 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137120&action=edit Bug 23681: (QA follow-up) Move preference again This patch removes the new PatronRestrictionTypes preference from the accounting area in preference to creating a new group for 'Patron restriction' related preferences in the circulation preferences tab. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137085|0 |1 is obsolete| | --- Comment #278 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137121&action=edit Bug 23681: (QA follow-up) Restore customisablity of description This patch restores the customisability of description for system restriction types. Translatability is not affected as you can translate the defaults via template translation and assuming the end users leave their descriptions at the default, the translations will be picked. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137086|0 |1 is obsolete| | --- Comment #279 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137122&action=edit Bug 23681: (QA follow-up) Merge update files This patch merges the three atomic update files into one and also adds a check for foreing key existance to make the update idempotent. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137087|0 |1 is obsolete| | --- Comment #280 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137123&action=edit Bug 23681: (QA follow-up) Proper handling of default option This patch removes the 'can_be_added_manually' flag. Only non-system restriction types can be added manually, so we exclude is_system instead of having two flags. (And we set the 'Manual' that's added at install time to default but not system). We then add proper handling for setting the default manual restriction type in the management page and set the dropdown list to use that value by default. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137088|0 |1 is obsolete| | --- Comment #281 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137124&action=edit Bug 23681: DBIC Rebuild Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137089|0 |1 is obsolete| | --- Comment #282 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137125&action=edit Bug 23681: (follow-up) Mark fields at booleans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137090|0 |1 is obsolete| | --- Comment #283 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137126&action=edit Bug 23681: (QA follow-up) Add patron restrictions to admin menu This patch adds the patron restrictions page to the admin menu that appears to the left on all administration pages. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137091|0 |1 is obsolete| | --- Comment #284 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137127&action=edit Bug 23681: (QA follow-up) Remove spacing and add question mark This patch removes the superflous whitespace around the restriction descriptions and also adds the missing question mark into the delete question. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137092|0 |1 is obsolete| | --- Comment #285 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137128&action=edit Bug 23681: (QA follow-up) Match default data to update The default data at install time didn't match the data added at update. This patch corrects that and by doing so it also adds back the ability to make MANUAL restriction types the default after any other type has been made default. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137093|0 |1 is obsolete| | --- Comment #286 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137129&action=edit Bug 23681: (QA follow-up) Fix debarment count This patch fixes the debarment count displayed on the circulation page tabs Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137094|0 |1 is obsolete| | --- Comment #287 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137130&action=edit Bug 23681: (QA follow-up) Fix memberentry page display We were missing some changes to the restriction types dropdown handling in the memberentry template. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31129 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31129 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129 [Bug 31129] Number of restrictions is always "0" on the "Check out" tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31136 [Bug 31136] Restrictions types select fails on memberentry page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Bug 23681 depends on bug 31136, which changed state. Bug 31136 Summary: Restrictions types select fails on memberentry page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31136 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate Severity|enhancement |new feature CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron restrictions should |Make patron restrictions |be user definable |user definable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #288 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Can you please rebase? I'll make sure I take care of it once you rebase to avoid further delays. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #289 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I would like to see some squashing as well. But not trying to complicate things too much. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137102|0 |1 is obsolete| | --- Comment #290 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139250&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #291 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139251&action=edit Bug 23681: Add debarment_types table This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #292 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139252&action=edit Bug 23681: Add modify_patron_restrictions permission This patch adds a new "modify_patron_restrictions" permission Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #293 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139253&action=edit Bug 23681: Add Koha Classes This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #294 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139254&action=edit Bug 23681: Add Management UI This patch adds UI to allow CRUD operations on restriction types Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137107|0 |1 is obsolete| | --- Comment #295 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139255&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137108|0 |1 is obsolete| | --- Comment #296 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139256&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137109|0 |1 is obsolete| | --- Comment #297 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139257&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137110|0 |1 is obsolete| | --- Comment #298 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139258&action=edit Bug 23681: Add unit tests Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137113|0 |1 is obsolete| | --- Comment #299 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139259&action=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137114|0 |1 is obsolete| | --- Comment #300 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139260&action=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137115|0 |1 is obsolete| | --- Comment #301 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139261&action=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #302 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139262&action=edit Bug 23681: (QA follow-up) Fix preferences Add the missing `.` and switch from `yes/no` to `1/0`. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137116|0 |1 is obsolete| | --- Comment #303 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139263&action=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137118|0 |1 is obsolete| | --- Comment #304 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139264&action=edit Bug 23681: Fix QA issues This patch fixes following QA issues: - convert intaller files as .yml - change column name readonly as is_system - change column name is_system as default_value - add column can_be_added_manually (testplan for this below) - move syspref "PatronRestrictionTypes" to "Accounting > Features" tab - tweak page title - tweak tests to apply these changes Also atomicupdate files have been updated. Issues with delete and tests is fixed with adding additional schema change file. To test: 1) Add new restriction type and make it manual. 2) Navigate to patron details page. 3) Add new restriction to patron. => Only selectable restriction should be the one you just created. Also prove t/db_dependent/RestrictionTypes.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #305 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139265&action=edit Bug 23681: DBIC Schema To be able to delete and pass tests we need to declare koha_object[s]_class to DebarmentType.pm. Otherwise following error is raised: "Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237" Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137120|0 |1 is obsolete| | --- Comment #306 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139266&action=edit Bug 23681: (QA follow-up) Move preference again This patch removes the new PatronRestrictionTypes preference from the accounting area in preference to creating a new group for 'Patron restriction' related preferences in the circulation preferences tab. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137121|0 |1 is obsolete| | --- Comment #307 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139267&action=edit Bug 23681: (QA follow-up) Restore customisablity of description This patch restores the customisability of description for system restriction types. Translatability is not affected as you can translate the defaults via template translation and assuming the end users leave their descriptions at the default, the translations will be picked. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137122|0 |1 is obsolete| | --- Comment #308 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139268&action=edit Bug 23681: (QA follow-up) Merge update files This patch merges the three atomic update files into one and also adds a check for foreing key existance to make the update idempotent. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137123|0 |1 is obsolete| | --- Comment #309 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139269&action=edit Bug 23681: (QA follow-up) Proper handling of default option This patch removes the 'can_be_added_manually' flag. Only non-system restriction types can be added manually, so we exclude is_system instead of having two flags. (And we set the 'Manual' that's added at install time to default but not system). We then add proper handling for setting the default manual restriction type in the management page and set the dropdown list to use that value by default. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137125|0 |1 is obsolete| | --- Comment #310 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139270&action=edit Bug 23681: (follow-up) Mark fields at booleans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137126|0 |1 is obsolete| | --- Comment #311 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139271&action=edit Bug 23681: (QA follow-up) Add patron restrictions to admin menu This patch adds the patron restrictions page to the admin menu that appears to the left on all administration pages. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137127|0 |1 is obsolete| | --- Comment #312 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139272&action=edit Bug 23681: (QA follow-up) Remove spacing and add question mark This patch removes the superflous whitespace around the restriction descriptions and also adds the missing question mark into the delete question. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137130|0 |1 is obsolete| | --- Comment #313 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139273&action=edit Bug 23681: (QA follow-up) Fix memberentry page display We were missing some changes to the restriction types dropdown handling in the memberentry template. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137104|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137106|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137111|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137112|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137117|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137119|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137129|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #314 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased and squashed as much as I can easily squash.. hopefully that's OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #315 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 139509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139509&action=edit Bug 23681: (QA follow-up) debarment_types => restriction_types The code moved from *debarments* to *restrictions* but the table didn't. This patch just renames things accordingly. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #316 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 139512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139512&action=edit Bug 23681: (QA follow-up) New schema files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #317 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, this is almost done. I added some required follow-ups. But the remaining things are too much for me to take care right now, so failing it and adding my (not so big) list: - The test files should be moved to Koha/RestrictionType*.t [MINOR] - The tests do not cover all the things. They are also mixed. The RestrictionType.t file tests Koha::RestrictionTypes->keyed_on_code - Koha::RestrictionTypes->keyed_on_code is not really required... and is very different than our normal return values... The fact we need to delete everything in order to test it points to some design issue (i.e. it is not a method that acts on $self as a resultset, but works in the whole table. - keyed_on_code should be replaced by something along the lines of: { map { $_->{code} => $_ } $self->as_list } - Koha::RestrictionType->make_default looks great :-D - Koha::RestrictionType->delete has problems. We *could* accept it using plain SQL, but the logic is wrong. If the type is a system one, and exception should be thrown. The same if it is the default ;-) (i.e. it is setting itself as default (again) and then deleting itself). As you can see, we are close to pushing this. Please hurry so no rebases are needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #318 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139649&action=edit Bug 23681: Move to ::Patron::Restriction::Type(s) This patch moves the new classes under ::Patron::Restriction:: and enhances the Unit tests for those classes. NOTE: We should drop keyed_on_code as part of bug 31095 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #319 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, that last patch handles most issues outlined above with the exception of touching keyed_on_code. I found that I'd need to write a fair bit of code to work around that implimentation and I felt it more pertinant to help quickly follow this bug by working on a cleanup in bug 31095 where I intend to drop GetDebarmentTypes and therefore the need for keyed_on_code entirely.. it'll end up much more like the Accounts code using relations properly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139649|0 |1 is obsolete| | --- Comment #320 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139717&action=edit Bug 23681: Move to ::Patron::Restriction::Type(s) This patch moves the new classes under ::Patron::Restriction:: and enhances the Unit tests for those classes. NOTE: We should drop keyed_on_code as part of bug 31095 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139250|0 |1 is obsolete| | --- Comment #321 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139768&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139251|0 |1 is obsolete| | --- Comment #322 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139769&action=edit Bug 23681: Add debarment_types table This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139252|0 |1 is obsolete| | --- Comment #323 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139770&action=edit Bug 23681: Add modify_patron_restrictions permission This patch adds a new "modify_patron_restrictions" permission Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139253|0 |1 is obsolete| | --- Comment #324 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139771&action=edit Bug 23681: Add Koha Classes This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139254|0 |1 is obsolete| | --- Comment #325 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139772&action=edit Bug 23681: Add Management UI This patch adds UI to allow CRUD operations on restriction types Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139255|0 |1 is obsolete| | --- Comment #326 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139773&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139256|0 |1 is obsolete| | --- Comment #327 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139774&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139257|0 |1 is obsolete| | --- Comment #328 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139775&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139258|0 |1 is obsolete| | --- Comment #329 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139776&action=edit Bug 23681: Add unit tests Sponsored-by: Loughborough University Signed-off-by: Benjamin Veasey <B.T.Veasey@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139259|0 |1 is obsolete| | --- Comment #330 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139777&action=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139260|0 |1 is obsolete| | --- Comment #331 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139778&action=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139261|0 |1 is obsolete| | --- Comment #332 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139779&action=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139262|0 |1 is obsolete| | --- Comment #333 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139780&action=edit Bug 23681: (QA follow-up) Fix preferences Add the missing `.` and switch from `yes/no` to `1/0`. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139263|0 |1 is obsolete| | --- Comment #334 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139781&action=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139264|0 |1 is obsolete| | --- Comment #335 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139782&action=edit Bug 23681: Fix QA issues This patch fixes following QA issues: - convert intaller files as .yml - change column name readonly as is_system - change column name is_system as default_value - add column can_be_added_manually (testplan for this below) - move syspref "PatronRestrictionTypes" to "Accounting > Features" tab - tweak page title - tweak tests to apply these changes Also atomicupdate files have been updated. Issues with delete and tests is fixed with adding additional schema change file. To test: 1) Add new restriction type and make it manual. 2) Navigate to patron details page. 3) Add new restriction to patron. => Only selectable restriction should be the one you just created. Also prove t/db_dependent/RestrictionTypes.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139265|0 |1 is obsolete| | --- Comment #336 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139783&action=edit Bug 23681: DBIC Schema To be able to delete and pass tests we need to declare koha_object[s]_class to DebarmentType.pm. Otherwise following error is raised: "Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237" Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139266|0 |1 is obsolete| | --- Comment #337 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139784&action=edit Bug 23681: (QA follow-up) Move preference again This patch removes the new PatronRestrictionTypes preference from the accounting area in preference to creating a new group for 'Patron restriction' related preferences in the circulation preferences tab. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139267|0 |1 is obsolete| | --- Comment #338 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139785&action=edit Bug 23681: (QA follow-up) Restore customisablity of description This patch restores the customisability of description for system restriction types. Translatability is not affected as you can translate the defaults via template translation and assuming the end users leave their descriptions at the default, the translations will be picked. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139268|0 |1 is obsolete| | --- Comment #339 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139786&action=edit Bug 23681: (QA follow-up) Merge update files This patch merges the three atomic update files into one and also adds a check for foreing key existance to make the update idempotent. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139269|0 |1 is obsolete| | --- Comment #340 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139787&action=edit Bug 23681: (QA follow-up) Proper handling of default option This patch removes the 'can_be_added_manually' flag. Only non-system restriction types can be added manually, so we exclude is_system instead of having two flags. (And we set the 'Manual' that's added at install time to default but not system). We then add proper handling for setting the default manual restriction type in the management page and set the dropdown list to use that value by default. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139270|0 |1 is obsolete| | --- Comment #341 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139788&action=edit Bug 23681: (follow-up) Mark fields at booleans Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139271|0 |1 is obsolete| | --- Comment #342 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139789&action=edit Bug 23681: (QA follow-up) Add patron restrictions to admin menu This patch adds the patron restrictions page to the admin menu that appears to the left on all administration pages. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139272|0 |1 is obsolete| | --- Comment #343 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139790&action=edit Bug 23681: (QA follow-up) Remove spacing and add question mark This patch removes the superflous whitespace around the restriction descriptions and also adds the missing question mark into the delete question. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139273|0 |1 is obsolete| | --- Comment #344 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139791&action=edit Bug 23681: (QA follow-up) Fix memberentry page display We were missing some changes to the restriction types dropdown handling in the memberentry template. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139509|0 |1 is obsolete| | --- Comment #345 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139792&action=edit Bug 23681: (QA follow-up) debarment_types => restriction_types The code moved from *debarments* to *restrictions* but the table didn't. This patch just renames things accordingly. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139512|0 |1 is obsolete| | --- Comment #346 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139793&action=edit Bug 23681: (QA follow-up) New schema files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139717|0 |1 is obsolete| | --- Comment #347 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139794&action=edit Bug 23681: Move to ::Patron::Restriction::Type(s) This patch moves the new classes under ::Patron::Restriction:: and enhances the Unit tests for those classes. NOTE: We should drop keyed_on_code as part of bug 31095 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #348 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139795&action=edit Bug 23681: (follow-up) Re-fix ::Patron::Restriction::Type(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #349 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|theod@lib.auth.gr | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Bug 23681 depends on bug 31129, which changed state. Bug 31129 Summary: Number of restrictions is always "0" on the "Check out" tab https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31573 [Bug 31573] Patron restrictions page in administration should hint required syspref PatronRestrictionTypes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugzilla@warmlight.co.uk |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a new release notes| |configuration page for | |managing user defined and | |Koha internal patron | |restrictions to the | |administration module. | | | |If | |the new system preference | |PatronRestrictionTypes is | |enabled, you will also be | |able to choose the | |restriction type when | |manually restricting a | |patron. Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Martin Renvoize contact| | Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/604 Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 [Bug 32787] Patron restrictions admin page has patron categories search bar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32215 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32215 [Bug 32215] 'You Searched for' for patron restrictions is not used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33549 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 [Bug 33549] Patron restriction types - Style missing for dialog messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 [Bug 33551] Rogue span in Patron restriction types admin page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33574 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33574 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33578 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 [Bug 33578] Cannot edit patron restriction types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39936 [Bug 39936] Configure blocks per action and per interface in restriction types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42914 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42914 [Bug 42914] Default restriction is sometime hardcoded to MANUAL -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org