https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #256 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #224)
1) The new patron restrictions configuration page is missing from the Administration side menu, visible when you are on any of the admin pages. It's ok on the start page of the module.
Fixed in follow-up
2) The delete confirmation question is missing a question mark :) (also might want to remove the additional spaces) Are you sure you want to delete " Test "
Fixed in follow-up
I'd also make the button just "Delete" or "Yes, delete", but that's a personal preference and I see that this was 'copied' from how deleting a patron category looks like.
Hmm, I'd love to see us standardise on something and create a guideline about it.. at that time I'd be keen to go through and get everything consistent.
3) After installing/updating with this patch, MANUAL is marked es the default. You cannot change it, until you have added a new restriction, which makes sense, as the system internal ones should not be default. But: you cannot ever change the default back to MANUAL. I think this is because system internal values are excluded, but it might raise complaints for people experimenting with the feature that want to restore previous behavior.
I discovered the update and the install data were out of sync.. fixed in a follow-up. This resolves the defaulting issue.
4) Just a comment: Love the new Patron restrictions sub heading in patron preferences :)
Glad you like it :)
5) When adding a manual restriction to the patron account, the default seems to be only used when PatronRestrictionTypes is off, when it's on and the pull down shows, the default is not preselected, but the first entry is.
Hmm, I couldn't replicate this.
6) Something super odd: In the patron account in the staff interface, on the checkout tab, the Restrictions shows as (0), while on the details tab the restrictions show the correct number (2) I have added. Only the tab heading is wrong, otherwise the restrictions show ok.
Unrelated to this patchset I believe.. bit it is fixed in a follow-up now.
7) When editing the patron record, the pull down for restriction type is empty.
Fixed in follow-up.
8) I notice that the type itself doesn't show up in the OPAC or the note on the patron account in staff, just the comments do. This is the case with and without the patches, maybe something so consider later. Or we could imagine adding a default comment? (no blocker, just loud thinking)
Wow.. wierd.. I'd never noticed that.. can we submit a new bug for that one? -- You are receiving this mail because: You are watching all bug changes.