[Bug 13341] New: Hard-coded "Preview" text in OPAC openlibrary.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Bug ID: 13341 Summary: Hard-coded "Preview" text in OPAC openlibrary.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr ./koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js: $(this).append('<div class="results_summary">' + '<a href="' + book.url + '">Preview</a></div>'); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 34279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34279&action=edit Bug 13341 - Hard-coded "Preview" text in OPAC openlibrary.js The OpenLibrary JavaScript includes an untranslated string, "Preview." This patch move the string to the template so that it can be translated. To test, apply the patch and test that the translator picks up the string: 1. From misc/translator run 'perl translate update [lang]' (e.g. de-DE) 2. Edit misc/translator/po/[lang]-opac-bootstrap.po and add a translation for the updated "Preview" string 3. Remove the "#, fuzzy" marker from that entry 4. From misc/translator run 'perl translate install [lang]' 5. Enable the [lang] translation for the OPAC in system preferences 6. Enable the OpenLibraryCovers system preference. 7. In the OPAC switch to the [lang] translation. 7. View the detail page for a title for which there is an OpenLibrary cover image. Below it you should see a preview link with the translated string you added in step 2. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 34607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34607&action=edit [Signed-off] Bug 13341 - Hard-coded "Preview" text in OPAC openlibrary.js The OpenLibrary JavaScript includes an untranslated string, "Preview." This patch move the string to the template so that it can be translated. To test, apply the patch and test that the translator picks up the string: 1. From misc/translator run 'perl translate update [lang]' (e.g. de-DE) 2. Edit misc/translator/po/[lang]-opac-bootstrap.po and add a translation for the updated "Preview" string 3. Remove the "#, fuzzy" marker from that entry 4. From misc/translator run 'perl translate install [lang]' 5. Enable the [lang] translation for the OPAC in system preferences 6. Enable the OpenLibraryCovers system preference. 7. In the OPAC switch to the [lang] translation. 7. View the detail page for a title for which there is an OpenLibrary cover image. Below it you should see a preview link with the translated string you added in step 2. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34279|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34714&action=edit [PASSED QA] [PASSED QA] Bug 13341 - Hard-coded "Preview" text in OPAC openlibrary.js The OpenLibrary JavaScript includes an untranslated string, "Preview." This patch move the string to the template so that it can be translated. To test, apply the patch and test that the translator picks up the string: 1. From misc/translator run 'perl translate update [lang]' (e.g. de-DE) 2. Edit misc/translator/po/[lang]-opac-bootstrap.po and add a translation for the updated "Preview" string 3. Remove the "#, fuzzy" marker from that entry 4. From misc/translator run 'perl translate install [lang]' 5. Enable the [lang] translation for the OPAC in system preferences 6. Enable the OpenLibraryCovers system preference. 7. In the OPAC switch to the [lang] translation. 7. View the detail page for a title for which there is an OpenLibrary cover image. Below it you should see a preview link with the translated string you added in step 2. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org