[Bug 18429] New: Receiving an item should update the datelastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Bug ID: 18429 Summary: Receiving an item should update the datelastseen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62148&action=edit Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62148|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 62153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62153&action=edit Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron@veron.ch Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 62154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62154&action=edit [SIGNED OFF] Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Works as expected. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Shouldn't it be today instead of date received ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Hmm.. Date received defaults to today - I would say if you are changing that (receiving on past days) you might not physically have the item in hand so are confirming you saw it last on the day you received it? I would think it should be this way, but am open to changing it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62153|0 |1 is obsolete| | Attachment #62154|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62360&action=edit Bug 18429 - Receiving an item should update the datelastseen To test: 0 - Ensure AcqCreateItem is set to 'placing an order' 1 - Order some items, note entrydate and datelastseen match 2 - Alter those dates to be earlier than today (or wait some days) 3 - Recieve the item and note datelast seen not updated 4 - Apply patch 5 - Repeat 1-3 6 - Date last seen should be updated. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Works as expected. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #5)
Hmm..
Date received defaults to today - I would say if you are changing that (receiving on past days) you might not physically have the item in hand so are confirming you saw it last on the day you received it?
I would think it should be this way, but am open to changing it
Sounds reasonable enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org