[Bug 18443] New: Get rid of warning 'uninitialized value $user' in C4/ Auth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Bug ID: 18443 Summary: Get rid of warning 'uninitialized value $user' in C4/Auth.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org plack-error.log log and/or opac-error.log complain about 'uninitialized value $user' in C4/Auth.pm line 187. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 62264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62264&action=edit Bug 18443: Get rid of warning 'uninitialized value $user' in C4/Auth.pm When logging out from OPAC, plack-error.log log and/or opac-error.log complain about 'uninitialized value $user' in C4/Auth.pm line 187. The warning is not necessary, this patch removes it. To test: - try to trigger warning - apply patch - verify that warning no longer occurs - prove t/db_dependent/Auth.t - verifiy that SCO still behaves like before (especially if you break out from sco path) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |veron@veron.ch |y.org | Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62264|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 62270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62270&action=edit [SIGNED-OFF] Bug 18443: Get rid of warning 'uninitialized value $user' in C4/Auth.pm When logging out from OPAC, plack-error.log log and/or opac-error.log complain about 'uninitialized value $user' in C4/Auth.pm line 187. The warning is not necessary, this patch removes it. To test: - try to trigger warning - apply patch - verify that warning no longer occurs - prove t/db_dependent/Auth.t - verifiy that SCO still behaves like before (especially if you break out from sco path) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62270|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62325&action=edit Bug 18443: Get rid of warning 'uninitialized value $user' in C4/Auth.pm When logging out from OPAC, plack-error.log log and/or opac-error.log complain about 'uninitialized value $user' in C4/Auth.pm line 187. The warning is not necessary, this patch removes it. To test: - try to trigger warning - apply patch - verify that warning no longer occurs - prove t/db_dependent/Auth.t - verifiy that SCO still behaves like before (especially if you break out from sco path) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org