[Bug 33935] New: installer list deleted files which stops the process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Bug ID: 33935 Summary: installer list deleted files which stops the process Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: blocker Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com account_credit_types.sql and account_debit_types.sql have been moved to yml files but there are still references to them in C4::Installer. If you select the files during the installer process it will explode with Something went wrong loading file /usr/share/koha/intranet/cgi-bin/installer/data/mysql/mandatory/account_credit_types.sql (Couldn't read '/usr/share/koha/intranet/cgi-bin/installer/data/mysql/mandatory/account_credit_types.sql' : No such file or directory at /usr/share/perl5/DBIx/RunSQL.pm line 180. ) at /usr/share/koha/lib/C4/Installer.pm line 587. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403 [Bug 26403] Move debit and credit types to YAML files and fix other related translation issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152082&action=edit Bug 33935: (bug 26403 follow-up) Remove occurrences to deleted files account_credit_types.sql and account_debit_types.sql have been moved to yml files but there are still references to them in C4::Installer. If you select the files during the installer process it will explode with Test plan: DROP database koha_kohadev CREATE database koha_kohadev restart_all then install Koha using the UI Select all the sample data files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I can't recreate the issue using KTD - nothing explodes after selecting all the sample data and clicking import. (How I reset the database in KTD https://gitlab.com/-/snippets/1893788#start-the-web-installer) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Indeed wrong description it actually does not explode, but there is the error in the plack-intranet-error.log file [WARN] Something went wrong loading file /kohadevbox/koha/installer/data/mysql/mandatory/account_credit_types.sql (Couldn't read '/kohadevbox/koha/installer/data/mysql/mandatory/account_credit_types.sql' : No such file or directory at /usr/share/perl5/DBIx/RunSQL.pm line 180. ) at /kohadevbox/koha/C4/Installer.pm line 588. [WARN] Something went wrong loading file /kohadevbox/koha/installer/data/mysql/mandatory/account_debit_types.sql (Couldn't read '/kohadevbox/koha/installer/data/mysql/mandatory/account_debit_types.sql' : No such file or directory at /usr/share/perl5/DBIx/RunSQL.pm line 180. ) at /kohadevbox/koha/C4/Installer.pm line 588. lowering severity -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152082|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152099&action=edit Bug 33935: (bug 26403 follow-up) Remove occurrences to deleted files account_credit_types.sql and account_debit_types.sql have been moved to yml files but there are still references to them in C4::Installer. If you select the files during the installer process it will explode with Test plan: DROP database koha_kohadev CREATE database koha_kohadev restart_all then install Koha using the UI Select all the sample data files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the quick follow-up here Jonathan.. annoyed I missed this one :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|installer list deleted |Installer list deleted |files which stops the |files which shows warning |process |in the logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #3)
Indeed wrong description it actually does not explode, but there is the error in the plack-intranet-error.log file
Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.01 released in| | CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.07 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33935 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org