[Bug 33902] New: On opac-detail.tt the libraryInfoModal is outside of HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Bug ID: 33902 Summary: On opac-detail.tt the libraryInfoModal is outside of HTML tags Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If you go to OPAC detail and look for the #libraryInfoModal you'll notice it is outside of the <html> tag. Run the HTML through a validator and it will come back with an error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 152017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152017&action=edit Bug 33902: Move modal inside HTML body To test: -Go Administration > Libraries and add a URL for a branch. -Also add some OPAC info: ( via HTML Customizations ) -Now find a record belonging to that branch and bring up the OPAC detail page. -In the holdings table there should be a link under the 'Current library' column. -Clicking it should bring up a modal. -Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works. Nothing about the appearance or behavior of the page should change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 [Bug 33897] Use template wrapper for tabs: OPAC bibliographic detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152017|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 152022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152022&action=edit Bug 33902: Move modal inside HTML body To test: -Go Administration > Libraries and add a URL for a branch. -Also add some OPAC info: ( via HTML Customizations ) -Now find a record belonging to that branch and bring up the OPAC detail page. -In the holdings table there should be a link under the 'Current library' column. -Clicking it should bring up a modal. -Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works. Nothing about the appearance or behavior of the page should change. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This moves the HTML for the release notes| |pop-up window with the | |information for a library | |(where it exists) on the | |OPAC detail page inside the | |<html> tag so that it | |validates correctly. There | |is no change to the | |appearance or behavior of | |the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152022|0 |1 is obsolete| | --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 152031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152031&action=edit Bug 33902: Move modal inside HTML body To test: -Go Administration > Libraries and add a URL for a branch. -Also add some OPAC info: ( via HTML Customizations ) -Now find a record belonging to that branch and bring up the OPAC detail page. -In the holdings table there should be a link under the 'Current library' column. -Clicking it should bring up a modal. -Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works. Nothing about the appearance or behavior of the page should change. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |BLOCKED --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The dependency is not PQA. Can someone check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Depends on|33897 | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #4)
The dependency is not PQA. Can someone check?
I am removing the dependency. Neither of these patch sets conflict with one another. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 [Bug 33897] Use template wrapper for tabs: OPAC bibliographic detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org