https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20139 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@joensuu.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen@joensuu.fi> --- Created attachment 71241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71241&action=edit Bug 20139: Improve MARC mapping translatable strings - Allow translating one error message - Use string formatting with placeholders instead of concatenation Test plan: 1) Go to Home -> Administration -> Koha to MARC Mapping 2) Click on the "Add" button to add a new mapping 3) Note the popup text looks correct 4) Enter something invalid 5) Note the error message 6) Click on any of the "Remove" buttons to remove a mapping 7) Note the popup text looks correct 8) Update, translate the new msgid's, and install a language 9) Repeat 1-7, note how the message are in the correct language -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20139 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71241|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 72276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72276&action=edit Bug 20139: Improve MARC mapping translatable strings - Allow translating one error message - Use string formatting with placeholders instead of concatenation Test plan: 1) Go to Home -> Administration -> Koha to MARC Mapping 2) Click on the "Add" button to add a new mapping 3) Note the popup text looks correct 4) Enter something invalid 5) Note the error message 6) Click on any of the "Remove" buttons to remove a mapping 7) Note the popup text looks correct 8) Update, translate the new msgid's, and install a language 9) Repeat 1-7, note how the message are in the correct language Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20139 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.