[Bug 12662] New: Ajax-based check in does not work for some system preference settings enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Bug ID: 12662 Summary: Ajax-based check in does not work for some system preference settings enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: abl@biblos.pk.edu.pl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To reproduce: - enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference, - for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs, - observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 --- Comment #1 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 30077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30077&action=edit Bug 12662 - Ajax-based check in does not work for some system preference settings enabled To reproduce: - enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference, - for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs, - observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed. To test: - follow the steps above to reproduce this bug - apply patch - redo the test; ensure that this issue is no longer reproductible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |abl@biblos.pk.edu.pl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11703 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30077|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30079&action=edit Bug 12662 - Ajax-based check in does not work for some system preference settings enabled To reproduce: - enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference, - for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs, - observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed. To test: - follow the steps above to reproduce this bug - apply patch - redo the test; ensure that this issue is no longer reproductible. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30080&action=edit Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled ModItem is needed too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Before your patch, I got [Fri Jul 25 12:41:22 2014] checkin: Undefined subroutine &main::GetItem called at /home/koha/src/svc/checkin line 58. And after: [Fri Jul 25 12:42:09 2014] checkin: Undefined subroutine &main::ModItem called at /home/koha/src/svc/checkin line 68. :) But after yours and mine, only warnings... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30079|0 |1 is obsolete| | Attachment #30080|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30105&action=edit [PASSED QA] Bug 12662 - Ajax-based check in does not work for some system preference settings enabled To reproduce: - enable "InProcessingToShelvingCart" or "ReturnToShelvingCart" system preference, - for a sample patron with 1+ checkouts, try to check in some item[s] using checkboxes in the "Check in" column in the checkouts table which is displayed in the "Check out" or "Details" patron account tabs, - observe that clicking "Renew or return checked items" button only results in ajax "spinning wheel" stuck in infinite loop; check-in operation is not performed. To test: - follow the steps above to reproduce this bug - apply patch - redo the test; ensure that this issue is no longer reproductible. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30106&action=edit [PASSED QA] Bug 12662: (follow-up) Ajax-based check in does not work for some system preference settings enabled ModItem is needed too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jacek" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12662 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.3. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org