[Bug 7462] New: duplicate patron shows flags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Bug #: 7462 Summary: duplicate patron shows flags Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: nengard@gmail.com QAContact: koha.sekjal@gmail.com CC: gmcharlt@gmail.com When you duplicate a patron record the duplicate has the patron flags showing. The patron flags should only show when editing a patron not when adding a new patron. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29753&action=edit Bug 7462 - duplicate patron shows flags When duplicating a patron the form fields for setting patron account flags and restrictions should be hidden as it is when adding a patron. This patch adds the correct logic to the template. To test, duplicate an existing patron: - Confirm that the "Patron account flags" and "Patron restrictions" sections are not visible. - Confirm that saving a duplicated patron works correctly. - Confirm that the edit and new patron entry forms are unaffected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29753|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30154&action=edit [SIGNED-OFF] Bug 7462 - duplicate patron shows flags When duplicating a patron the form fields for setting patron account flags and restrictions should be hidden as it is when adding a patron. This patch adds the correct logic to the template. To test, duplicate an existing patron: - Confirm that the "Patron account flags" and "Patron restrictions" sections are not visible. - Confirm that saving a duplicated patron works correctly. - Confirm that the edit and new patron entry forms are unaffected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works ok, all three points confirmed No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30154|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30162&action=edit [PASSED QA] Bug 7462 - duplicate patron shows flags When duplicating a patron the form fields for setting patron account flags and restrictions should be hidden as it is when adding a patron. This patch adds the correct logic to the template. To test, duplicate an existing patron: - Confirm that the "Patron account flags" and "Patron restrictions" sections are not visible. - Confirm that saving a duplicated patron works correctly. - Confirm that the edit and new patron entry forms are unaffected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works ok, all three points confirmed No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, small template change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.3. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org