[Bug 42003] New: Upgrade DataTables from 2.3.4 to 2.3.7 (and FixedHeader to 4.0.6)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Bug ID: 42003 Summary: Upgrade DataTables from 2.3.4 to 2.3.7 (and FixedHeader to 4.0.6) Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 40816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 [Bug 40816] Upgrade DataTables from 2.1.8 to 2.3.4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194520&action=edit Bug 42003: DT - Update css and js files to 2.3.7 Patch from commit 217f4ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194521&action=edit Bug 42003: Remove !important from css files Patch from commit cbc8a74 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 37024 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Found a bug here in the filters: https://snipboard.io/p0ijCg.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194520|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 194558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194558&action=edit Bug 42003: DT - Update css and js files to 2.3.7 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194521|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 194559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194559&action=edit Bug 42003: Remove !important from css files Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- This certainly solves the scrolling bug in Chromium and Firefox for me. I'm not sure how to replicate the filter bug, or what it is exactly. Not sure what other things to test, should tests identify any issues? Testing notes (using KTD): 1. Observe the scrolling bug, as described in bug 37024): - Administration > Basic parameters > Libraries - Administration > Patrons and circulation > Patron categories - Administration > Patrons and circulation > Circulation and fine rules - Administration > Cataloging > Marc bibliographic frameworks > [pick any framework, such as BKS] > MARC structure > [change show 20 entries, to show all entries] 2. Apply the patches. 3. Rebuild things: yarn build 4. Restart everything: restart_all 5. Clear your browser cache 6. Repeat step 1, no scrolling jittering when you scroll slowly down the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement upgrades release notes| |the DataTables JavaScript | |library from version 2.3.4 | |to 2.3.7. | | | |This brings in upstream | |fixes and improvements | |released since 2.3.4, | |especially version 4.0.6 of | |the FixedHeader plugin, | |which fixes a scrolling | |glitch with sticky headers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #4)
Found a bug here in the filters: https://snipboard.io/p0ijCg.jpg
What's the bug? I'm taking a look at main and I think I might see it: https://snipboard.io/B3EXMv.jpg Is it that the filter info gets split into multiple lines? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #8)
(In reply to Jonathan Druart from comment #4)
Found a bug here in the filters: https://snipboard.io/p0ijCg.jpg
What's the bug?
I'm taking a look at main and I think I might see it: https://snipboard.io/B3EXMv.jpg
Is it that the filter info gets split into multiple lines?
Oops. It looks like that bug is from bug 40816... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #9)
(In reply to David Cook from comment #8)
(In reply to Jonathan Druart from comment #4)
Found a bug here in the filters: https://snipboard.io/p0ijCg.jpg
What's the bug?
I'm taking a look at main and I think I might see it: https://snipboard.io/B3EXMv.jpg
Is it that the filter info gets split into multiple lines?
Oops. It looks like that bug is from bug 40816...
I've added some potential fixes for it on bug 40816 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38185 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38185 [Bug 38185] DT - replace dom with layout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194558|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194559|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 198096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198096&action=edit Bug 42003: DT - Update css and js files to 2.3.7 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 198097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198097&action=edit Bug 42003: Remove !important from css files Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- Woohoo! Really excited to have this fixed! It was driving me crazy yesterday haha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 --- Comment #15 from Michael Adamyk <michael.adamyk@bywatersolutions.com> --- Any chance this could get backported? It would be great to have it fixed even sooner! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #16 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #17 from David Nind <david@davidnind.com> --- Underlying library update, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Bug 42003 depends on bug 40816, which changed state. Bug 40816 Summary: Upgrade DataTables from 2.1.8 to 2.3.4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Unsponsored Initiative type|--- |Epic Strategic theme|--- |Developer Experience Target Milestone|--- |26.05 CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org