[Bug 42886] New: CSS files not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Bug ID: 42886 Summary: CSS files not installed Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com Depends on: 42850 Target Milestone: --- Follow-up of bug 42850, where I found that we have more than the ILL css files that are not installed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 [Bug 42850] ILL requests stylesheet is not installed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200706&action=edit Bug 42886: Add xt test to prevent future omission of css files in Makefile Note that t/Makefile.t and xt/check_makefile.t were doing the same test. Merging them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200707&action=edit Bug 42886: Add bookings.css and edifact_interchange.css Caught by the xt test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200708&action=edit Bug 42886: Add missing rtl Patch from commit 3df2273 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200706|0 |1 is obsolete| | Attachment #200707|0 |1 is obsolete| | Attachment #200708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 200874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200874&action=edit Bug 42886: Add xt test to prevent future omission of css files in Makefile Note that t/Makefile.t and xt/check_makefile.t were doing the same test. Merging them. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 200875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200875&action=edit Bug 42886: Add bookings.css and edifact_interchange.css Caught by the xt test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 200876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200876&action=edit Bug 42886: Add missing rtl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Not sure exactly how to test or what to look for. How I tested (using KTD): 1. Current tests pass: prove t/Makefile.t 2. Applied the dependent patches, and for this bug, the first patch with the new tests - the tests should fail: prove xt/check_makefile.t 3. Apply the remaining patches for this bug. 4. Run the tests again, they should now pass: prove xt/check_makefile.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200874|0 |1 is obsolete| | Attachment #200875|0 |1 is obsolete| | Attachment #200876|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #11 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40040 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #13 from David Cook <dcook@prosentient.com.au> --- I wonder how bug 40040 got pushed when the rtl files must've been missing in 25.11 and 25.05... so confusing... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate, | |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- Thanks for this, Jonathan. Much appreciated. I just upgraded an Arabic library to 25.11 and I see the Arabic interface is totally broken in the staff interface without these patches. I'll be doing a rapid backport and encouraging RMaints for 25.11 and 25.05 to get on this ASAP... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40383 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 [Bug 40383] Modernise the EDIFACT Message display modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- Ok... bug 42850 is relevant for 25.11 and 25.05 because it depends on bug 30200 which applies to 25.11 and 25.05 But bug 40383 only applies to 26.11 and 26.05, so we're going to need revised patches for 25.11 and 25.05... I'm backporting locally for 25.11 so I should have more info on that shortly... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to stable |Pushed to oldstable Version(s)|26.11.00,26.05.03 |26.11.00,26.05.03,25.11.08 released in| | --- Comment #16 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #17 from Mason James <mtj@kohaaloha.com> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #16)
Pushed into 25.11.x for 25.11.08 nice work everyone
hi Baptiste the reference to the following 2 files in Makefile.PL breaks the package build, as the two files do not exist in 25.22.x branch edifact_interchange.css edifact_interchange-rtl.css 682 $file_map->{'koha-tmpl/intranet-tmpl/prog/css/edifact_interchange.css'} = 683 'blib/INTRANET_TMPL_DIR/prog/css/edifact_interchange.css'; 684 $file_map->{'koha-tmpl/intranet-tmpl/prog/css/edifact_interchange-rtl.css'} = 685 'blib/INTRANET_TMPL_DIR/prog/css/edifact_interchange-rtl.css'; ...removing these lines in Makefile.PL should fix the build again :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #18 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- I'm unsure how to backport this to 25.05 (In reply to David Cook from comment #15)
Ok... bug 42850 is relevant for 25.11 and 25.05 because it depends on bug 30200 which applies to 25.11 and 25.05
But bug 40383 only applies to 26.11 and 26.05, so we're going to need revised patches for 25.11 and 25.05...
I'm backporting locally for 25.11 so I should have more info on that shortly...
I can backport 42850 But I can't backport 40383 because of dependencies not in 25.05 - not sure how this bug (42886) made it into 25.11 since 40383 is not in it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #19 from David Cook <dcook@prosentient.com.au> --- (In reply to Wainui Witika-Park from comment #18)
I'm unsure how to backport this to 25.05 (In reply to David Cook from comment #15)
Ok... bug 42850 is relevant for 25.11 and 25.05 because it depends on bug 30200 which applies to 25.11 and 25.05
But bug 40383 only applies to 26.11 and 26.05, so we're going to need revised patches for 25.11 and 25.05...
I'm backporting locally for 25.11 so I should have more info on that shortly...
I can backport 42850
But I can't backport 40383 because of dependencies not in 25.05 - not sure how this bug (42886) made it into 25.11 since 40383 is not in it
The more I try to understand the more my brain hurts these days... For the backport here... I think you apply these 3 patches and then do something like this: commit 3fb1fd2c5f57edf4e07e456ceeacb01fdf618cc8 Author: David Cook <dcook@prosentient.com.au> Date: Thu Aug 20 03:13:49 2026 +0000 [25.11] Remove edifact_interchange*.css because it is from bug 40383 which isn't relevant for 25.11 diff --git a/Makefile.PL b/Makefile.PL index da3b2d6b0a7..a3c5b27c48a 100755 --- a/Makefile.PL +++ b/Makefile.PL @@ -681,10 +681,6 @@ $file_map->{'koha-tmpl/intranet-tmpl/prog/css/bookings.css'} = 'blib/INTRANE $file_map->{'koha-tmpl/intranet-tmpl/prog/css/bookings-rtl.css'} = 'blib/INTRANET_TMPL_DIR/prog/css/bookings-rtl.css'; $file_map->{'koha-tmpl/intranet-tmpl/prog/css/calendar.css'} = 'blib/INTRANET_TMPL_DIR/prog/css/calendar.css'; $file_map->{'koha-tmpl/intranet-tmpl/prog/css/calendar-rtl.css'} = 'blib/INTRANET_TMPL_DIR/prog/css/calendar-rtl.css'; -$file_map->{'koha-tmpl/intranet-tmpl/prog/css/edifact_interchange.css'} = - 'blib/INTRANET_TMPL_DIR/prog/css/edifact_interchange.css'; -$file_map->{'koha-tmpl/intranet-tmpl/prog/css/edifact_interchange-rtl.css'} = - 'blib/INTRANET_TMPL_DIR/prog/css/edifact_interchange-rtl.css'; $file_map->{'koha-tmpl/intranet-tmpl/prog/css/holds.css'} = 'blib/INTRANET_TMPL_DIR/prog/css/holds.css'; $file_map->{'koha-tmpl/intranet-tmpl/prog/css/holds-rtl.css'} = 'blib/INTRANET_TMPL_DIR/prog/css/holds-rtl.css'; $file_map->{'koha-tmpl/intranet-tmpl/prog/css/ill-requests.css'} = 'blib/INTRANET_TMPL_DIR/prog/css/ill-requests.css'; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #20 from David Cook <dcook@prosentient.com.au> --- Don't ask why I didn't just attach the patch... I don't know why copy pasting just seemed easier... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org