[Bug 42886] New: CSS files not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Bug ID: 42886 Summary: CSS files not installed Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com Depends on: 42850 Target Milestone: --- Follow-up of bug 42850, where I found that we have more than the ILL css files that are not installed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 [Bug 42850] ILL requests stylesheet is not installed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200706&action=edit Bug 42886: Add xt test to prevent future omission of css files in Makefile Note that t/Makefile.t and xt/check_makefile.t were doing the same test. Merging them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200707&action=edit Bug 42886: Add bookings.css and edifact_interchange.css Caught by the xt test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200708&action=edit Bug 42886: Add missing rtl Patch from commit 3df2273 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200706|0 |1 is obsolete| | Attachment #200707|0 |1 is obsolete| | Attachment #200708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 200874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200874&action=edit Bug 42886: Add xt test to prevent future omission of css files in Makefile Note that t/Makefile.t and xt/check_makefile.t were doing the same test. Merging them. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 200875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200875&action=edit Bug 42886: Add bookings.css and edifact_interchange.css Caught by the xt test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 200876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200876&action=edit Bug 42886: Add missing rtl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Not sure exactly how to test or what to look for. How I tested (using KTD): 1. Current tests pass: prove t/Makefile.t 2. Applied the dependent patches, and for this bug, the first patch with the new tests - the tests should fail: prove xt/check_makefile.t 3. Apply the remaining patches for this bug. 4. Run the tests again, they should now pass: prove xt/check_makefile.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200874|0 |1 is obsolete| | Attachment #200875|0 |1 is obsolete| | Attachment #200876|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org