[Bug 13157] New: improving facet definitions for unimarc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Bug ID: 13157 Summary: improving facet definitions for unimarc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: mathsabypro@gmail.com QA Contact: testopia@bugs.koha-community.org The new code for facets calculation could probably be more precise for unimarc (in biblio-koha-indexdefs.xml) - for series, 410 tag is probably better than 225 - the date and place subdivisions 6XX$y and 6XX$z could be indexed (in su-geo and su-chrono) - the subdivisionn $x is indexed for 606, but all 6XX$x could also be indexed (in su-to) - 5XX are not subjects, so I'm not sure that indexing them in su-ut is good (but we should check in ccl.properties how this index is defined). Anyway, I always found that indexing 5XX was a weird idea... and there is maybe a mistake for 995$b - holdingbranch (should be 995$c) M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33132&action=edit Bug 13157 UNIMARC holdingbranch facet is 995$c not 995$b Fix a typo. Not test plan required, just a look at default UNIMARC framework. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 --- Comment #2 from mathieu saby <mathsabypro@gmail.com> --- Hello A change is also needed in biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xml Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33132|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33135&action=edit Bug 13157 UNIMARC holdingbranch facet is 995$c not 995$b Fix a typo. Not test plan required, just a look at default UNIMARC framework. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |tomascohen@gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|improving facet definitions |Fix holdingbranch facet for |for unimarc |UNIMARC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m, | |jonathan.druart@biblibre.co | |m, katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could soomeone give this a sign-off please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I was about to sign it off, but comparing to the current frameworks I wasn't sure: ('995', 'a', 'Fournisseur', '', 0, 0, 'items.booksellerid', -1, '', '', '', 0, 0, '', NULL, '', ''), ('995', 'b', 'Site Propriétaire', '', 0, 1, 'items.homebranch', 10, 'branches',... ('995', 'c', 'Site Dépositaire', '', 0, 1, 'items.holdingbranch', 10, 'branches',... So maybe a followup is needed too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33135|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 33825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33825&action=edit [SIGNED OFF] Bug 13157: UNIMARC holdingbranch facet is 995$c not 995$b Fix a typo. Not test plan required, just a look at default UNIMARC framework. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 33826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33826&action=edit [SIGNED OFF] Bug 13157: (QA followup) homebranch is 995$b on UNIMARC frameworks Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please feel free to obsolete my followup if you think it is wrong. But in that case please check installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql and fill a new bug for it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Tomás Cohen Arazi from comment #8)
Please feel free to obsolete my followup if you think it is wrong. But in that case please check
installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/ framework_DEFAULT.sql
and fill a new bug for it.
No, your followup is correct! and required. Mine was incomplete. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33825|0 |1 is obsolete| | Attachment #33826|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33878&action=edit [PASSED QA] Bug 13157: UNIMARC holdingbranch facet is 995$c not 995$b Fix a typo. Not test plan required, just a look at default UNIMARC framework. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33879&action=edit [PASSED QA] Bug 13157: (QA followup) homebranch is 995$b on UNIMARC frameworks Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org