[Bug 23286] New: Improve style of hold confirmation modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Bug ID: 23286 Summary: Improve style of hold confirmation modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Created attachment 91432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91432&action=edit Screenshot of the proposed interface update I propose that we update the style of the hold confirmation modal which is shown when the user checks in an item on hold. I think we can make it a little more readable. See attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91856&action=edit Bug 23286: Improve style of hold confirmation modal This patch makes minor changes to the hold confirmation modal in the check-in template and adds some additional style. The goal is to make the information a little more readable. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Check in items with the following hold statuses: - On hold for a patron at your library - On hold for a patron at another library - On hold and already marked 'Waiting' Confirm that the hold confirmation modal is clear and well-styled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23399 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 [Bug 23399] Reindent returns.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91856|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 91908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91908&action=edit Bug 23286: Improve style of hold confirmation modal This patch makes minor changes to the hold confirmation modal in the check-in template and adds some additional style. The goal is to make the information a little more readable. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Check in items with the following hold statuses: - On hold for a patron at your library - On hold for a patron at another library - On hold and already marked 'Waiting' Confirm that the hold confirmation modal is clear and well-styled. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91908|0 |1 is obsolete| | --- Comment #3 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 91935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91935&action=edit Bug 23286: Improve style of hold confirmation modal This patch makes minor changes to the hold confirmation modal in the check-in template and adds some additional style. The goal is to make the information a little more readable. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Check in items with the following hold statuses: - On hold for a patron at your library - On hold for a patron at another library - On hold and already marked 'Waiting' Confirm that the hold confirmation modal is clear and well-styled. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91935|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92069&action=edit Bug 23286: Improve style of hold confirmation modal This patch makes minor changes to the hold confirmation modal in the check-in template and adds some additional style. The goal is to make the information a little more readable. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Check in items with the following hold statuses: - On hold for a patron at your library - On hold for a patron at another library - On hold and already marked 'Waiting' Confirm that the hold confirmation modal is clear and well-styled. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is a nice improvement, no breakage found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23286 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org