[Bug 23339] New: Reindent addbooks.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Bug ID: 23339 Summary: Reindent addbooks.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I would like to reindent cataloging/addbooks.tt: Remove tabs, correct indentation, add some comments to clarify the structure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91594&action=edit Bug 23339: Reindent addbooks.tt This patch reindents cataloguing/addbooks.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but you should look into your own heart for the right solution. Go to Cataloging. Test that the initial page and search results view look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91595&action=edit Bug 23339: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91594|0 |1 is obsolete| | --- Comment #3 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91669&action=edit Bug 23339: Reindent addbooks.tt This patch reindents cataloguing/addbooks.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but you should look into your own heart for the right solution. Go to Cataloging. Test that the initial page and search results view look correct and work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91595|0 |1 is obsolete| | --- Comment #4 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91670&action=edit Bug 23339: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91669|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91867&action=edit Bug 23339: Reindent addbooks.tt This patch reindents cataloguing/addbooks.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but you should look into your own heart for the right solution. Go to Cataloging. Test that the initial page and search results view look correct and work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91670|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91868&action=edit Bug 23339: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91867|0 |1 is obsolete| | Attachment #91868|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92013&action=edit Bug 23339: Reindent addbooks.tt This patch reindents cataloguing/addbooks.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but you should look into your own heart for the right solution. Go to Cataloging. Test that the initial page and search results view look correct and work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92014&action=edit Bug 23339: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x (Does not apply on 19.05.x) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org