https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148026&action=edit Bug 33186: Use template wrapper for tabs on search history and advanced search This patch updates the search history and advanced search templates in the staff interface so that they use the new WRAPPER directive for building tabs. The patch also makes a minor change to CSS in order to accommodate the different markup. To test, apply the patch and rebuild the staff interface CSS. - Go to the catalog's advanced search page. You should see tabs for each of the selections defined in the AdvancedSearchTypes system preference. - The tabs should look correct and work correctly. - If necessary, enable the EnableSearchHistory system preference. - Click the logged-in user name in the header menu and choose "Search history." - On this page you should see two tabs, catalog and authority. Both tabs should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148026|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 148127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148127&action=edit Bug 33186: Use template wrapper for tabs on search history and advanced search This patch updates the search history and advanced search templates in the staff interface so that they use the new WRAPPER directive for building tabs. The patch also makes a minor change to CSS in order to accommodate the different markup. To test, apply the patch and rebuild the staff interface CSS. - Go to the catalog's advanced search page. You should see tabs for each of the selections defined in the AdvancedSearchTypes system preference. - The tabs should look correct and work correctly. - If necessary, enable the EnableSearchHistory system preference. - Click the logged-in user name in the header menu and choose "Search history." - On this page you should see two tabs, catalog and authority. Both tabs should look correct and work correctly. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 --- Comment #5 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35372 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372 [Bug 35372] Support for empty AdvancedSearchTypes -- You are receiving this mail because: You are watching all bug changes.