[Bug 33181] New: Use template wrapper for tabs on record merge pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Bug ID: 33181 Summary: Use template wrapper for tabs on record merge pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, the biblio and authority merge pages should be updated to use the new WRAPPER for tabs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148016&action=edit Bug 33181: Use template wrapper for tabs on record merge pages This patch updates the include file which is used by both the bibliographic and authority recrd merge pages. The markup is updated to use the new tab WRAPPER directives. To test, apply the patch and perform a catalog search which will return more than one record. - Select two or more records and choose "Merge records" from the edit menu at the top of the search results. - On the following page you should see one tab for each record you selected from the search results. - Clicking each tab should show you the correct bibliographic details. Perform the same tests from the authority search results page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Owen, can this one be rebased? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148016|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148488&action=edit Bug 33181: Use template wrapper for tabs on record merge pages This patch updates the include file which is used by both the bibliographic and authority recrd merge pages. The markup is updated to use the new tab WRAPPER directives. To test, apply the patch and perform a catalog search which will return more than one record. - Select two or more records and choose "Merge records" from the edit menu at the top of the search results. - On the following page you should see one tab for each record you selected from the search results. - Clicking each tab should show you the correct bibliographic details. Perform the same tests from the authority search results page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 [Bug 33278] Correct JS for activating default tab on various pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148488|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 148912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148912&action=edit Bug 33181: Use template wrapper for tabs on record merge pages This patch updates the include file which is used by both the bibliographic and authority recrd merge pages. The markup is updated to use the new tab WRAPPER directives. To test, apply the patch and perform a catalog search which will return more than one record. - Select two or more records and choose "Merge records" from the edit menu at the top of the search results. - On the following page you should see one tab for each record you selected from the search results. - Clicking each tab should show you the correct bibliographic details. Perform the same tests from the authority search results page. Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148912|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149324&action=edit Bug 33181: Use template wrapper for tabs on record merge pages This patch updates the include file which is used by both the bibliographic and authority recrd merge pages. The markup is updated to use the new tab WRAPPER directives. To test, apply the patch and perform a catalog search which will return more than one record. - Select two or more records and choose "Merge records" from the edit menu at the top of the search results. - On the following page you should see one tab for each record you selected from the search results. - Clicking each tab should show you the correct bibliographic details. Perform the same tests from the authority search results page. Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Bug 33181 depends on bug 33278, which changed state. Bug 33278 Summary: Correct JS for activating default tab on various pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Bug 33181 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Bug 33181 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org