[Bug 11721] New: Use new DataTables include in suggestions template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11721 Bug ID: 11721 Summary: Use new DataTables include in suggestions template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/suggestion/suggestion.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The suggestions template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11721 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11721 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25152&action=edit Bug 11721 - Use new DataTables include in suggestions template This patch modifies the template for the suggestions page to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Sorting is now configured to exclude articles when sorting the title column. To test, apply the patch and view the suggestions page (Acquisitions -> Suggestions). Sorting of suggestions should work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11721 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11721 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25152|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25153&action=edit Bug 11721 - Use new DataTables include in suggestions template This patch modifies the template for the suggestions page to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Sorting is now configured to exclude articles when sorting the title column. To test, apply the patch and view the suggestions page (Acquisitions -> Suggestions). Sorting of suggestions should work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11721 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Funds and Status column are not sortable before and after the patch - it would be nice if they would be. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11721 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11721 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25153|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 25157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25157&action=edit [PASSED QA] Bug 11721 - Use new DataTables include in suggestions template This patch modifies the template for the suggestions page to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Sorting is now configured to exclude articles when sorting the title column. To test, apply the patch and view the suggestions page (Acquisitions -> Suggestions). Sorting of suggestions should work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Note: the columsn fund and status are not sortable/searchable before and after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11721 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11721 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org