[Bug 29111] New: Unused code to handle indicators in many item modification scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Bug ID: 29111 Summary: Unused code to handle indicators in many item modification scripts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@iki.fi QA Contact: testopia@bugs.koha-community.org At a quick glance it looks like Koha doesn't support placing indicators to the item field (952) but we have code for doing that in the .pl scripts, for example in: tools/batchMod.pl cataloguing/additem.pl acqui/addorderiso2709.pl Please search for "indicator" and "ind_tag" in these files to locate the unused code. For cataloguing/additem.pl it is clear the code is unused because it is hard coded in the .tt (template toolkit) file that the indicator values are always " " / empty. This code should be removed so we are not unnecessarily spending time doing modifications relating to this part of code to keep it "working" (bug 28832...). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |joonas.kylmala@iki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Unused code to handle |Remove dead code from |indicators in many item |intranet |modification scripts | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #1 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125311&action=edit Bug 29111: Remove dead code from acqui/addorderiso2709.pl Test plan: 1) open acqui/addorderiso2709.pl in your code editor and make sure nothing references $item in the if block where it was removed from -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #2 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125312&action=edit Bug 29111: Remove unused indicator modification code for items The indicator value for 952 was hard coded in every case to " ". In order to achieve that we can simply pass undef to TransformHtmlToXml() and it will set the indicator values to " ". To test: 1) Make sure the submission of (at least some) the modified files still work, e.g. test that making a new item via cataloguing/additem.pl works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125313&action=edit Bug 29111: Remove unused function from cataloguing/additem.pl To test: 1) Open cataloguing/additem.pl and search for any usages of find_value, you should find 0 usages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #4 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- There was some additional dead code around the indicator values so those are removed here as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125311|0 |1 is obsolete| | Attachment #125312|0 |1 is obsolete| | Attachment #125313|0 |1 is obsolete| | --- Comment #5 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 125601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125601&action=edit Bug 29111: Remove dead code from acqui/addorderiso2709.pl Test plan: 1) open acqui/addorderiso2709.pl in your code editor and make sure nothing references $item in the if block where it was removed from Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #6 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 125602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125602&action=edit Bug 29111: Remove unused indicator modification code for items The indicator value for 952 was hard coded in every case to " ". In order to achieve that we can simply pass undef to TransformHtmlToXml() and it will set the indicator values to " ". To test: 1) Make sure the submission of (at least some) the modified files still work, e.g. test that making a new item via cataloguing/additem.pl works. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #7 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 125603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125603&action=edit Bug 29111: Remove unused function from cataloguing/additem.pl To test: 1) Open cataloguing/additem.pl and search for any usages of find_value, you should find 0 usages. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've also tested the ordering, receiving, adding and batch modifying items in cataloguing and adding items from the serial module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125601|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125652&action=edit Bug 29111: Remove dead code from acqui/addorderiso2709.pl Test plan: 1) open acqui/addorderiso2709.pl in your code editor and make sure nothing references $item in the if block where it was removed from Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125602|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125653&action=edit Bug 29111: Remove unused indicator modification code for items The indicator value for 952 was hard coded in every case to " ". In order to achieve that we can simply pass undef to TransformHtmlToXml() and it will set the indicator values to " ". To test: 1) Make sure the submission of (at least some) the modified files still work, e.g. test that making a new item via cataloguing/additem.pl works. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125603|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125654&action=edit Bug 29111: Remove unused function from cataloguing/additem.pl To test: 1) Open cataloguing/additem.pl and search for any usages of find_value, you should find 0 usages. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Attachment #125654|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Comment on attachment 125654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125654 Bug 29111: Remove unused function from cataloguing/additem.pl Done on bug 27526 (Adjust code to use Koha::Items), obsoleting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27526 Status|Passed QA |Patch doesn't apply --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Does not apply on top of bug 27526. At first glance I'd say that the changes to additem are no longer valid (I cleaned them already). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Bug 29111 depends on bug 27526, which changed state. Bug 27526 Summary: Remove Mod/AddItemFromMarc from additem.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125652|0 |1 is obsolete| | Attachment #125653|0 |1 is obsolete| | --- Comment #14 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125996&action=edit Bug 29111: Remove dead code from acqui/addorderiso2709.pl Test plan: 1) open acqui/addorderiso2709.pl in your code editor and make sure nothing references $item in the if block where it was removed from Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #15 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125997&action=edit Bug 29111: Remove unused indicator modification code for items The indicator value for 952 was hard coded in every case to " ". In order to achieve that we can simply pass undef to TransformHtmlToXml() and it will set the indicator values to " ". To test: 1) Make sure the submission of (at least some) the modified files still work, e.g. test that making a new item via cataloguing/additem.pl works. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #16 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to Jonathan Druart from comment #13)
Does not apply on top of bug 27526. At first glance I'd say that the changes to additem are no longer valid (I cleaned them already).
Rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29111 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org