[Bug 28978] New: Convert installer CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 Bug ID: 28978 Summary: Convert installer CSS to SCSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 28376 Adding Flatpickr to the onboarding templates will be much simpler if the installer CSS file is generated from SCSS. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 [Bug 28376] Replace obsolete jquery-ui-timepicker-addon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124665&action=edit Bug 28978: Convert installer CSS to SCSS This patch creates a new SCSS file, installer.scss, from which installer.css will be compiled. Most of the resulting CSS is unchanged, but some minor sections were removed because they were obsolete. The jQueryUI-specific section isn't fully converted to SCSS because it's going to go away with the addition of Flatpickr. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Confirm that koha-tmpl/intranet-tmpl/prog/css/installer.css is updated. - Go through the complete web installation process, including onboarding, to confirm that everything is styled as before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 [Bug 28982] Use Flatpickr on onboarding pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124665|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125502&action=edit Bug 28978: Convert installer CSS to SCSS This patch creates a new SCSS file, installer.scss, from which installer.css will be compiled. Most of the resulting CSS is unchanged, but some minor sections were removed because they were obsolete. The jQueryUI-specific section isn't fully converted to SCSS because it's going to go away with the addition of Flatpickr. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Confirm that koha-tmpl/intranet-tmpl/prog/css/installer.css is updated. - Go through the complete web installation process, including onboarding, to confirm that everything is styled as before. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All looking good to me.. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125502|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125657&action=edit Bug 28978: Convert installer CSS to SCSS This patch creates a new SCSS file, installer.scss, from which installer.css will be compiled. Most of the resulting CSS is unchanged, but some minor sections were removed because they were obsolete. The jQueryUI-specific section isn't fully converted to SCSS because it's going to go away with the addition of Flatpickr. To test, apply the patch and rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Confirm that koha-tmpl/intranet-tmpl/prog/css/installer.css is updated. - Go through the complete web installation process, including onboarding, to confirm that everything is styled as before. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=28982 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org