[Bug 41061] New: No longer needed to validate dates manually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 Bug ID: 41061 Summary: No longer needed to validate dates manually Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 33703 I've tried to resurrect bug 31149 but finally realised that this code is no longer needed. I think it's coming from the introduction of Masikto by bug 33703. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 [Bug 33703] Entering dates should be more flexible accepting different entry formats -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188204&action=edit Bug 41061: Remove unused calendar JS functions Since the introduction of Maskito by bug 33703 we do no longer need to valid dates when the flatpickr widget is closed. This patch removes the following JS function from staff and OPAC: * is_valid_date * validate_date * get_dateformat_str Test plan: 0. Do not apply this patch and confirm that the date string received by those functions has already been correctly formatted 1. Apply the patch and git grep to make sure no occurrence exists in the code 2. Confirm that you are still able to select dates with flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No longer needed to |No longer need to validate |validate dates manually |dates manually -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188204|0 |1 is obsolete| | CC| |emmi.takkinen@koha-suomi.fi --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 190774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190774&action=edit Bug 41061: Remove unused calendar JS functions Since the introduction of Maskito by bug 33703 we do no longer need to valid dates when the flatpickr widget is closed. This patch removes the following JS function from staff and OPAC: * is_valid_date * validate_date * get_dateformat_str Test plan: 0. Do not apply this patch and confirm that the date string received by those functions has already been correctly formatted 1. Apply the patch and git grep to make sure no occurrence exists in the code 2. Confirm that you are still able to select dates with flatpickr Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Tested with couple pages (e.g patron add/modify form, search orders form), dates were formatted correctly before send to the obsolete functions and adding date worked after applying patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200000&action=edit Bug 41061: Remove unused calendar JS functions Since the introduction of Maskito by bug 33703 we do no longer need to valid dates when the flatpickr widget is closed. This patch removes the following JS function from staff and OPAC: * is_valid_date * validate_date * get_dateformat_str Test plan: 0. Do not apply this patch and confirm that the date string received by those functions has already been correctly formatted 1. Apply the patch and git grep to make sure no occurrence exists in the code 2. Confirm that you are still able to select dates with flatpickr Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not impact olstable 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org