[Bug 41105] New: Add Gender option in Batch patron modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 Bug ID: 41105 Summary: Add Gender option in Batch patron modification Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: amitddng135@gmail.com QA Contact: testopia@bugs.koha-community.org Add a gender option in Batch patron modification -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |amitddng135@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 Enica Davis <enica@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |enica@bywatersolutions.com --- Comment #1 from Enica Davis <enica@bywatersolutions.com> --- +1 While we don't see this field getting used often, there are libraries that are looking to batch edit this field. Most are looking to clear anything in the field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Sponsorship status|--- |Sponsored Assignee|amitddng135@gmail.com |olivia.reynolds@openfifth.c | |o.uk Comma delimited| |Open Fifth list of Sponsors| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 --- Comment #2 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 200181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200181&action=edit Bug 41105: Add gender to batch patron modification This patch adds the ability to batch-edit the gender field for patrons. Test plan: 1. Ensure there are a number of patrons in the database. 2. Apply patch. 3. Navigate to Patrons and click Search, to display a list of patrons. 4. Select all results and click "Batch patron modification". 5. Verify the "Gender" column is displayed. 6. Verify the "Gender" column may be toggled under the "Columns" dropdown. 7. Select a subset of the patrons for modification. 8. Verify there is a "Gender" option beneath the table. 9. Select "Female" as the gender, and click "Save". 10. Verify the gender of all selected patrons was set to "Female". 11. Repeat with "Male" and "Other" as the gender. 12. Repeat with clearing the gender field by ticking the checkbox next to the dropdown and saving. Verify the gender field is blank for each selected patron. Sponsored-by: Open Fifth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 201304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201304&action=edit Bug 41105: Add gender to batch patron modification This patch adds the ability to batch-edit the gender field for patrons. Test plan: 1. Ensure there are a number of patrons in the database. 2. Apply patch. 3. Navigate to Patrons and click Search, to display a list of patrons. 4. Select all results and click "Batch patron modification". 5. Verify the "Gender" column is displayed. 6. Verify the "Gender" column may be toggled under the "Columns" dropdown. 7. Select a subset of the patrons for modification. 8. Verify there is a "Gender" option beneath the table. 9. Select "Female" as the gender, and click "Save". 10. Verify the gender of all selected patrons was set to "Female". 11. Repeat with "Male" and "Other" as the gender. 12. Repeat with clearing the gender field by ticking the checkbox next to the dropdown and saving. Verify the gender field is blank for each selected patron. Sponsored-by: Open Fifth Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201304|0 |1 is obsolete| | --- Comment #4 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 201307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201307&action=edit Bug 41105: Add gender to batch patron modification Test plan: 1. Ensure there are a number of patrons in the database. 2. Apply patch. 3. Navigate to Patrons and click Search, to display a list of patrons. 4. Select all results and click "Batch patron modification". 5. Verify the "Gender" column is displayed. 6. Verify the "Gender" column may be toggled under the "Columns" dropdown. 7. Select a subset of the patrons for modification. 8. Verify there is a "Gender" option beneath the table. 9. Select "Female" as the gender, and click "Save". 10. Verify the gender of all selected patrons was set to "Female". 11. Repeat with "Male" and "Other" as the gender. 12. Repeat with clearing the gender field by ticking the checkbox next to the dropdown and saving. Verify the gender field is blank for each selected patron. Work as suggested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |amitddng135@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201363&action=edit Bug 41105: Add gender to batch patron modification This patch adds the ability to batch-edit the gender field for patrons. Test plan: 1. Ensure there are a number of patrons in the database. 2. Apply patch. 3. Navigate to Patrons and click Search, to display a list of patrons. 4. Select all results and click "Batch patron modification". 5. Verify the "Gender" column is displayed. 6. Verify the "Gender" column may be toggled under the "Columns" dropdown. 7. Select a subset of the patrons for modification. 8. Verify there is a "Gender" option beneath the table. 9. Select "Female" as the gender, and click "Save". 10. Verify the gender of all selected patrons was set to "Female". 11. Repeat with "Male" and "Other" as the gender. 12. Repeat with clearing the gender field by ticking the checkbox next to the dropdown and saving. Verify the gender field is blank for each selected patron. Sponsored-by: Open Fifth Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.ai> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201364&action=edit Bug 41105: (QA follow-up) Fix gender label translation The batch patron modification "Gender" column and edit dropdown hardcoded "Female"/"Male"/"Other" as data passed from tools/modborrowers.pl, and the "Other" gender label was displayed as plain text. Values coming from Perl as template data are never picked up by the PO extractor, so the gender select options in the edit form could never be translated. Elsewhere in Koha (moremember.tt, moremember-brief.tt, memberentrygen.tt, opac-memberentry.tt) the "Other" gender label is wrapped with tp('gender', 'Other') to give translators context, since "Other" is ambiguous out of context. This makes the "Gender" dropdown options translatable directly from the template, and aligns "Other" with the existing tp('gender', ...) convention used everywhere else gender is displayed. Test plan: 1. Navigate to Patrons and click Search, to display a list of patrons. 2. Select all results and click "Batch patron modification". 3. Verify the "Gender" column and "Gender" edit dropdown still work as expected. 4. Confirm (e.g. via the .pot file or misc/translator/translate) that "Female", "Male" and the "Other" (gender) msgctxt string are now extracted for translation from this template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201365&action=edit Bug 41105: (QA follow-up) DRY out gender label rendering The gender-code-to-label mapping (F/M/O -> Female/Male/Other) was duplicated between the results table cell and the edit-form select options in modborrowers.tt. Extract it into a shared patron-sex-label.inc so there is a single place defining the mapping, and drop the now-unused "lib" values from the sex options in tools/modborrowers.pl (labels are supplied by the include, keyed on the option value, rather than by Perl). Test plan: 1. Navigate to Patrons and click Search, to display a list of patrons. 2. Select all results and click "Batch patron modification". 3. Verify the "Gender" column displays Female/Male/Other correctly. 4. Verify the "Gender" edit dropdown still offers Female/Male/Other and saves correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41105 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I thought I'd upgrade one of the signoffs here to a QA stamp.. but I also saw a few minor improvements we could make on top. Translation and then taking the opportunity to DRY out the code a tiny bit. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org