[Bug 18503] New: Confusing hold and transfer dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Bug ID: 18503 Summary: Confusing hold and transfer dialog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To produce the confusing dialog: 1) Place an item belonging to Library A on hold for Patron 1 for pickup at Library B. 2) Trigger hold. Item is now in transit to Library B. 3) Check in item at Library C (item ended up in their hands by mistake). 4) Note 4 buttons. Not clear what to do. Realistically, the hold should be the focus, and sent along with either of the two bottom buttons. The top buttons do not need to be there. Why transfer the item home when it will just continue to trigger the hold? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cbrannon@cdalibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 62990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62990&action=edit Bug 18503: Fixes confusing dialog and other minor This corrects the returns2 dialog logic, and cleans up a few pieces of code. Patch also updates some buttons and fixes check in layout. To Test: 1) Check out an item. 2) Check item in. Note old buttons (Submit next to barcode, Clear). Note message next to calendar is wrapping to next line. Note Clear button is next to the check box rather than next to the calendar. 3) Check in item at a different branch both with AllowReturnToBranch in all four settings and with AutomaticItemReturn set to Do and Don't. Note old style buttons on all dialogs. 4) Place a hold on an item for pickup at another library. 5) Trigger the hold and confirm. 6) Check in item at another library (not the pickup location). 7) Note the confusing transfer/hold buttons and message. 8) Apply patch 9) Repeat steps 1-8. Note changes to the items pointed out in those steps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 [Bug 18490] Transfer message confusing, cancel button missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Status|Needs Signoff |In Discussion --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Christopher When I apply this patch on a up to date clean branch I get the following error: Applying: Bug 18503: Fixes confusing dialog and other minor fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 18503: Fixes confusing dialog and other minor The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18503-Fixes-confusing-dialog-and-other-minor-JMU2nv.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Did you apply the(In reply to Alex Buckley from comment #2)
Hi Christopher
When I apply this patch on a up to date clean branch I get the following error:
Applying: Bug 18503: Fixes confusing dialog and other minor fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 18503: Fixes confusing dialog and other minor The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18503-Fixes-confusing-dialog-and-other-minor-JMU2nv.patch
Did you apply patch 18490? This patch depends on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Yup I applied bug 18490 first -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62990|0 |1 is obsolete| | --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 66494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66494&action=edit Bug 18503: Fixes confusing dialog and other minor This corrects the returns2 dialog logic, and cleans up a few pieces of code. Patch also updates some buttons and fixes check in layout. To Test: 1) Check out an item. 2) Check item in. Note old buttons (Submit next to barcode, Clear). Note message next to calendar is wrapping to next line. Note Clear button is next to the check box rather than next to the calendar. 3) Check in item at a different branch both with AllowReturnToBranch in all four settings and with AutomaticItemReturn set to Do and Don't. Note old style buttons on all dialogs. 4) Place a hold on an item for pickup at another library. 5) Trigger the hold and confirm. 6) Check in item at another library (not the pickup location). 7) Note the confusing transfer/hold buttons and message. 8) Apply patch 9) Repeat steps 1-8. Note changes to the items pointed out in those steps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- Rebased. Sorry for delay! Please try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- Confirm button doesn't trigger hold at remote library. Regression of a bug. Need to fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Christopher, you might have run into bug 19116 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Katrin Fischer from comment #8)
Hi Christopher, you might have run into bug 19116
I believe you are correct. I was thinking I might have broke something, but I do recall this bug coming up on one of our last upgrades, and someone fixed it (probably applied the patch). I have tested, and it is a pre-existing condition that this patch doesn't address, so we are good to go. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8451 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tried to apply the patch, and the system gave me an error fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- I see some things have changed since I have been able to work on this. I am going to rework the patch and some of the elements being addressed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Patch doesn't apply |RESOLVED --- Comment #12 from Christopher Brannon <cbrannon@cdalibrary.org> --- Looks like some things are already fixed, and some things are being addressed elsewhere. So I am closing this bug, and I am going to start a new bug to address some of the leftovers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 Bug 18503 depends on bug 18490, which changed state. Bug 18490 Summary: Transfer message confusing, cancel button missing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org