[Bug 18490] New: Transfer message confusing, cancel button missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Bug ID: 18490 Summary: Transfer message confusing, cancel button missing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When checking in an item that is being transferred to another branch (not for a reserve), the dialog is a bit confusing. It says: Please return item to: Library XYZ And then shows a Print slip button. I see two problems. First, checking in the item initiates the transfer, and this is not clear in the message. Second, you can't cancel the hold unless you check it in again, and then you get the Cancel transfer button. I don't think there is any reason not to show the cancel button the first time around. I also think it would be much clearer as to what is going on if the message read: Transferring item to: Library XYZ I am open to suggestions on the phrasing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |cbrannon@cdalibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 62649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62649&action=edit [Bug 18490] Change transfer message/show cancel This patch changes the transfer message and shows the cancel button on the first checkin. I've also cleaned up some formatting in the code. To test: Test A: 1) Check in an item at a library other than its homebranch. Test B: 2) Place an item on hold to be picked up at another library. 3) Check in the item at a library other than the home branch or pickup loccation. Test C: 4) Add item to a rotating collection. 5) Transfer collection to another library. 6) Check in the item to trigger the transfer. 7) On each test, notice the phrase "Please transfer item to:" and notice that the Cancel transfer button does not appear on the first checkin. 8) Apply patch. 9) Repeat steps 1-6. 10) On each test notice the phrase is now "Transferring item to:" and notice that the Cancel transfer button now shows after the first checkin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18503 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18503 [Bug 18503] Confusing hold and transfer dialog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Ryn <anoorazerin@unimas.my> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anoorazerin@unimas.my --- Comment #2 from Ryn <anoorazerin@unimas.my> --- Created attachment 64561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64561&action=edit Applied the patch but no changes We have tested the patch, doing all the Test Plan and repeat the Test Plan after applying the patch. We find out that there are no changes after patch is applied. We tested in Sandbox01, BibLibre UNIMARC on 23rd June 2017, 1000am Philippine Time. Attachment shows the dialog box after the patch is applied, there are no 'Cancel' button. So does on the other Test Plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr Status|Needs Signoff |Failed QA --- Comment #3 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- regarding comment 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- Patch works. Maybe sandbox testing issue. Test environment may need a restart? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 66967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66967&action=edit No Cancel button displayed Hi Christopher When I tested this patch I found that the 'Transferring item to:' text was displayed in Test A, B, and C however the 'Cancel' button is only being displayed in test C -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- OK so I have now got it displaying the 'cancel transfer' button, so the patch works as described in the test plan. However running the QA test it fails on valid_template, could you please fix this up Christopher and then I'll be happy to re-test and sign off on your patch FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21346 --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- I'm going to hold off on this until 21346 is pushed. Doesn't completely depend on it, but there are enough changes there that I would like to work from that point forward. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- Bug 21346 addresses and corrects this issue. *** This bug has been marked as a duplicate of bug 21346 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org