[Bug 33533] New: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Bug ID: 33533 Summary: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr In memberentrygen.tt, there is a condition to show either "Patron identity" or "Organization identity" in the patron form. These three words, "Patron", "Organization", and "identity" were separated in different spans. However, in French at least, we have to invert the order of the words otherwise it doesn't make sense. So "Patron identity" becomes "Identité de l'utilisateur" ("Identity of patron"). Right now, it is translated as "Utilisateur identité" which doesn't mean anything and looks like it was translated directly from English :) This whole condition should be kept together, with %s to separate the elements so that we can move them around. <legend id="identity_lgd">[% IF ( I ) %]<span>Organization</span> [% ELSE %]<span>Patron</span> [% END %]<span>identity</span></legend> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 149623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149623&action=edit Bug 33533: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt This patch corrects the HTML markup in order to reunite "Patron identity" or "Organization identity" for translatability. To test: 1. Apply patch 2. Update translation files ./misc/translator/translate update xx-XX 3. Check the xx-XX-staff-prog.po file, the line for memberentrygen.tt:275 should look like \#: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:275 \#, c-format msgid "Organization %sPatron %sidentity" msgstr "Identité de l'organisme %sIdentité de l'utilisateur %s" 4. Optionally, translate the string, install translation and check the page (Patrons > New patron), trying a institutional patron and a regular patron ./misc/translator/translate install xx-XX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149623|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149693&action=edit Bug 33533: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt This patch corrects the HTML markup in order to reunite "Patron identity" or "Organization identity" for translatability. To test: 1. Apply patch 2. Update translation files ./misc/translator/translate update xx-XX 3. Check the xx-XX-staff-prog.po file, the line for memberentrygen.tt:275 should look like \#: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:275 \#, c-format msgid "Organization %sPatron %sidentity" msgstr "Identité de l'organisme %sIdentité de l'utilisateur %s" 4. Optionally, translate the string, install translation and check the page (Patrons > New patron), trying a institutional patron and a regular patron ./misc/translator/translate install xx-XX Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for the patch Caroline - this one has been annoying me forever! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149693|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149712&action=edit Bug 33533: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt This patch corrects the HTML markup in order to reunite "Patron identity" or "Organization identity" for translatability. To test: 1. Apply patch 2. Update translation files ./misc/translator/translate update xx-XX 3. Check the xx-XX-staff-prog.po file, the line for memberentrygen.tt:275 should look like \#: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:275 \#, c-format msgid "Organization %sPatron %sidentity" msgstr "Identité de l'organisme %sIdentité de l'utilisateur %s" 4. Optionally, translate the string, install translation and check the page (Patrons > New patron), trying a institutional patron and a regular patron ./misc/translator/translate install xx-XX Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 --- Comment #6 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org