https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557 Bug 16557 depends on bug 16553, which changed state. Bug 16553 Summary: Incorrect path to jQueryUI file in help template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51626|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <c.gravely@arts.ac.uk> --- Created attachment 51989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51989&action=edit Bug 16557 - Remove the use of "onclick" from several include files This patch modifies several include files, removing "onclick" attributes in favor of defining events in JavaScript. A reusable "toggle" function has been added to the global JS file so that clicking elements with the class "toggle_element" will toggle the display of elements as defined in the click target's "data-element" attribute. Also changed: In subtypes_unimarc.inc some capitalization errors have been fixed and label/id pairs corrected. To test, apply the patch and clear your browser cache if necessary. - On the Acquisitions home page, click the "Orders search" header search tab. Clicking the [+] link should expand and collapse the additional search fields. - On the checkout or patron detail page, view the "Restrictions" tab. Click to add a restriction and use the datepicker to select a date. Clicking the "Clear date" link should clear the date. - Trigger the help window on any page. Clicking the "close window" button should work correctly. - Go to Administration -> Patron categories -> Edit. Checking and unchecking messaging preference options should work correctly. The "do not notify" checkbox should clear other checkboxes in that row and vice versa. - In Serials, from a subscription detail page, clicking the "Renew" button should trigger the renew popup. - Go to Acquisitions -> Vendor -> Add to basket -> From a subscription. Clicking the "Advanced search" link in the left hand sidebar should toggle the sidebar search form. - In a UNIMARC system, view the advanced search page. Clicking the "Show coded information filters" link should show additional search fields. (I tested in my MARC21 system by temporarily moving line 174 of advsearch.tt to line 172). Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51989|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52648&action=edit Bug 16557 - Remove the use of "onclick" from several include files This patch modifies several include files, removing "onclick" attributes in favor of defining events in JavaScript. A reusable "toggle" function has been added to the global JS file so that clicking elements with the class "toggle_element" will toggle the display of elements as defined in the click target's "data-element" attribute. Also changed: In subtypes_unimarc.inc some capitalization errors have been fixed and label/id pairs corrected. To test, apply the patch and clear your browser cache if necessary. - On the Acquisitions home page, click the "Orders search" header search tab. Clicking the [+] link should expand and collapse the additional search fields. - On the checkout or patron detail page, view the "Restrictions" tab. Click to add a restriction and use the datepicker to select a date. Clicking the "Clear date" link should clear the date. - Trigger the help window on any page. Clicking the "close window" button should work correctly. - Go to Administration -> Patron categories -> Edit. Checking and unchecking messaging preference options should work correctly. The "do not notify" checkbox should clear other checkboxes in that row and vice versa. - In Serials, from a subscription detail page, clicking the "Renew" button should trigger the renew popup. - Go to Acquisitions -> Vendor -> Add to basket -> From a subscription. Clicking the "Advanced search" link in the left hand sidebar should toggle the sidebar search form. - In a UNIMARC system, view the advanced search page. Clicking the "Show coded information filters" link should show additional search fields. (I tested in my MARC21 system by temporarily moving line 174 of advsearch.tt to line 172). Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16557 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.