[Bug 16602] New: Remove the use of "onclick" from several templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 Bug ID: 16602 Summary: Remove the use of "onclick" from several templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I am working on a patch which will remove the use of "onclick" from the following templates: offline_circ/process_koc.tt patron_lists/lists.tt tools/batchMod-edit.tt tools/batchMod-del.tt tools/holidays.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51845&action=edit Bug 16602 - Remove the use of "onclick" from several templates This patch removes the use of "onclick" from several templates, instead defining click events in JavaScript. Also changed: Some markup corrections. To test, apply the patch and: - Go to Circulation -> Upload offline circulation file - Browse for an offline circulation file. - Clicking the 'Upload file' button should work correctly. - After uploading a file, both the 'Add to offline circulation queue' and 'Apply directly' buttons should work to trigger their corresponding processes (keeping Bug 16603 in mind). - Go to Patrons -> Patron lists. - For any patron list containing patrons, click the 'Print patron cards' menu item. This should trigger a modal window which exports the correct list. - Go to Tools -> Batch item modification. - Submit a batch of items for modification. - Clicking the 'Save' button should trigger the background job and the items should be successfully modified. - Go to Tools -> Batch item deletion. - Submit a batch of items for deletion. - Clicking the 'Delete' button should trigger the background job and the items should be successfully deleted. - Go to Tools -> Calendar. - Trigger the 'Add new holiday' panel by clicking a day on the calendar which has no holiday defined. - Clicking the 'Cancel' link should hide the panel. - Trigger the 'Edit this holiday' panel by clicking a day which has a holiday defined. - Clicking the 'Cancel' link should hide the panel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51845|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 51893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51893&action=edit Bug 16602 - Remove the use of "onclick" from several templates This patch removes the use of "onclick" from several templates, instead defining click events in JavaScript. Also changed: Some markup corrections. To test, apply the patch and: - Go to Circulation -> Upload offline circulation file - Browse for an offline circulation file. - Clicking the 'Upload file' button should work correctly. - After uploading a file, both the 'Add to offline circulation queue' and 'Apply directly' buttons should work to trigger their corresponding processes (keeping Bug 16603 in mind). - Go to Patrons -> Patron lists. - For any patron list containing patrons, click the 'Print patron cards' menu item. This should trigger a modal window which exports the correct list. - Go to Tools -> Batch item modification. - Submit a batch of items for modification. - Clicking the 'Save' button should trigger the background job and the items should be successfully modified. - Go to Tools -> Batch item deletion. - Submit a batch of items for deletion. - Clicking the 'Delete' button should trigger the background job and the items should be successfully deleted. - Go to Tools -> Calendar. - Trigger the 'Add new holiday' panel by clicking a day on the calendar which has no holiday defined. - Clicking the 'Cancel' link should hide the panel. - Trigger the 'Edit this holiday' panel by clicking a day which has a holiday defined. - Clicking the 'Cancel' link should hide the panel. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Everything works as previously. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16778 [Bug 16778] Use Bootstrap modal for card printing on patron lists page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51893|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52645&action=edit Bug 16602 - Remove the use of "onclick" from several templates This patch removes the use of "onclick" from several templates, instead defining click events in JavaScript. Also changed: Some markup corrections. To test, apply the patch and: - Go to Circulation -> Upload offline circulation file - Browse for an offline circulation file. - Clicking the 'Upload file' button should work correctly. - After uploading a file, both the 'Add to offline circulation queue' and 'Apply directly' buttons should work to trigger their corresponding processes (keeping Bug 16603 in mind). - Go to Patrons -> Patron lists. - For any patron list containing patrons, click the 'Print patron cards' menu item. This should trigger a modal window which exports the correct list. - Go to Tools -> Batch item modification. - Submit a batch of items for modification. - Clicking the 'Save' button should trigger the background job and the items should be successfully modified. - Go to Tools -> Batch item deletion. - Submit a batch of items for deletion. - Clicking the 'Delete' button should trigger the background job and the items should be successfully deleted. - Go to Tools -> Calendar. - Trigger the 'Add new holiday' panel by clicking a day on the calendar which has no holiday defined. - Clicking the 'Cancel' link should hide the panel. - Trigger the 'Edit this holiday' panel by clicking a day which has a holiday defined. - Clicking the 'Cancel' link should hide the panel. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Everything works as previously. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16602 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org