https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42097 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42097 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195346&action=edit Bug 42097: Add link to create new club from list of club templates This patch adds a "New club" button to the list of club templates. This makes it easy to create a new club using any of the templates in the list. To test, apply the patch and go to Tools -> Patron clubs. - Create a club template if necessary. - On the patron clubs main page, in the list of club templates, there should be an "Actions" menu in the last table cell. - Now alongside "Edit" and "Delete" you should see "New club" - Choosing "New club" should take you to the new club form with the heading "Create a new [you template name] club" - The permissions around the "Edit" and "Delete" controls haven't changed, but the "New club" control depends on the user having CAN_user_clubs_edit_clubs permission. - Test as a user without CAN_user_clubs_edit_clubs permission to confirm that the "New club" control is omitted. - Test as a user with only CAN_user_clubs_edit_clubs permission to confirm that the edit and delete buttons are missing. - Test as a user with only CAN_user_clubs_enroll permission. There should be no actions column in the table of club templates. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42097 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement changes release notes| |the actions for patron club | |templates (Tools > Patrons | |> Patron clubs > Club | |templates) so that: | |- there is a new action to | |create club directly from | |the club templates actions | |(New club) | |- the actions are now in a | |dropdown list (the same as | |the clubs section) | | | |This makes it easy to | |create a new club directly | |from the list of templates. Status|Needs Signoff |Signed Off --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Go to Tools > Patrons > Patron clubs > New club template 2. Permissions: - I used Henry Acevedo: . changed username and password so you can log in as Henry - Added these permissions: . Staff access, allows viewing of catalogue in staff interface (catalogue) . Patron clubs (clubs) ==> Can add, edit, and delete clubs like a superlibrarian - Changed the club permissions to work through the combination of options in the test plan: . Create and edit clubs (edit_clubs) (CAN_user_clubs_edit_clubs) . Create and edit club templates (edit_templates) . Enroll patrons in clubs (enroll) (CAN_user_clubs_enroll) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42097 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42097 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi all, not a blocker but in the club templates loop the dropdown id uses c.id instead of t.id (template_actions_[% c.id | html %], also in aria-labelledby), so every row renders id="template_actions_". Nothing breaks since the dropdown doesn't rely on the id, but could you add a quick follow-up switching it to t.id? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42097 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42097 --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- (In reply to Owen Leonard from comment #7)

Created attachment 207823 [details] [review] Bug 42097: (QA follow-up) Correct template variable name in dropdown

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Follow-up pushed. Thanks! -- You are receiving this mail because: You are watching all bug changes.