https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42667 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42667 [Bug 42667] Split the ability to edit other librarian's reports into a separate permission -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199597&action=edit Bug 42108: Add new column saved_sql.run_type Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #3 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199599&action=edit Bug 42108: Implement use of run_type Adds a "Run type" pulldown to the reports editor. If the report specifies foreground or background, it skip the intermediate step where the user would normally pick between foreground and background and just run it using the given type. Export and svc/report still pass a run_type of foreground, so running a background-only report through those endpoints gives an error ( on purpose ). The ability to run background reports for svc/report will be addressed in a future bug report. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Browse to reports/guided_reports.pl, create a report Set the new report to "background only" 5) Run the report 6) Note it is run immediately as a background job without the intermediary step of selecting the run type 7) Edit the report, set it to foreground only 8) Run the repot 9) Note it again skips the middle step, but this time runs as if foreground were selected 10) Set to "both", not you again have both choices as before this patch set! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42596 [Bug 42596] Add ability for reports APIs ( svc/report, opac/svc/report ) to run reports as background jobs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|42643 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42643 [Bug 42643] [OMNIBUS] Assorted performance and stability work -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 203118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203118&action=edit Bug 42108: Add new column saved_sql.run_type Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 203120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203120&action=edit Bug 42108: Implement use of run_type Adds a "Run type" pulldown to the reports editor. If the report specifies foreground or background, it skip the intermediate step where the user would normally pick between foreground and background and just run it using the given type. Export and svc/report still pass a run_type of foreground, so running a background-only report through those endpoints gives an error ( on purpose ). The ability to run background reports for svc/report will be addressed in a future bug report. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Browse to reports/guided_reports.pl, create a report Set the new report to "background only" 5) Run the report 6) Note it is run immediately as a background job without the intermediary step of selecting the run type 7) Edit the report, set it to foreground only 8) Run the repot 9) Note it again skips the middle step, but this time runs as if foreground were selected 10) Set to "both", not you again have both choices as before this patch set! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 203122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203122&action=edit Bug 42108: (follow-up) Tidy Patch from commit 436b4ec -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zoho.roboto@bywatersolution | |s.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207497&action=edit Bug 42108: Add new column saved_sql.run_type Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207499&action=edit Bug 42108: Implement use of run_type Adds a "Run type" pulldown to the reports editor. If the report specifies foreground or background, it skip the intermediate step where the user would normally pick between foreground and background and just run it using the given type. Export and svc/report still pass a run_type of foreground, so running a background-only report through those endpoints gives an error ( on purpose ). The ability to run background reports for svc/report will be addressed in a future bug report. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Browse to reports/guided_reports.pl, create a report Set the new report to "background only" 5) Run the report 6) Note it is run immediately as a background job without the intermediary step of selecting the run type 7) Edit the report, set it to foreground only 8) Run the repot 9) Note it again skips the middle step, but this time runs as if foreground were selected 10) Set to "both", not you again have both choices as before this patch set! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207501&action=edit Bug 42108: (follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |laurence.rault@biblibre.com --- Comment #18 from Laurence Rault <laurence.rault@biblibre.com> --- Does not apply because depends on Bug 41921 that can not apply Patch application failed for attachment 206914 - Bug 41921: Add ability to run reports as background jobs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #19 from David Nind <david@davidnind.com> --- Bug 41921 now applies cleanly. These patches no longer apply: Patch application failed for attachment 207499 - Bug 42108: Implement use of run_type -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207913&action=edit Bug 42108: Add new column saved_sql.run_type Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207915&action=edit Bug 42108: Implement use of run_type Adds a "Run type" pulldown to the reports editor. If the report specifies foreground or background, it skip the intermediate step where the user would normally pick between foreground and background and just run it using the given type. Export and svc/report still pass a run_type of foreground, so running a background-only report through those endpoints gives an error ( on purpose ). The ability to run background reports for svc/report will be addressed in a future bug report. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Browse to reports/guided_reports.pl, create a report Set the new report to "background only" 5) Run the report 6) Note it is run immediately as a background job without the intermediary step of selecting the run type 7) Edit the report, set it to foreground only 8) Run the repot 9) Note it again skips the middle step, but this time runs as if foreground were selected 10) Set to "both", not you again have both choices as before this patch set! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207917&action=edit Bug 42108: (follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- The report edit screen does not consistently display the actual selected value for Run Type. To recreate: - create a new report, set Run Type to Both, save - your page reloads on save and correctly shows "Both" - Edit your report, set Run Type to Foreground only, save - your page reloads on save and incorrectly still shows "Both" - without saving or changing anything, click back to your list of saved reports, then edit your report, confirm page loads showing the correct value of "Foreground only" - set Run Type to "Background only" and save, confirm on reload the page again incorrectly shows "Both" Additionally, I don't love how this interacts with the ReportsRunInBackground syspref. - set ReportsRunInBackground to "always run in foreground" - create a new report, set Run Type to "Background only," save - attempt to run your report, get a permissions error I'd argue the syspref should take precedence over the value in the report. If the syspref is not set to "Let the user choose" then the Run Type option should be hidden (and ignored in previously set on extant reports). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #27 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 208073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208073&action=edit Bug 42108: (QA follow-up) Let ReportsRunInBackground take precedence over a report's run type Patch from commit f2e4694 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43823 [Bug 43823] Show report Run Type in more places -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #28 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208172&action=edit Bug 42108: Add new column saved_sql.run_type Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mary Teal <mteal@greenvillelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #30 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208174&action=edit Bug 42108: Implement use of run_type Adds a "Run type" pulldown to the reports editor. If the report specifies foreground or background, it skip the intermediate step where the user would normally pick between foreground and background and just run it using the given type. Export and svc/report still pass a run_type of foreground, so running a background-only report through those endpoints gives an error ( on purpose ). The ability to run background reports for svc/report will be addressed in a future bug report. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Browse to reports/guided_reports.pl, create a report Set the new report to "background only" 5) Run the report 6) Note it is run immediately as a background job without the intermediary step of selecting the run type 7) Edit the report, set it to foreground only 8) Run the repot 9) Note it again skips the middle step, but this time runs as if foreground were selected 10) Set to "both", not you again have both choices as before this patch set! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mary Teal <mteal@greenvillelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #32 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208176&action=edit Bug 42108: (follow-up) Tidy Signed-off-by: Mary Teal <mteal@greenvillelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #34 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208178&action=edit Bug 42108: (QA follow-up) Let ReportsRunInBackground take precedence over a report's run type Signed-off-by: Mary Teal <mteal@greenvillelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows release notes| |individual reports to be | |set to always run in either | |the foreground or the | |background. This option is | |set when either creating or | |editing a report. The | |option is only available | |when the | |ReportsRunInBackground | |system preference is set to | |"let the user choose." If | |the system preference is | |set to force all reports | |into either the foreground | |or the background, the | |per-report option is hidden | |and overridden. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208172|0 |1 is obsolete| | Attachment #208173|0 |1 is obsolete| | Attachment #208174|0 |1 is obsolete| | Attachment #208175|0 |1 is obsolete| | Attachment #208176|0 |1 is obsolete| | Attachment #208177|0 |1 is obsolete| | Attachment #208178|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208708&action=edit Bug 42108: Enforce per-report run_type in prep_report Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mary Teal <mteal@greenvillelibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208710&action=edit Bug 42108: Update Schema files [DO NOT PUSH] Signed-off-by: Mary Teal <mteal@greenvillelibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208712&action=edit Bug 42108: (QA follow-up) Show the saved run type after saving a report Passes run_type back to the template after saving a new or edited report, the editor showed "Both" no matter what was saved. Signed-off-by: Mary Teal <mteal@greenvillelibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42108 --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 208714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208714&action=edit Bug 42108: (QA follow-up) Handle background-only reports in foreground callers and validate run_type prep_report now throws RunTypeNotAllowed for a background-only report requested in the foreground, but svc/report, opac/svc/report and the guided_reports.pl export op always request foreground and did not handle it, so they would fail with an unhandled exception. * Return a 403 (JSON error report_background_only) from svc/report and opac/svc/report, and insufficient_permission from the export op. * Whitelist the run_type CGI parameter in guided_reports.pl; an invalid value previously reached Koha::Object->store and died with BadValue. Invalid values are now ignored (default on create, unchanged on edit). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.