https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 [Bug 22605] Adding the option to modify/edit searches on the staff client -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30528 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133263&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133265&action=edit Bug 17170: Update schema for boolean -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133267&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133269&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Something off about how saved filters are getting parsed here. We're ANDing where we should OR. I created a filter limiting to item types Book (BK) and Music (MU). If I search for "Street" and then apply my filter, I get no results. 'street' with limit(s): '(itype:("BK")) AND (itype:("MU"))' If I clicked to edit my filter from the admin page and then search for "street" from that page, I get 4 results. 'street' with limit(s): 'itype:(("BK") OR ("MU"))' If I just construct an advanced search for "street" limited to book and music I get 4 results. '(street*)' with limit(s): 'itype:(("BK") OR ("MU"))'. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133376&action=edit Bug 17170: (follow-up) Correct handling of limits in ES This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure is more complex, so we handle the pieces individually Additionally I add more tests to cover other cases -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137028&action=edit Bug 17170: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137030&action=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137032&action=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137034&action=edit Bug 17170: Unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137036&action=edit Bug 17170: (follow-up) Correct handling of limits in ES This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure is more complex, so we handle the pieces individually Additionally I add more tests to cover other cases -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137028|0 |1 is obsolete| | --- Comment #24 from Michal Urban <michalurban177@gmail.com> --- Created attachment 137187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137187&action=edit Bug 17170: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137030|0 |1 is obsolete| | --- Comment #26 from Michal Urban <michalurban177@gmail.com> --- Created attachment 137189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137189&action=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137032|0 |1 is obsolete| | --- Comment #28 from Michal Urban <michalurban177@gmail.com> --- Created attachment 137191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137191&action=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137034|0 |1 is obsolete| | --- Comment #30 from Michal Urban <michalurban177@gmail.com> --- Created attachment 137193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137193&action=edit Bug 17170: Unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #32 from Michal Urban <michalurban177@gmail.com> --- Created attachment 137195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137195&action=edit Bug 17170: Add the ability to create 'saved searches' for use as filters when searching the catalog This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the results page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Signed-off-by: Michal Urban <michalurban177@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, this sounds really ineresting! Could you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17170: (follow-up) Correct handling of limits in ES error: sha1 information is lacking or useless (C4/Search.pm). error: could not build fake ancestor Patch failed at 0001 Bug 17170: (follow-up) Correct handling of limits in ES hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17170-follow-up-Correct-handling-of-limits-in--3qL2M9.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137036|0 |1 is obsolete| | Attachment #137186|0 |1 is obsolete| | Attachment #137187|0 |1 is obsolete| | Attachment #137188|0 |1 is obsolete| | Attachment #137189|0 |1 is obsolete| | Attachment #137190|0 |1 is obsolete| | Attachment #137191|0 |1 is obsolete| | Attachment #137192|0 |1 is obsolete| | Attachment #137193|0 |1 is obsolete| | Attachment #137194|0 |1 is obsolete| | Attachment #137195|0 |1 is obsolete| | --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137808&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137810&action=edit Bug 17170: Update schema for boolean -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137812&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137814&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137816&action=edit Bug 17170: (follow-up) Display search filters admin links when apprropriate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137808|0 |1 is obsolete| | Attachment #137809|0 |1 is obsolete| | Attachment #137810|0 |1 is obsolete| | Attachment #137811|0 |1 is obsolete| | Attachment #137812|0 |1 is obsolete| | Attachment #137813|0 |1 is obsolete| | Attachment #137814|0 |1 is obsolete| | Attachment #137815|0 |1 is obsolete| | Attachment #137816|0 |1 is obsolete| | Attachment #137817|0 |1 is obsolete| | --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 138505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138505&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #46 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 138507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138507&action=edit Bug 17170: Update schema for boolean -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #48 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 138509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138509&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 138511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138511&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #52 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 138513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138513&action=edit Bug 17170: (follow-up) Display search filters admin links when apprropriate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry for being too late again :( Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17170: DB Updates Applying: Bug 17170: DO NOT PUSH - Schema Updates Applying: Bug 17170: Update schema for boolean Applying: Bug 17170: Add API route for SearchFilters Applying: Bug 17170: Add search filters to staff and opac interfaces Applying: Bug 17170: Handle search filters in query builders error: sha1 information is lacking or useless (C4/Search.pm). error: could not build fake ancestor Patch failed at 0001 Bug 17170: Handle search filters in query builders -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138505|0 |1 is obsolete| | Attachment #138506|0 |1 is obsolete| | Attachment #138507|0 |1 is obsolete| | Attachment #138508|0 |1 is obsolete| | Attachment #138509|0 |1 is obsolete| | Attachment #138510|0 |1 is obsolete| | Attachment #138511|0 |1 is obsolete| | Attachment #138512|0 |1 is obsolete| | Attachment #138513|0 |1 is obsolete| | Attachment #138514|0 |1 is obsolete| | --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139948&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #57 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139950&action=edit Bug 17170: Update schema for boolean -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #59 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139952&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #61 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139954&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #63 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139956&action=edit Bug 17170: (follow-up) Display search filters admin links when apprropriate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #65 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry to repeat history here :( Too late again. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17170: DB Updates Applying: Bug 17170: DO NOT PUSH - Schema Updates Applying: Bug 17170: Update schema for boolean Applying: Bug 17170: Add API route for SearchFilters Applying: Bug 17170: Add search filters to staff and opac interfaces Applying: Bug 17170: Handle search filters in query builders Applying: Bug 17170: Add admin page for filters and ability to edit/save existing filters Applying: Bug 17170: Unit tests Applying: Bug 17170: (follow-up) Display search filters admin links when apprropriate error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc). error: could not build fake ancestor Patch failed at 0001 Bug 17170: (follow-up) Display search filters admin links when apprropriate hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17170-follow-up-Display-search-filters-admin-l-O7ZVwo.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139948|0 |1 is obsolete| | --- Comment #66 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141228&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139950|0 |1 is obsolete| | --- Comment #68 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141230&action=edit Bug 17170: Update schema for boolean -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139952|0 |1 is obsolete| | --- Comment #70 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141232&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139954|0 |1 is obsolete| | --- Comment #72 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141234&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139956|0 |1 is obsolete| | --- Comment #74 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141236&action=edit Bug 17170: (follow-up) Display search filters admin links when apprropriate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141228|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141316&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141230|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141318&action=edit Bug 17170: Update schema for boolean Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141232|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141320&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141234|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141322&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141236|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141324&action=edit Bug 17170: (follow-up) Display search filters admin links when apprropriate Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141326&action=edit Bug 17170: (QA follow-up) Remove re-introduced file We reintroduced the definitions api spec file with this patch.. it's not required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141328&action=edit Bug 17170: (QA follow-up) Improve model structure This feature is awesome, but it's modals all feel a bit off.. this is an improvement to one of them, but far from perfect. I opt to work with Owen to create a guideline (and template) for modals going forward and let this patchset go in as is. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #90 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nick, just to let you know: I am back, but Martin was faster! ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Change sponsored?|--- |Sponsored Text to go in the| |This patchset adds a new release notes| |feature, the ability to | |save searches on the staff | |client and display them in | |the results page alongside | |facets (staff client and/or | |OPAC) as a search filter | |that can be applied to | |search result set. | | | |The | |feature is enabled/disabled | |by new system preference: | |SavedSearchFilters | | | |New | |filters can be added from | |the results page after a | |search, and there is an | |admin page for updating | |deleting and renaming | |filters. | | | |There is a new | |permission, | |manage_search_filters, to | |control management of these | |filters. | | | |New filters can | |be added that are not | |displayed along with | |facets, this allows for | |building custom links using | |these filters to keep URLs | |shorter -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141317|0 |1 is obsolete| | --- Comment #92 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141349&action=edit Bug 17170: DO NOT PUSH - Schema Updates Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141319|0 |1 is obsolete| | --- Comment #94 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141351&action=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141321|0 |1 is obsolete| | --- Comment #96 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141353&action=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141323|0 |1 is obsolete| | --- Comment #98 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141355&action=edit Bug 17170: Unit tests Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141325|0 |1 is obsolete| | --- Comment #100 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141357&action=edit Bug 17170: Add the ability to create 'saved searches' for use as filters when searching the catalog This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the results page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Michal Urban <michalurban177@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141327|0 |1 is obsolete| | --- Comment #102 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141359&action=edit Bug 17170: (QA follow-up) Relocate 'Save' Another minor rebase issue I believe.. relocate the 'Save search as filter' link back up to sit next to 'Edit this search'. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141348|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141350|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141354|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141324|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141358|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141360|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #104 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141422&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #106 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141424&action=edit Bug 17170: Update schema for boolean Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #108 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141426&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #110 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141428&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #112 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141430&action=edit Bug 17170: (follow-up) Display search filters admin links when appropriate Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #114 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141432&action=edit Bug 17170: (QA follow-up) Remove re-introduced file We reintroduced the definitions api spec file with this patch.. it's not required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #116 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141434&action=edit Bug 17170: (QA follow-up) Improve model structure This feature is awesome, but it's modals all feel a bit off.. this is an improvement to one of them, but far from perfect. I opt to work with Owen to create a guideline (and template) for modals going forward and let this patchset go in as is. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #118 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141436&action=edit Bug 17170: (QA follow-up) DB changes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #120 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141438&action=edit Bug 17170: (QA follow-up) Escape things, make them translatable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #122 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141462&action=edit Bug 17170: (follow-up) Use x instead of X Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141423|0 |1 is obsolete| | --- Comment #124 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142367&action=edit Bug 17170: DBIC schema Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141425|0 |1 is obsolete| | --- Comment #126 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142369&action=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141427|0 |1 is obsolete| | --- Comment #128 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142371&action=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141429|0 |1 is obsolete| | --- Comment #130 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142373&action=edit Bug 17170: Unit tests Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141431|0 |1 is obsolete| | --- Comment #132 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142375&action=edit Bug 17170: Add the ability to create 'saved searches' for use as filters when searching the catalog This patch alters the code in the ES QueryBuilder. Reflecting how things are handled in build_query_compat we clean the query, but not the limits. In Zebra we simply recursivly call buildQuery, but the ES query structure This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the results page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page Sponsored-by: Sponsored by: Round Rock Public Library [https://www.roundrocktexas.gov/departments/library/] Signed-off-by: Michal Urban <michalurban177@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141433|0 |1 is obsolete| | --- Comment #134 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142377&action=edit Bug 17170: (QA follow-up) Relocate 'Save' Another minor rebase issue I believe.. relocate the 'Save search as filter' link back up to sit next to 'Edit this search'. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141435|0 |1 is obsolete| | --- Comment #136 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142379&action=edit Bug 17170: Minor fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141437|0 |1 is obsolete| | --- Comment #138 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142381&action=edit Bug 17170: (QA follow-up) Spec cleanup This patch removes not required (for now) query parameters as we can query using q= on those. They can be added back eventually, if needed. Attributes now match the database as well. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #140 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142383&action=edit Bug 17170: (follow-up) adjust tests for bug 25375 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #142 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142385&action=edit Bug 17170: (follow-up) Adjust for RM follow-ups Use direct DB names when saving/loading Don't escape boolean values as strings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #144 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Dropdown empty in modal: https://snipboard.io/Nnab3I.jpg -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #146 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- A filter that is not displayed at the OPAC can still be used if you modify the id in the URL. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #148 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #146)

A filter that is not displayed at the OPAC can still be used if you modify the id in the URL.

You could perform the search yourself anyways, I do not think it reveals any data -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #149 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 142494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142494&action=edit Bug 17170: (QA follow-up) Adjust t/Koha/Auth/Permissions.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26860 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9524 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33011 [Bug 33011] Capitalization: Show in Staff interface? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/667 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #151 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I added some stuff to the manual. Hopefully I didn't get it completely wrong. I admit I didn't quite understand the use case for the URL thing, so I didn't add that in. But if someone has a specific example, feel free to add it in, or tell me and I'll add it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #153 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #152)

(In reply to Caroline Cyr La Rose from comment #151)

...

I added some stuff to the manual. Hopefully I didn't get it completely wrong. I admit I didn't quite understand the use case for the URL thing, so I didn't add that in. But if someone has a specific example, feel free to add it in, or tell me and I'll add it.

Do you mean the part about keeping URLs shorter?

It's really just kind of a convenience, so you could create a 'New books search' and save it, but not select to display it as a filter, but then you could add a link: <a href="http://localhost:8080/cgi-bin/koha/opac-search.pl?limit=search_filter:1">New books</a> For a more complicated search, say "Picture books" / subject: Christmas / location: Children's room / Available Only It just provides a shorter more readable link -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #155 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #154)

Thank you Nick! That helps :) I will add that example.

I think maybe I misunderstood how to use the filters. Because in the OPAC, you need to do a search to get the filters, so in the test plan when it says to copy the URL, it's the URL for search + filter, not just filter. It gave me something like cgi-bin/koha/opac-search.pl?idx=&q=shakespeare&limit=search_filter:4

Anyway, now I have the URL you gave me, so it's all good. Ill put that in the manual with the new books example.

Yeah, it would be nice to provide the staff/opac link to the filter with no extra query in the filters list - you can file that and I'll try to get to it sometime -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33734 [Bug 33734] Using custom search filters breaks scandic characters in search term -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38294 [Bug 38294] Checkbox/label for search filters incorrectly aligned -- You are receiving this mail because: You are watching all bug changes.