[Bug 20352] New: Add ability of currency/price to have a symbol after amount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Bug ID: 20352 Summary: Add ability of currency/price to have a symbol after amount Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Add the ability to customize and display the symbol for a currency -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Bug 20352 depends on bug 4078, which changed state. Bug 4078 Summary: Add the ability to customize and display the symbol for a currency https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Doesn't that work already with the TT plugin now? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96410&action=edit Bug 20352: DB changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96411&action=edit Bug 20352: Schema changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
From https://www.gnu.org/software/libc/manual/html_node/Currency-Symbol.html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96412&action=edit Bug 20352: Add the ability to chose the position of the currency This patch mimicks what has been done for p_sep_by_space to add a space separation between the symbol and the value. Here we are adding p_cs_precedes to display the symbol before or after the value. Note that so far the symbol is only displayed in one place at the OPAC (opac-main) Test plan: - Create a manual invoice for a patron - Edit the active currency, select 'Before' (should be the default here) - Use the charged patron to login at the OPAC => On the mainpage you should see the charges displayed, with the symbol before the value - Edit the active currency, select 'After' => The symbol is now positionned after the value QA note: p_cs_precedes is only used for positive amount, n_cs_precedes should be used for negative. Here we are assuming that positive and negative amounts are displayed the same way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Just showing how easy it can be to make things configurable at currency level. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20353 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24454 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96410|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98234&action=edit Bug 20352: DB changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96411|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98235&action=edit Bug 20352: Schema changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
From https://www.gnu.org/software/libc/manual/html_node/Currency-Symbol.html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96412|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98236&action=edit Bug 20352: Add the ability to chose the position of the currency This patch mimicks what has been done for p_sep_by_space to add a space separation between the symbol and the value. Here we are adding p_cs_precedes to display the symbol before or after the value. Note that so far the symbol is only displayed in one place at the OPAC (opac-main) Test plan: - Create a manual invoice for a patron - Edit the active currency, select 'Before' (should be the default here) - Use the charged patron to login at the OPAC => On the mainpage you should see the charges displayed, with the symbol before the value - Edit the active currency, select 'After' => The symbol is now positionned after the value QA note: p_cs_precedes is only used for positive amount, n_cs_precedes should be used for negative. Here we are assuming that positive and negative amounts are displayed the same way. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works nicely, Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed, | |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Worth noting: having the formatting at currency level is not ideal actually. For instance we could have: * 1 234,56 € * €1.234,56 * 1.234,56 € * €1,234.56 * ... Letting QA decide if this can be considered as an improvement anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98234|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 103924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103924&action=edit Bug 20352: DB changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 103925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103925&action=edit Bug 20352: Schema changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
From https://www.gnu.org/software/libc/manual/html_node/Currency-Symbol.html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 103926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103926&action=edit Bug 20352: Add the ability to chose the position of the currency This patch mimicks what has been done for p_sep_by_space to add a space separation between the symbol and the value. Here we are adding p_cs_precedes to display the symbol before or after the value. Note that so far the symbol is only displayed in one place at the OPAC (opac-main) Test plan: - Create a manual invoice for a patron - Edit the active currency, select 'Before' (should be the default here) - Use the charged patron to login at the OPAC => On the mainpage you should see the charges displayed, with the symbol before the value - Edit the active currency, select 'After' => The symbol is now positionned after the value QA note: p_cs_precedes is only used for positive amount, n_cs_precedes should be used for negative. Here we are assuming that positive and negative amounts are displayed the same way. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 103927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103927&action=edit Bug 20352: Identify boolean columns Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #10)
Worth noting: having the formatting at currency level is not ideal actually. For instance we could have: * 1 234,56 € * €1.234,56 * 1.234,56 € * €1,234.56 * ...
Letting QA decide if this can be considered as an improvement anyway.
Works as advertised. I don't see why we wouldn't allow placing the currenc symbol after the amount. QA script happy as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- As I tried to explain in the example, for a given currency different displays are possible. The formatting should be done depending on client-side configuration instead (locales). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've been mulling this one over and I'm inclined to agree, that although this does move us towards the goal, it's at the wrong level. I believe we should be formatting based on locale rather than by currency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think for client-side formatting we should use the native JS function (Intl.NumberFormat): https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obj... For template side, we should try to replicate what the above does via a TT plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- https://www.thefinancials.com/Default.aspx?SubSectionID=curformat for reference... there's ALLOT of different formats out there it would seem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Final comment.. why do we use 3 hard coded values for our money formatting at the moment rather than rely on something like https://metacpan.org/pod/Locale::Currency::Format which claims to try to support the full ISO 4217 set? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #17)
I've been mulling this one over and I'm inclined to agree, that although this does move us towards the goal, it's at the wrong level.
I believe we should be formatting based on locale rather than by currency.
On the other hand it's either having it now (but not perfect), or not having it until... who knows? I am not planning to spend more time on this. (In reply to Martin Renvoize from comment #20)
Final comment.. why do we use 3 hard coded values for our money formatting at the moment rather than rely on something like https://metacpan.org/pod/Locale::Currency::Format which claims to try to support the full ISO 4217 set?
For backward compatibility when Koha::Number::Price has been implemented. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #20)
Final comment.. why do we use 3 hard coded values for our money formatting at the moment rather than rely on something like https://metacpan.org/pod/Locale::Currency::Format which claims to try to support the full ISO 4217 set?
Because it's buggy and the author is unresponsive. Bug 24278 - Replace Locale::Currency::Format because it's buggy As we support the Goethe libraries, we have run into quite some issues with different currencies. - Koha currently uses it to format fines in overdue notices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #22)
(In reply to Martin Renvoize from comment #20)
Final comment.. why do we use 3 hard coded values for our money formatting at the moment rather than rely on something like https://metacpan.org/pod/Locale::Currency::Format which claims to try to support the full ISO 4217 set?
Because it's buggy and the author is unresponsive. Bug 24278 - Replace Locale::Currency::Format because it's buggy
As we support the Goethe libraries, we have run into quite some issues with different currencies. - Koha currently uses it to format fines in overdue notices.
Hmm.. I wasn't aware it had issues. What about https://metacpan.org/pod/CLDR::Number::Format::Currency.? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|jonathan.druart@bugs.koha-c |koha-bugs@lists.koha-commun |ommunity.org |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed, | |rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24278 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24278 [Bug 24278] Replace Locale::Currency::Format because it's buggy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21507 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17138 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #24 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #23)
What about https://metacpan.org/pod/CLDR::Number::Format::Currency.?
Looks good at a glance although it has 21 current issues and it looks like it can be a bit opinionated. That it might do more than just format (e.g. rounding)? Might not be an issue though if we make sure it's already a valid money number... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #25 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #10)
Worth noting: having the formatting at currency level is not ideal actually. For instance we could have: * 1 234,56 € * €1.234,56 * 1.234,56 € * €1,234.56 * ...
Agreed. In many cases, I think it varies from country to country, but for Canada it actually varies by region, if I recall correctly. The synopsis for https://metacpan.org/pod/CLDR::Number::Format::Currency#SYNOPSIS actually illustrates this well for the Canadian example. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So, Locale::Currency::Format contains an internal hard coded, but easy to read hasref of arrays for a small subset of currencies (without taking regions into account). CLDR::Number::Format::Currency utilises the CLDR international Unicode consortium data which take into account language, region and currency.. but it's no longer maintained and is based on an older version of the CLDR data.. there's another option I wasn't aware of until yesterday, Locale::CLDR which appears to be sort of maintained in so much as it's using a more up to date export of the CLDR data.. but it's also a significantly larger module with all sorts of data that's not directly relevant to us. I'm tempted to come full circle and go back to using our DB to store just a relevant set of combinations.. perhaps populating it initially with a subset of the CLDR data which takes into account region + currency. Right now, I'm working on the maths side over at https://gitlab.com/mrenvoize/Koha/-/merge_requests/2, though I'm about to rip out Data::Money as a dependency.. in fixing that module I decided it would be easier to just replicate the bits we need within our codebase rather than pulling it in as a dependency and trying to disable the bit we don't want (the formatting) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #27 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #26)
I'm tempted to come full circle and go back to using our DB to store just a relevant set of combinations.. perhaps populating it initially with a subset of the CLDR data which takes into account region + currency.
Might be preferable to adding an unsupported dependency or an overkill dependency.
Right now, I'm working on the maths side over at https://gitlab.com/mrenvoize/Koha/-/merge_requests/2, though I'm about to rip out Data::Money as a dependency.. in fixing that module I decided it would be easier to just replicate the bits we need within our codebase rather than pulling it in as a dependency and trying to disable the bit we don't want (the formatting)
Makes sense to me. While I like offloading maintenance onto third-party dependencies, sometimes it's easier to just implement the code ourselves instead of dealing with problematic dependencies. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37511 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop@gmail.com --- Comment #28 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Jonathan Druart from comment #21)
(In reply to Martin Renvoize from comment #17)
I've been mulling this one over and I'm inclined to agree, that although this does move us towards the goal, it's at the wrong level.
I believe we should be formatting based on locale rather than by currency.
On the other hand it's either having it now (but not perfect), or not having it until... who knows? I am not planning to spend more time on this.
After more than four years... wouldn't it be just to get the patch anyway? After a little rebasing it seems to still work as intended and would be quite useful in the European context. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this turned into a duplicate of bug 37511 now. Duplicate effort :( *** This bug has been marked as a duplicate of bug 35711 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Corrected bug number. *** This bug has been marked as a duplicate of bug 37511 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org