[Bug 18026] New: URL to database columns link in system preferences is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Bug ID: 18026 Summary: URL to database columns link in system preferences is incorrect Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: dilan@calyx.net.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 59704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59704&action=edit Picture of the URL link Under the Acquisitions tab in Global system preferences, the link to the Koha items table URL is broken. The link should be: http://schema.koha-community.org/16_05/tables/items.html but the link instead is: http://schema.koha-community.org/tables/items.html Note the "16_05" missing in the latter. This causes a 404 "not found" error to result. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 dilan@calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- References to schema website are in these 3 files: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Created attachment 60137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60137&action=edit Bug 18026 - URL to database columns link in system preferences is incorrect Here's a patch for the 16.05 series, and the command I used to do the search/replace $ grep -irl 'schema.koha-community.org/tables' ./* | grep -v .git | xargs perl -pi -e 's^koha-community.org/tables^koha-community.org/16_05^' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60137|0 |1 is obsolete| | --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 60138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60138&action=edit Bug 18026 - URL to database columns link in system Here's a patch for the 16.05 series, and the command I used to do the search/replace grep -irl 'schema.koha-community.org/tables' ./* | grep -v .git | xargs perl -pi -e 's^koha-community.org/tables^koha-community.org/16_05/tables^' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com | |, katrin.fischer@bsz-bw.de, | |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 60230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60230&action=edit Bug 18026 - URL to database columns link in system preferences is incorrect (16.11.x) Here's a patch for the 16.11.x branch The command I used to do the search/replace was... $ grep -irl 'schema.koha-community.org/tables' ./* | grep -v .git | xargs perl -pi -e 's^koha-community.org/tables^koha-community.org/16_11^' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60138|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Created attachment 60231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60231&action=edit Bug 18026 - URL to database columns link in system preferences is incorrect (16.05.x) Here's a patch for the 16.05.x branch The command I used to do the search/replace was... $ grep -irl 'schema.koha-community.org/tables' ./* | grep -v .git | xargs perl -pi -e 's^koha-community.org/tables^koha-community.org/16_05^' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Created attachment 60232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60232&action=edit Bug 18026 - URL to database columns link in system preferences is incorrect (16.05.x) Here's a patch for the 16.05.x branch modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Created attachment 60233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60233&action=edit Bug 18026 - URL to database columns link in system preferences is incorrect (16.11.x) Here's a patch for the 16.11.x branch modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60231|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #8 from Mason James <mtj@kohaaloha.com> --- Created attachment 60234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60234&action=edit Bug 18026 - URL to database columns link in system preferences is incorrect (3.22.x) Here's a patch for the 3.22.x branch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Created attachment 60235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60235&action=edit Bug 18026 - URL to database columns link in system preferences is incorrect (master) Here's a patch for the master branch Changes to be committed: modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #10 from Marc Véron <veron@veron.ch> --- Hi Mason, Since we touch this part and for the sake of translatability: Is it possible to get rid of sentence splitting by HTML tags (at least for master)? Example (Link on 'Database schema'): ------------------- The following database columns will not appear on the patron self-modification screen: [ ] (separate columns with |) Database schema ------------------- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #11 from Mason James <mtj@kohaaloha.com> --- (In reply to Marc Véron from comment #10)
Hi Mason,
Since we touch this part and for the sake of translatability: Is it possible to get rid of sentence splitting by HTML tags (at least for master)?
Example (Link on 'Database schema'): ------------------- The following database columns will not appear on the patron self-modification screen: [ ] (separate columns with |) Database schema -------------------
Hi Mark, yes, sounds good :) could you attach a small example patch for me? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 60292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60292&action=edit Bug 18026 [ALTERNATIVE PATCH FOR MASTER] URL to database columns link in system preferences is incorrect Alternative patch for Master (with unsplitted sentences for better translatability) To test: - Apply patch to master - Go to Home > Administration > System preferences - Select Acquisitons, OPAC and Patrons, search for "Database schma", verify that text and links are correct. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 dilan@calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from dilan@calyx.net.au --- I tried to apply the patch to ptfs sandbox 0 but received the following error in an email during the sandbox setup: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 18026: <h1>Something went wrong !</h1>Applying: Bug 18026 - URL to database columns link in system preferences is incorrect (16.05.x) Applying: Bug 18026 - URL to database columns link in system preferences is incorrect (16.11.x) Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref Failed to merge in the changes. Patch failed at 0001 Bug 18026 - URL to database columns link in system preferences is incorrect (16.11.x) The copy of the patch that failed is found in: /home/koha/src/.git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 18026 - URL to database columns link in system preferences is incorrect 60232 - Bug 18026 - URL to database columns link in system preferences is incorrect (16.05.x) 60233 - Bug 18026 - URL to database columns link in system preferences is incorrect (16.11.x) 60234 - Bug 18026 - URL to database columns link in system preferences is incorrect (3.22.x) 60235 - Bug 18026 - URL to database columns link in system preferences is incorrect (master) 60292 - Bug 18026 [ALTERNATIVE PATCH FOR MASTER] URL to database columns link in system preferences is incorrect Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-18026---URL-to-database-columns-link-in-system-w0Wf3f.patch . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #14 from Marc Véron <veron@veron.ch> --- (In reply to dilan from comment #13)
I tried to apply the patch to ptfs sandbox 0 but received the following error in an email during the sandbox setup:
(...) The patches are for different versions of Koha, you should apply only one of them, depending on your version. Choose 'Interactive' while applying and then comment out the patches you do not want to apply. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60232|0 |1 is obsolete| | --- Comment #15 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 60420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60420&action=edit [SIGNED OFF] Bug 18026 - URL to database columns link in system preferences is incorrect (16.05.x) Here's a patch for the 16.05.x branch modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60233|0 |1 is obsolete| | --- Comment #16 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 60421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60421&action=edit [SIGNED OFF] Bug 18026 - URL to database columns link in system preferences is incorrect (16.11.x) Here's a patch for the 16.11.x branch modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60234|0 |1 is obsolete| | --- Comment #17 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 60422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60422&action=edit [SIGNED OFF] Bug 18026 - URL to database columns link in system preferences is incorrect (3.22.x) Here's a patch for the 3.22.x branch Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60235|0 |1 is obsolete| | Attachment #60292|0 |1 is obsolete| | --- Comment #18 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 60423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60423&action=edit [SIGNED OFF] Bug 18026 [ALTERNATIVE PATCH FOR MASTER] URL to database columns link in system preferences is incorrect Alternative patch for Master (with unsplitted sentences for better translatability) To test: - Apply patch to master - Go to Home > Administration > System preferences - Select Acquisitons, OPAC and Patrons, search for "Database schma", verify that text and links are correct. Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, but I am not sure that breaking up HTML in the pref files always makes sense, as it won't keep it out of translations and HTML there doesn't break the strings as it does in the templates. Putting it on different lines does. Before the change: First string (copied from 16.11): The following <a href='http://schema.koha-community.org/16_11/tables/borrowers.html' target='blank'>database columns</a> must be filled in on the patron entry screen: Second string: (separate columsn with |) After the change: First string: The following database columns must be filled in on the patron entry screen: Second string: <a href='http://schema.koha-community.org/master/tables/borrowers.html' target='blank'>Database schema</a> Third string: (separate columsn with |) <a href='http://schema.koha-community.org/master/tables/borrowers.html' target='blank'>Database schema</a> If we change it, why not have the "input help text" appear before the input field at least? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #20 from Marc Véron <veron@veron.ch> --- (In reply to Katrin Fischer from comment #19)
Sorry, but I am not sure that breaking up HTML in the pref files always makes sense, as it won't keep it out of translations and HTML there doesn't break the strings as it does in the templates. Putting it on different lines does.
Before the change:
First string (copied from 16.11): The following <a href='http://schema.koha-community.org/16_11/tables/borrowers.html' target='blank'>database columns</a> must be filled in on the patron entry screen: Second string: (separate columsn with |)
After the change: First string: The following database columns must be filled in on the patron entry screen: Second string: <a href='http://schema.koha-community.org/master/tables/borrowers.html' target='blank'>Database schema</a> Third string: (separate columsn with |) <a href='http://schema.koha-community.org/master/tables/borrowers.html' target='blank'>Database schema</a>
If we change it, why not have the "input help text" appear before the input field at least?
Sorry, I was not aware that splitting by HTML tags does not happen in system preferences. Please disregard my alternative patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60423|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am working on a more durable solution. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60420|0 |1 is obsolete| | Attachment #60421|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60456&action=edit Bug 18026: Correct URL to database columns from .pref files Recently the DB schema website has been updated. The link to the columns' tables is now http://schema.koha-community.org/master/tables/table.html http://schema.koha-community.org/16_11/tables/table.html http://schema.koha-community.org/16_05/tables/table.html instead of http://schema.koha-community.org/tables/table.html To have a specific schema per Koha version. To avoid fixing this link every release this patch adds a __VERSION__ marker to replace with the $version if stable ($version % 2) or 'master' Test plan: On master, 16.11.x and 16.05.x Search for PatronSelfRegistrationBorrowerUnwantedField, BorrowerMandatoryField and UniqueItemFields Click on the link You should get the correct page This patch WILL NOT WORK on 3.22.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The last patch is a more durable solution, it will avoid to update this link every release. For 3.22, use the other one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Patch for 3.22.x pushed to 3.22.x for 3.22.17 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60422|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #25 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Julian Maurice from comment #24)
Patch for 3.22.x pushed to 3.22.x for 3.22.17
Hope you toggled the minor % 0 check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60456|0 |1 is obsolete| | --- Comment #26 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 60475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60475&action=edit Bug 18026: Correct URL to database columns from .pref files [MASTER] Recently the DB schema website has been updated. The link to the columns' tables is now http://schema.koha-community.org/master/tables/table.html http://schema.koha-community.org/16_11/tables/table.html http://schema.koha-community.org/16_05/tables/table.html instead of http://schema.koha-community.org/tables/table.html To have a specific schema per Koha version. To avoid fixing this link every release this patch adds a __VERSION__ marker to replace with the $version if stable ($version % 2) or 'master' Test plan: On master, 16.11.x and 16.05.x Search for PatronSelfRegistrationBorrowerUnwantedField, BorrowerMandatoryField and UniqueItemFields Click on the link You should get the correct page This patch WILL NOT WORK on 3.22.x Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #27 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 60476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60476&action=edit Bug 18026: Correct URL to database columns from .pref files [16.11.x] Recently the DB schema website has been updated. The link to the columns' tables is now http://schema.koha-community.org/master/tables/table.html http://schema.koha-community.org/16_11/tables/table.html http://schema.koha-community.org/16_05/tables/table.html instead of http://schema.koha-community.org/tables/table.html To have a specific schema per Koha version. To avoid fixing this link every release this patch adds a __VERSION__ marker to replace with the $version if stable ($version % 2) or 'master' Test plan: On master, 16.11.x and 16.05.x Search for PatronSelfRegistrationBorrowerUnwantedField, BorrowerMandatoryField and UniqueItemFields Click on the link You should get the correct page This patch WILL NOT WORK on 3.22.x Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #28 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 60477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60477&action=edit Bug 18026: Correct URL to database columns from .pref files [16.05.x] Recently the DB schema website has been updated. The link to the columns' tables is now http://schema.koha-community.org/master/tables/table.html http://schema.koha-community.org/16_11/tables/table.html http://schema.koha-community.org/16_05/tables/table.html instead of http://schema.koha-community.org/tables/table.html To have a specific schema per Koha version. To avoid fixing this link every release this patch adds a __VERSION__ marker to replace with the $version if stable ($version % 2) or 'master' Test plan: On master, 16.11.x and 16.05.x Search for PatronSelfRegistrationBorrowerUnwantedField, BorrowerMandatoryField and UniqueItemFields Click on the link You should get the correct page This patch WILL NOT WORK on 3.22.x Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #29 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 60478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60478&action=edit Bug 18026: Correct URL to database columns from .pref files [3.22.x] Recently the DB schema website has been updated. The link to the columns' tables is now http://schema.koha-community.org/master/tables/table.html http://schema.koha-community.org/16_11/tables/table.html http://schema.koha-community.org/16_05/tables/table.html instead of http://schema.koha-community.org/tables/table.html To have a specific schema per Koha version. To avoid fixing this link every release this patch adds a __VERSION__ marker to replace with the $version if stable ($version % 2) or 'master' Test plan: On master, 16.11.x and 16.05.x Search for PatronSelfRegistrationBorrowerUnwantedField, BorrowerMandatoryField and UniqueItemFields Click on the link You should get the correct page NOTE: The master vs stable release logic changed when the major number became the YY format. This corrects the backported logic. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #30 from M. Tompsett <mtompset@hotmail.com> --- The 3.22.x one applies to 3.20.x There was no Version function in 3.18.x, and so I would not backport it that far back. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to M. Tompsett from comment #30)
The 3.22.x one applies to 3.20.x There was no Version function in 3.18.x, and so I would not backport it that far back.
3.20.x and 3.18.x are no longer maintained. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60475|0 |1 is obsolete| | Attachment #60478|0 |1 is obsolete| | --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 60524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60524&action=edit Bug 18026: Correct URL to database columns from .pref files Recently the DB schema website has been updated. The link to the columns' tables is now http://schema.koha-community.org/master/tables/table.html http://schema.koha-community.org/16_11/tables/table.html http://schema.koha-community.org/16_05/tables/table.html instead of http://schema.koha-community.org/tables/table.html To have a specific schema per Koha version. To avoid fixing this link every release this patch adds a __VERSION__ marker to replace with the $version if stable ($version % 2) or 'master' Test plan: On master, 16.11.x and 16.05.x Search for PatronSelfRegistrationBorrowerUnwantedField, BorrowerMandatoryField and UniqueItemFields Click on the link You should get the correct page This patch WILL NOT WORK on 3.22.x Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60476|0 |1 is obsolete| | --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 60525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60525&action=edit Bug 18026: Correct URL to database columns from .pref files [16.11.x] Recently the DB schema website has been updated. The link to the columns' tables is now http://schema.koha-community.org/master/tables/table.html http://schema.koha-community.org/16_11/tables/table.html http://schema.koha-community.org/16_05/tables/table.html instead of http://schema.koha-community.org/tables/table.html To have a specific schema per Koha version. To avoid fixing this link every release this patch adds a __VERSION__ marker to replace with the $version if stable ($version % 2) or 'master' Test plan: On master, 16.11.x and 16.05.x Search for PatronSelfRegistrationBorrowerUnwantedField, BorrowerMandatoryField and UniqueItemFields Click on the link You should get the correct page This patch WILL NOT WORK on 3.22.x Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60477|0 |1 is obsolete| | --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 60526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60526&action=edit Bug 18026: Correct URL to database columns from .pref files [16.05.x] Recently the DB schema website has been updated. The link to the columns' tables is now http://schema.koha-community.org/master/tables/table.html http://schema.koha-community.org/16_11/tables/table.html http://schema.koha-community.org/16_05/tables/table.html instead of http://schema.koha-community.org/tables/table.html To have a specific schema per Koha version. To avoid fixing this link every release this patch adds a __VERSION__ marker to replace with the $version if stable ($version % 2) or 'master' Test plan: On master, 16.11.x and 16.05.x Search for PatronSelfRegistrationBorrowerUnwantedField, BorrowerMandatoryField and UniqueItemFields Click on the link You should get the correct page This patch WILL NOT WORK on 3.22.x Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The new patches came in after the string freeze - pondering not to push to 16.11 because translators have already had to retranslate all the strings as I pushed the original patch with the hardcoded version. Could it make sense to only have this on master for the future? Because of the strings this is not going to make it into 16.11.04 and we can figure things out before the next one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #36)
Could it make sense to only have this on master for the future?
Yes, definitely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx! Switching to "pushed to stable" in case Mason wants it for 16.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #39 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #38)
Thx! Switching to "pushed to stable" in case Mason wants it for 16.05.
Pushed to 16.05.x, for 16.05.10 release (ps: i decided to use the hardcoded patch for the 16.05.x branch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi Blocks| |18222 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18222 [Bug 18222] Fix tests broken by Buug 18026 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Why is the status here 'pushed to master'? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org