[Bug 18173] New: Remove issues.return
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Bug ID: 18173 Summary: Remove issues.return Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60696&action=edit Bug 18173: Remove DB field issues.return The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. There is no proper test plan here. Just make sure this field has never been used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60696|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 60828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60828&action=edit Bug 18173: Remove DB field issues.return The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. There is no proper test plan here. Just make sure this field has never been used. Signed-off-by: Magnus Enger <magnus@libriotech.no> I have not found any use of issues.return or old_issues.return. In all my live instances the column is always NULL. Issuing and returning seems to work as expected after the columns have been removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60828|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 60829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60829&action=edit Bug 18173: Remove DB field issues.return The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. There is no proper test plan here. Just make sure this field has never been used. Signed-off-by: Magnus Enger <magnus@libriotech.no> I have not found any use of issues.return or old_issues.return. In all my live instances the column is always NULL. Issuing and returning seems to work as expected after the columns have been removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking around for return: offline_circ/process_koc.pl: 'return' => \&kocReturnItem, Definitely a bad choice for a hash key, but not relevant here.
From bug 16034 / Koha/ExternalContent/OverDrive.pm: =item C<return($id)> opac/svc/overdrive: $data{action} = eval { $od->return($id) }; A method called return ;) Not relevant too here.
Found nothing special with ->return or {return too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60829|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 60870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60870&action=edit Bug 18173: Remove DB field issues.return The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. There is no proper test plan here. Just make sure this field has never been used. Signed-off-by: Magnus Enger <magnus@libriotech.no> I have not found any use of issues.return or old_issues.return. In all my live instances the column is always NULL. Issuing and returning seems to work as expected after the columns have been removed. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 60871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60871&action=edit Bug 18173: DBIx schema changes Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18173 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org