[Bug 28405] New: Add author info to the holds page (reserve/request.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Bug ID: 28405 Summary: Add author info to the holds page (reserve/request.pl) Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jrobb@sekls.org QA Contact: testopia@bugs.koha-community.org Currently if you are placing a hold on a record in the staff client and want to double-check the author of the title, you have to click off to another page. It would be helpful to have the author information below the title information as it is on other pages. Currently, author information is already present on the "Checkout history" page (catalogue/issuehistory.pl) and the "Items" page (catalogue/moredetail.pl) so it would add some consistency to have it also present on the "Holds" page (reserve/request.pl). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #1 from George Williams (NEKLS) <george@nekls.org> --- It would be nice to have this information on that page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #2 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Having the author display on this page would be a big help and real time saver. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 121259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121259&action=edit Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version|20.05 |master Text to go in the| |This patch adds the author release notes| |name to place a hold page | |(request.tt) Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #4 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- A few things I noted during testing: If the author is in a 110 or 130 tag instead of a 100 tag it does not display. We don't have a lot of instances of this since we are a public library but it might matter to educational and special libraries. When the author is a one-named person (such as Lee in the screenshot) the display looks a little odd. It's a little confusing that the name Lee is just sort of floating there on the screen - it doesn't feel like it is connected to the title. Even with a standard author with first and last name it still doesn't feel quite connected to the title. This may not be possible, or preferable, but I wonder if it would be better to have the author display after the title on one line (see screenshot) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #5 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 121290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121290&action=edit One-name author -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #6 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 121291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121291&action=edit author on same line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Salman Ali <salman.ali@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |salman.ali@inLibro.com --- Comment #7 from Salman Ali <salman.ali@inLibro.com> --- I think Barbara is right and that the author name should be next to the title because it doesn't feel like it's connected to the title when it's placed below. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121259|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 121937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121937&action=edit Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121937|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 121940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121940&action=edit Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe the separator / is unnecessary. The title will already end with : or / (ISBD punctuation) and then the separator is doubled up. If we want to match with other places, maybe we should replace it with "by" as UNIMARC doesn't use punctuation. I also wonder if it would be nice to include an author option in the code for the title that takes care of that by also checking the MARC flavor... or removing additional ending punctuation. Just putting this here for now, I'd be happy with almost anything, but : / and // don't look nice right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- I agree that the "/" is unnecessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121940|0 |1 is obsolete| | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129678&action=edit Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129678|0 |1 is obsolete| | --- Comment #13 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 129735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129735&action=edit Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Why the WONTFIX? I hope it was not my comment, I'd be happy just with the double punctuation removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Status|RESOLVED |REOPENED --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #14)
Why the WONTFIX?
I hope it was not my comment, I'd be happy just with the double punctuation removed.
If I set this to WONTFIX, it was accidental. I believe the proper status should now be 'Signed off' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129735|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 130244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130244&action=edit Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: AUTHORNAME <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130337&action=edit Bug 28405: Add author for multi holds view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Do we want to display the author for the multi-holds view as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130244|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130534&action=edit Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130337|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130535&action=edit Bug 28405: Add author for multi holds view Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #18)
Do we want to display the author for the multi-holds view as well?
Yes, but you've already done it :) I have updated George's sign-off line: Signed-off-by: AUTHORNAME <george@nekls.org> Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add author info to the |Add author info to the |holds page |holds page in the staff |(reserve/request.pl) |interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org