[Bug 30101] New: OPAC advanced search page broken by Bug 29844
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30101 Bug ID: 30101 Summary: OPAC advanced search page broken by Bug 29844 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: tomascohen@gmail.com Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 29844 Template process failed: undef error - The method Koha::Library::Groups->id is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Objects.pm line 572 Koha::Objects::AUTOLOAD('Koha::Library::Groups=HASH(0x5576ff179cc8)') called at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 [Bug 29844] Remove uses of wantarray in Koha::Objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30101 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen@gmail.com |fridolin.somers@biblibre.co | |m CC| |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30101 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30101 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 130570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130570&action=edit Bug 30101: Fix OPAC advanced search after Bug 29844 Bug 29844 forgot to add as_list to opac-search.pl. You can see it changed search.pl Patch fixes and also adds explicit interface = opac in get_search_groups() call. Since intranet is explicit, opac should also be. We keep opac as default value. Test plan : 1) Create a libary group for OPAC and one for staff 2) Go to OPAC advanced search page 3) Check you see the OPAC libary group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30101 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 30091 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30101 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30101 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130570|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130572&action=edit Bug 30101: Fix OPAC advanced search after Bug 29844 Bug 29844 forgot to add as_list to opac-search.pl. You can see it changed search.pl Patch fixes and also adds explicit interface = opac in get_search_groups() call. Since intranet is explicit, opac should also be. We keep opac as default value. Test plan : 1) Create a libary group for OPAC and one for staff 2) Go to OPAC advanced search page 3) Check you see the OPAC libary group Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30101 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30101 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130572|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130590&action=edit Bug 30101: Fix OPAC advanced search after Bug 29844 Bug 29844 forgot to add as_list to opac-search.pl. You can see it changed search.pl Patch fixes and also adds explicit interface = opac in get_search_groups() call. Since intranet is explicit, opac should also be. We keep opac as default value. Test plan : 1) Create a libary group for OPAC and one for staff 2) Go to OPAC advanced search page 3) Check you see the OPAC libary group Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30101 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30101 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30101 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org