http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8039 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|katrin.fischer@bsz-bw.de |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 9768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9768&action=edit patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8039 --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 9845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9845&action=edit bug_8039: Try userid if cardnumber borrower search fails in SIP -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8039 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9845|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11070&action=edit bug_8039: Try userid if cardnumber borrower search fails in SIP -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8039 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13359&action=edit bug_8039: Try userid if cardnumber borrower search fails in SIP Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8039 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- I signed off on this patch because if works. However, I'm wondering if this should be configurable ( username, barcode, or both ). Here is my specific example, and a shameless plug. I'm the author of Libki, a kiosk management system. It supports SIP2 for user authentication. When a patron attempts to log in, Libki makes a SIP request for the user, if it comes back positive, it creates the account in Libki ( if it didn't already exists ). Each patron has an allotment of minutes they can use per day. With this patch, a clever person may realize he or she can login twice, once with his or her cardnumber, and once with his or her user id ( assuming they are not one and the same ). I think it would be good to make this a setting in SIPconfig.xml. That way, a library could run multiple instances of the SIP server with different settings. One could be for cardnumber/userid ( for sip2 SCO ) and another could be for userid only ( perhaps for Libki ). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8039 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- I hadn't thought of that. That is a good solution, and I hereby withdraw my caveat! (In reply to comment #8)

SIP2 will return the unique identifier (borrowernumber), so you could make Libki not make 2 users if the user already exists.

Since they can't actually login to Koha twice, it might be better to fix it on the Libki side, since other systems may well allow this too, and I assume Libki is designed to work with multiple ILSes?

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8039 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13359|0 |1 is obsolete| | --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13981&action=edit bug_8039: Try userid if cardnumber borrower search fails in SIP Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8039 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch complexity|--- |Small patch QA Contact| |paul.poulain@biblibre.com Severity|enhancement |normal --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * not an enhancement I think, but a normal bugfix I think * tiny patch, nothing specific to say about it * passes koha-qa.pl, except for tab as indent marker, but this file has many, I add a follow-up with s/tab/4spaces/g passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8039 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. I do not have an actual self-check machine, so I would be grateful if someone who does have one would test now that these patches have been pushed. -- You are receiving this mail because: You are watching all bug changes.