[Bug 8843] New: Cannot export bibliographic records by call number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Priority: P5 - low Change sponsored?: --- Bug ID: 8843 Assignee: oleonard@myacpl.org Summary: Cannot export bibliographic records by call number Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Tools Product: Koha The logic is wrong when building the query: if ($start_callnumber) { $sql_query .= " AND itemcallnumber <= ? "; push @sql_params, $start_callnumber; } if ($end_callnumber) { $sql_query .= " AND itemcallnumber >= ? "; push @sql_params, $end_callnumber; } The query must include items with call numbers *greater than* the starting call number and *less than* the ending call number, not vice versa. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12592&action=edit Bug 8843 - Cannot export bibliographic records by call number When building the query for exports by call number the script has the logic reversed. It tries to select records with call numbers less than the starting call number and greater than the ending call number. This should be reversed. To test, test an export in an unpatched system. An export by call number will return an empty file. After applying the patch an export by call number should give valid results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12592|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12597&action=edit [SIGNED-OFF] Bug 8843 - Cannot export bibliographic records by call number When building the query for exports by call number the script has the logic reversed. It tries to select records with call numbers less than the starting call number and greater than the ending call number. This should be reversed. To test, test an export in an unpatched system. An export by call number will return an empty file. After applying the patch an export by call number should give valid results. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA Comment * trivial bugfix ! * tiny bugfix ! passes QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Doesn't apply to 3.8.x, please rebase and submit for 3.8.x if needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12597|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13613&action=edit Bug 8843 [3.8.x] Cannot export bibliographic records by call number Reworked for 3.8.x: When building the query for exports by call number the script has the logic reversed. It tries to select records with call numbers less than the starting call number and greater than the ending call number. This should be reversed. To test, test an export in an unpatched system. An export by call number will return an empty file. After applying the patch an export by call number should give valid results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13613|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13646&action=edit Bug 8843 [3.8.x] Cannot export bibliographic records by call number Reworked for 3.8.x: When building the query for exports by call number the script has the logic reversed. It tries to select records with call numbers less than the starting call number and greater than the ending call number. This should be reversed. To test, test an export in an unpatched system. An export by call number will return an empty file. After applying the patch an export by call number should give valid results. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |elliott@bywatersolutions.co | |m Patch complexity|--- |Small patch --- Comment #8 from Elliott Davis <elliott@bywatersolutions.com> --- Marking Passed QA so that it will be visible to the 3.8.x RMaint. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.8, thank you for your effort of rebasing it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org