[Bug 30047] New: Add a field to auth_header to record main heading as text string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Bug ID: 30047 Summary: Add a field to auth_header to record main heading as text string Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org SQL queries looking at authority records are complicated by the fact that authorities don't have an equivalent to a biblio's title. It would be helpful to create a new database field (auth_header.main_heading) in which we record a text string. The specific value we record here would be determined by the authority type, following the mappings defined in authtypes.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 161208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161208&action=edit Bug 30047: DB Updates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 161209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161209&action=edit Bug 30047: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 161210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161210&action=edit Bug 30047: Add new heading field to auth_header table This patch adds a new heading field containing the display form of the authority record NOTE: If trying to save an auhority in the 'DEFAULT' framework, you will get an error, you should not be using DEFAULT for authorities and we should remove from the list on another bug To test: 1 - Apply patches 2 - Update database 3 - Restart all 4 - Create a new authority, save. 5 - Do this for various types 6 - View the db records: SELECT * FROM auth_header\G 7 - Note new heading field is populated correctly 8 - Edit your new authorities 9 - Confirm the heading field is updated correctly 10 - Import some authorities and confirm heading generated correctly 11 - Import auth via Z39.50 and confirm heading generated correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 161211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161211&action=edit Bug 30047: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161208|0 |1 is obsolete| | --- Comment #6 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161213&action=edit Bug 30047: DB Updates Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161209|0 |1 is obsolete| | --- Comment #7 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161214&action=edit Bug 30047: DO NOT PUSH - Schema updates Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161210|0 |1 is obsolete| | --- Comment #8 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161215&action=edit Bug 30047: Add new heading field to auth_header table This patch adds a new heading field containing the display form of the authority record NOTE: If trying to save an auhority in the 'DEFAULT' framework, you will get an error, you should not be using DEFAULT for authorities and we should remove from the list on another bug To test: 1 - Apply patches 2 - Update database 3 - Restart all 4 - Create a new authority, save. 5 - Do this for various types 6 - View the db records: SELECT * FROM auth_header\G 7 - Note new heading field is populated correctly 8 - Edit your new authorities 9 - Confirm the heading field is updated correctly 10 - Import some authorities and confirm heading generated correctly 11 - Import auth via Z39.50 and confirm heading generated correctly Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161211|0 |1 is obsolete| | --- Comment #9 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161216&action=edit Bug 30047: Unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- We do not have a script touching all authorities? That could fill the table for existing records? Another idea to accomplish that and mention in release notes? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161213|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 166522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166522&action=edit Bug 30047: DB Updates Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161214|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 166523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166523&action=edit Bug 30047: DO NOT PUSH - Schema updates Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161215|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 166524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166524&action=edit Bug 30047: Add new heading field to auth_header table This patch adds a new heading field containing the display form of the authority record NOTE: If trying to save an auhority in the 'DEFAULT' framework, you will get an error, you should not be using DEFAULT for authorities and we should remove from the list on another bug To test: 1 - Apply patches 2 - Update database 3 - Restart all 4 - Create a new authority, save. 5 - Do this for various types 6 - View the db records: SELECT * FROM auth_header\G 7 - Note new heading field is populated correctly 8 - Edit your new authorities 9 - Confirm the heading field is updated correctly 10 - Import some authorities and confirm heading generated correctly 11 - Import auth via Z39.50 and confirm heading generated correctly Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161216|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 166525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166525&action=edit Bug 30047: Unit tests Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #10)
We do not have a script touching all authorities? That could fill the table for existing records? Another idea to accomplish that and mention in release notes?
Something with misc/maintenance/update_authorities.pl ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Database |MARC Authority data support --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This looks a bit like a change I didn't see advertised here? It's obv correct... but I don't like sneaky code ;) '151' => { - auth_type => 'GEOG_NAME', + auth_type => 'GEOGR_NAME', subfields => 'avxyz68', main_entry => 1 We have some open bugs for problems with this authority type. Including a fix in an enh patch means it won't be fixed in stable versions. RMaints will pass over this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords| |additional_work_needed --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This broke t/db_dependent/Biblio.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #18)
This broke t/db_dependent/Biblio.t
I suspect more than Biblio.t, a lot of the authority related tests are failing: * t_db_dependent_api_v1_authorities_t * t_db_dependent_Koha_Authorities_t * t_db_dependent_Koha_Plugins_authority_hooks_t * t_db_dependent_Authority_Merge_t (copied from Jenkins, translate _) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #20 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166644&action=edit Bug 30047: (follow-up) Fix failing tests This patch updates the test files to correctly create authorities and/or correctly mock the needed data for authorities. the tests in t/db_dependent/Authority/Merge.t cover the case of 'Default' authorities which don't have valid headings - so I had to add handling for blanking the heading field when Default type is used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |release-notes-needed | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked follow-up for pushing to main, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36917 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36917 [Bug 36917] Many warnings from t/db_dependent/Authority/Merge.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #23 from David Cook <dcook@prosentient.com.au> --- This is awesome. I can't believe I didn't know about it until now! -- Thinking about indexing... On one hand, it's a shame that an index wasn't added for the heading column. On the other hand, off the top of my head I'm not sure if the index should be on the heading or on the heading and authtypecode. Additionally, "heading" is longtext, which can't be indexed without specifying a (limited) length. Of course, we wouldn't need a unique index. Just an index that could help search performance. Anyway... just going to leave that here for now. We can always see how it goes in production and then improve it if necessary... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #24 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Marcel de Rooy from comment #15)
(In reply to Marcel de Rooy from comment #10)
We do not have a script touching all authorities? That could fill the table for existing records? Another idea to accomplish that and mention in release notes?
Something with misc/maintenance/update_authorities.pl ?
This was not addressed, unless I'm missing something? Upon upgrade, is there something to do to populate this column in existing systems? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #25 from David Cook <dcook@prosentient.com.au> --- (In reply to Caroline Cyr La Rose from comment #24)
(In reply to Marcel de Rooy from comment #15)
(In reply to Marcel de Rooy from comment #10)
We do not have a script touching all authorities? That could fill the table for existing records? Another idea to accomplish that and mention in release notes?
Something with misc/maintenance/update_authorities.pl ?
This was not addressed, unless I'm missing something? Upon upgrade, is there something to do to populate this column in existing systems?
Yeah, it doesn't look like it was addressed. I reckon a new touch_all_authorities.pl might be a good way to go. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38133 [Bug 38133] Create a touch_all_authorities.pl script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 --- Comment #26 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I created(In reply to David Cook from comment #25)
(In reply to Caroline Cyr La Rose from comment #24)
(In reply to Marcel de Rooy from comment #15)
(In reply to Marcel de Rooy from comment #10)
We do not have a script touching all authorities? That could fill the table for existing records? Another idea to accomplish that and mention in release notes?
Something with misc/maintenance/update_authorities.pl ?
This was not addressed, unless I'm missing something? Upon upgrade, is there something to do to populate this column in existing systems?
Yeah, it doesn't look like it was addressed. I reckon a new touch_all_authorities.pl might be a good way to go.
I created Bug 38133. Unfortunately, this is useless to existing systems right now without a script to populate the new column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42211 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42211 [Bug 42211] Add a script to populate auth_header.heading column of existing authority records -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org