[Bug 41891] New: Move C4::Context->preferences to a separate package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Bug ID: 41891 Summary: Move C4::Context->preferences to a separate package Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 41890 Code to retrieve syspref's values will be moved to a separate (isolated) modules (Koha::Context::Preferences) to avoid circular dependencies. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41890 [Bug 41890] [OMNIBUS] Remove circular dependencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41892 [Bug 41892] Remove C4::Context from C4::Auth's BEGIN block -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41893 [Bug 41893] Remove C4::Context from Koha::Plugins's BEGIN block -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 193508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193508&action=edit Bug 41891: Move C4::Context->preference to Koha::Context::Preferences->get Patch from commit 8b559c5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I like it but... Koha::Context::Preferences loads Koha::Config::SysPrefs which loads Koha::Config::SysPref which loads C4::Log which loads C4::Context, so we'd still have a circular dependency. It looks like Koha::Object (used by Koha::Config::SysPref) assumes C4::Context is loaded as well as it uses C4::Context->tz in "sub _recursive_fixup". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- There's also the Koha::Cache issue but you've already got bug 41896 to take care of that. I think C4::Log could be updated with the changes to C4::Context->userenv() and C4::Context->preference()... It also uses C4::Context->interface... and the value is typically supplied by the controller. We'll need to do something about that. -- Looks like Koha/Logger.pmk, which is used by C4::Log, also uses C4::Context... Koha/ActionLogs.pm, which is used by C4::Log, also uses C4::Context. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41973 [Bug 41973] Remove C4::Context from Koha::Config::SysPref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41973 Depends on|41973 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41973 [Bug 41973] Remove C4::Context from Koha::Config::SysPref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41890 Depends on|41890 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41890 [Bug 41890] [OMNIBUS] Remove circular dependencies -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41972 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41972 [Bug 41972] Move C4::Context->interface to Koha::Context::Interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|41973 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41973 [Bug 41973] Remove C4::Context from Koha::Config::SysPref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #3)
There's also the Koha::Cache issue but you've already got bug 41896 to take care of that.
I think C4::Log could be updated with the changes to C4::Context->userenv() and C4::Context->preference()...
It also uses C4::Context->interface... and the value is typically supplied by the controller. We'll need to do something about that.
--
Looks like Koha/Logger.pmk, which is used by C4::Log, also uses C4::Context...
Koha/ActionLogs.pm, which is used by C4::Log, also uses C4::Context.
See bug 41972 and bug 41975. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #4)
(In reply to David Cook from comment #3)
There's also the Koha::Cache issue but you've already got bug 41896 to take care of that.
I think C4::Log could be updated with the changes to C4::Context->userenv() and C4::Context->preference()...
It also uses C4::Context->interface... and the value is typically supplied by the controller. We'll need to do something about that.
--
Looks like Koha/Logger.pmk, which is used by C4::Log, also uses C4::Context...
Koha/ActionLogs.pm, which is used by C4::Log, also uses C4::Context.
See bug 41972 and bug 41975.
Looks good to me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|41890 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41890 [Bug 41890] [OMNIBUS] Remove circular dependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42093 [Bug 42093] Use the REST API and kohaTable to list and search sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|41972 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41972 [Bug 41972] Move C4::Context->interface to Koha::Context::Interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 [Bug 41895] Introduce Koha::Context::UserEnv to reduce circ deps problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|41895 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 [Bug 41895] Introduce Koha::Context::UserEnv to reduce circ deps problem -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org