[Bug 29026] New: Behavior change when an empty barcode field is submitted in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 Bug ID: 29026 Summary: Behavior change when an empty barcode field is submitted in circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When preference CircAutoPrintQuickSlip is 'clear the screen', when an empty barcode field is submitted in circulation : Before Bug 17845, behavior was to display empty circulation page (no patron selected). Now behavior is displaying the circulation page of current patron. I think previous behavior was used when scanner is used to clear form and wait for another patron card to be scanned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 [Bug 17845] Printers related code should be removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 124877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124877&action=edit Bug 29026: Restore behavior when an empty barcode field is submitted in circulation When preference CircAutoPrintQuickSlip is 'clear the screen', when an empty barcode field is submitted in circulation : Before Bug 17845, behavior was to display empty circulation page (no patron selected). Now behavior is displaying the circulation page of current patron. I think previous behavior was used when scanner is used to clear form and wait for another patron card to be scanned. Test plan : 1) Set system preference CircAutoPrintQuickSlip to 'clear the screen' 2) Go to a patron circulation page 3) Post form without a barcode => Check you go to circulation page with no patron selected 4) Set system preference CircAutoPrintQuickSlip to 'open a print quick slip window' 5) Go to a patron circulation page 6) Post form without a barcode => Check you go to print quick slip window with correct datas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124877|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124884&action=edit Bug 29026: Restore behavior when an empty barcode field is submitted in circulation When preference CircAutoPrintQuickSlip is 'clear the screen', when an empty barcode field is submitted in circulation : Before Bug 17845, behavior was to display empty circulation page (no patron selected). Now behavior is displaying the circulation page of current patron. I think previous behavior was used when scanner is used to clear form and wait for another patron card to be scanned. Test plan : 1) Set system preference CircAutoPrintQuickSlip to 'clear the screen' 2) Go to a patron circulation page 3) Post form without a barcode => Check you go to circulation page with no patron selected 4) Set system preference CircAutoPrintQuickSlip to 'open a print quick slip window' 5) Go to a patron circulation page 6) Post form without a barcode => Check you go to print quick slip window with correct datas Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124884|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125338&action=edit Bug 29026: Restore behavior when an empty barcode field is submitted in circulation When preference CircAutoPrintQuickSlip is 'clear the screen', when an empty barcode field is submitted in circulation : Before Bug 17845, behavior was to display empty circulation page (no patron selected). Now behavior is displaying the circulation page of current patron. I think previous behavior was used when scanner is used to clear form and wait for another patron card to be scanned. Test plan : 1) Set system preference CircAutoPrintQuickSlip to 'clear the screen' 2) Go to a patron circulation page 3) Post form without a barcode => Check you go to circulation page with no patron selected 4) Set system preference CircAutoPrintQuickSlip to 'open a print quick slip window' 5) Go to a patron circulation page 6) Post form without a barcode => Check you go to print quick slip window with correct datas Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org