[Bug 28927] New: Id opacmainuserblock used twice in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Bug ID: 28927 Summary: Id opacmainuserblock used twice in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Since preference OpacMainUserBlock is an HTML customization, there is an HTML tags with id="opacmainuserblock" and one with id="OpacMainUserBlock". I think template block "koha_news_block" should add a class instead of an id. It fixes the bug and also it may be used several times in same page in the future. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 124267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124267&action=edit Since preference OpacMainUserBlock is an HTML customization, there is an HTML tags with id="opacmainuserblock" and one with id="OpacMainUserBlock". I think template block "koha_news_block" should add a class (lowercase) instead of an id. It fixes the bug and also it may be used several times in same page in the future. Test plan : 1) Create an HTML customization for OpacMainUserBlock with some text 2) Go to OPAC main page 3) Check HTML code of the page 4) Check you see class="opacmainuserblock" and not id="OpacMainUserBlock" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124267|0 |1 is obsolete| | --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 124318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124318&action=edit Since preference OpacMainUserBlock is an HTML customization, there is an HTML tags with id="opacmainuserblock" and one with id="OpacMainUserBlock". I think template block "koha_news_block" should add a class (lowercase) instead of an id. It fixes the bug and also it may be used several times in same page in the future. Test plan : 1) Create an HTML customization for OpacMainUserBlock with some text 2) Go to OPAC main page 3) Check HTML code of the page 4) Check you see class="opacmainuserblock" and not id="OpacMainUserBlock" https://bugs.koha-community.org/show_bug.cgi?id=28927 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |joonas.kylmala@iki.fi --- Comment #4 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Thanks, I think this change looks reasonable, though some things to fix. 1) Could you fix up the commit message, you mention that this fixes a bug but don't say which one, also mention in the commit message what the change does and use the format "Bug XXXX: Change X thing". I'm guessing you are doing this change to simplify (custom) CSS rules? 2) It seems to break the OpacHeader / opacheader CSS rule defined in the line koha/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss:#opacheader { -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Joonas Kylmälä from comment #4)
Thanks, I think this change looks reasonable, though some things to fix.
1) Could you fix up the commit message, you mention that this fixes a bug but don't say which one, also mention in the commit message what the change does and use the format "Bug XXXX: Change X thing". I'm guessing you are doing this change to simplify (custom) CSS rules?
Oups sorry i did a git mistake.
2) It seems to break the OpacHeader / opacheader CSS rule defined in the line
koha/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss:#opacheader {
Good point i'm on it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 124637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124637&action=edit Bug 28927: Fix id opacmainuserblock used twice in OPAC Since preference OpacMainUserBlock is an HTML customization, there is an HTML tags with id="opacmainuserblock" and one with id="OpacMainUserBlock". I think template block "koha_news_block" should add a class (lowercase) instead of an id. It fixes the bug and also it may be used several times in same page in the future. Test plan : 1) Create an HTML customization for OpacMainUserBlock with some text 2) Go to OPAC main page 3) Check HTML code of the page 4) Check you see class="opacmainuserblock" and not id="OpacMainUserBlock" https://bugs.koha-community.org/show_bug.cgi?id=28927 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124318|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Joonas Kylmälä from comment #4)
2) It seems to break the OpacHeader / opacheader CSS rule defined in the line
koha/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss:#opacheader {
Actually this rule does nothing, it defines same background color as "body" : #opacheader { background-color: #fcf9fc; } I propose de remove it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 124638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124638&action=edit Bug 28927: (follow-up) remove rule on id=opacheader in opac CSS Actually this rule does nothing, it defines same background color as "body" : #fcf9fc Test plan : 1) Without patch look at OPAC header 2) With patch OPAC header should have same background color -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124637|0 |1 is obsolete| | Attachment #124638|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 124793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124793&action=edit Bug 28927: Fix id opacmainuserblock used twice in OPAC Since preference OpacMainUserBlock is an HTML customization, there is an HTML tags with id="opacmainuserblock" and one with id="OpacMainUserBlock". I think template block "koha_news_block" should add a class (lowercase) instead of an id. It fixes the bug and also it may be used several times in same page in the future. Test plan : 1) Create an HTML customization for OpacMainUserBlock with some text 2) Go to OPAC main page 3) Check HTML code of the page 4) Check you see class="opacmainuserblock" and not id="OpacMainUserBlock" https://bugs.koha-community.org/show_bug.cgi?id=28927 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Rebased-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 --- Comment #10 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 124794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124794&action=edit Bug 28927: (follow-up) remove rule on id=opacheader in opac CSS Actually this rule does nothing, it defines same background color as "body" : #fcf9fc Test plan : 1) Without patch look at OPAC header 2) With patch OPAC header should have same background color Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | --- Comment #11 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Passing QA as Sally already signed this off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Current behaviour is definitely wrong, but I am wondering why we don't keep the id with the same capitalization (not lowered). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Asked Owen on IRC: oleonard> Hm, no... There should be a single OpacMainUserBlock, not two. The class would be correct if it were repeated for each additional content entry, but it's not. Joubu> yes, that's my point oleonard> I agree with the change removing the divs from opac-main.tt and opac-registration-confirmation.tt, those are cleanups I should have done earlier. oleonard> However I think the id in html_helpers.inc should stay. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124793|0 |1 is obsolete| | --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 125125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125125&action=edit Bug 28927: Fix id opacmainuserblock used twice in OPAC Since preference OpacMainUserBlock is now an HTML customization, there is actually an HTML tags with id="opacmainuserblock" and one with id="OpacMainUserBlock". Same for OPACNavRight in opac-registration-confirmation.tt This patch removed id from page to keep the one comming from HTML customization include. Test plan : 1) Create an HTML customization for OpacMainUserBlock with some text 2) Go to OPAC main page 3) Check HTML code of the page 4) Check you see id="OpacMainUserBlock" once and not id="opacmainuserblock" 5) Same for id="opacnavright" in opac-registration-confirmation.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124794|0 |1 is obsolete| | --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 125126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125126&action=edit Bug 28927: (follow-up) remove rule on id=opacheader in opac CSS Actually this rule does nothing, it defines same background color as "body" : #fcf9fc Test plan : 1) Without patch look at OPAC header 2) With patch OPAC header should have same background color Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #13)
Asked Owen on IRC:
oleonard> Hm, no... There should be a single OpacMainUserBlock, not two. The class would be correct if it were repeated for each additional content entry, but it's not. Joubu> yes, that's my point oleonard> I agree with the change removing the divs from opac-main.tt and opac-registration-confirmation.tt, those are cleanups I should have done earlier. oleonard> However I think the id in html_helpers.inc should stay.
Ok I'm in. Main patch needs a new signoff. I've kept followup patch if its OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125125|0 |1 is obsolete| | Attachment #125126|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125137&action=edit Bug 28927: Fix id opacmainuserblock used twice in OPAC Since preference OpacMainUserBlock is now an HTML customization, there is actually an HTML tags with id="opacmainuserblock" and one with id="OpacMainUserBlock". Same for OPACNavRight in opac-registration-confirmation.tt This patch removed id from page to keep the one comming from HTML customization include. Test plan : 1) Create an HTML customization for OpacMainUserBlock with some text 2) Go to OPAC main page 3) Check HTML code of the page 4) Check you see id="OpacMainUserBlock" once and not id="opacmainuserblock" 5) Same for id="opacnavright" in opac-registration-confirmation.tt https://bugs.koha-community.org/show_bug.cgi?id=28927 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125138&action=edit Bug 28927: (follow-up) remove rule on id=opacheader in opac CSS Actually this rule does nothing, it defines same background color as "body" : #fcf9fc Test plan : 1) Without patch look at OPAC header 2) With patch OPAC header should have same background color Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125137|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125332&action=edit Bug 28927: Fix id opacmainuserblock used twice in OPAC Since preference OpacMainUserBlock is now an HTML customization, there is actually an HTML tags with id="opacmainuserblock" and one with id="OpacMainUserBlock". Same for OPACNavRight in opac-registration-confirmation.tt This patch removed id from page to keep the one comming from HTML customization include. Test plan : 1) Create an HTML customization for OpacMainUserBlock with some text 2) Go to OPAC main page 3) Check HTML code of the page 4) Check you see id="OpacMainUserBlock" once and not id="opacmainuserblock" 5) Same for id="opacnavright" in opac-registration-confirmation.tt https://bugs.koha-community.org/show_bug.cgi?id=28927 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125138|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125333&action=edit Bug 28927: (follow-up) remove rule on id=opacheader in opac CSS Actually this rule does nothing, it defines same background color as "body" : #fcf9fc Test plan : 1) Without patch look at OPAC header 2) With patch OPAC header should have same background color Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This patch removes release notes| |redundant div with id | |'opacmainuserblock' and | |'opacheader' since there is | |already this id generated | |by HTML customization. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in| | --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org