http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 23930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23930&action=edit Proposed patch With patch applied test suite no longer reports 'experimental' warnings from this module -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23930|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25356&action=edit Bug 11479 Remove experimental given/when keywords Replace constructs using given and when by if/else feature now generates compilation warnings in 5.18 and is liable to change behaviour replaced the construcrs with if/else reformatted the if branching using perltidy to remove the now redundant indent Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #3)

This one is not a given/when, but a for/when. Which is not experimental. To me this patch is not relevant.

~/kohaclone$ perl -wc C4/MarcModificationTemplates.pm when is experimental at /home/cc/kohaclone/Koha/SimpleMARC.pm line 93. when is experimental at /home/cc/kohaclone/Koha/SimpleMARC.pm line 96. when is experimental at /home/cc/kohaclone/Koha/SimpleMARC.pm line 99. when is experimental at C4/MarcModificationTemplates.pm line 552. when is experimental at C4/MarcModificationTemplates.pm line 558. when is experimental at C4/MarcModificationTemplates.pm line 564. when is experimental at C4/MarcModificationTemplates.pm line 570. when is experimental at C4/MarcModificationTemplates.pm line 581. when is experimental at C4/MarcModificationTemplates.pm line 584. when is experimental at C4/MarcModificationTemplates.pm line 587. when is experimental at C4/MarcModificationTemplates.pm line 590. C4/MarcModificationTemplates.pm syntax OK And here is the notification from the 5.18 delta The smartmatch family of features are now experimental Smart match, added in v5.10.0 and significantly revised in v5.10.1, has been a regular point of complaint. Although there are a number of ways in which it is useful, it has also proven problematic and confusing for both users and implementors of Perl. There have been a number of proposals on how to best address the problem. It is clear that smartmatch is almost certainly either going to change or go away in the future. Relying on its current behavior is not recommended. Warnings will now be issued when the parser sees "~~", "given", or "when". To disable these warnings, you can add this line to the appropriate scope: no if $] >= 5.018, warnings => "experimental::smartmatch"; Consider, though, replacing the use of these features, as they may change behavior again before becoming stable. for/when relies on smartmatch the patch is relevant -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25356|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25497&action=edit Bug 11479 Remove experimental given/when keywords Replace constructs using given and when by if/else feature now generates compilation warnings in 5.18 and is liable to change behaviour replaced the construcrs with if/else reformatted the if branching using perltidy to remove the now redundant indent Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.