[Bug 11787] New: Use validation plugin when adding new vendor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11787 Bug ID: 11787 Summary: Use validation plugin when adding new vendor Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/supplier.pl?op=enter OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The vendor entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11787 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11787 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25394&action=edit Bug 11787 - Use validation plugin when adding new vendor The vendor entry form uses some custom JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. Also corrected: Minor validation issue. To test, apply the patch and go to Acquisitions -> New vendor. Try submitting the form without entering a vendor name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing vendor should also work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11787 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11787 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25394|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25406&action=edit Bug 11787 - Use validation plugin when adding new vendor The vendor entry form uses some custom JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. Also corrected: Minor validation issue. To test, apply the patch and go to Acquisitions -> New vendor. Try submitting the form without entering a vendor name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing vendor should also work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11787 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11787 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25406|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25481&action=edit Bug 11787 - Use validation plugin when adding new vendor The vendor entry form uses some custom JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. Also corrected: Minor validation issue. To test, apply the patch and go to Acquisitions -> New vendor. Try submitting the form without entering a vendor name. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing vendor should also work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11787 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11787 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org