[Bug 12614] New: Remove CGI::scrolling_list from auth_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Bug ID: 12614 Summary: Remove CGI::scrolling_list from auth_subfields_structure.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org Many to remove in this file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29879&action=edit Bug 12614: Remove CGI::scrolling_list from auth_subfields_structure.pl This patch removes all instances on this file. Even removes some commented out instances. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > Authority types 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 031 5. Clic 'Edit subfields' button Now the tests proper 6. 'Help input' box (editor bottom): Eight(8) scrolling_list removed, they use to feed the four pulldowns, so check each one 'Koha field' is new (for me at last) 'Authorised value', 'Thesaurus' (is this valid/useful here?) 'Plugin' There is a difference between existing subtags and a new subtag, the 'id' of the pulldowns (so the 8 scrolling list removed) Check assign/remove/save/load values, search for regressions If you edit subtag 942, it has a value on kohafield (default fw) I think that this box could be prettified with fixed width for pulldowns. 7. No more functional tests, there are 4 scrolling_list removed that are commented (removed also commented code on tt file), and two instances that are similar to previously removed instances, evidently with no effect. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Blocks| |766 Assignee|oleonard@myacpl.org |bgkriegel@gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29879|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30130&action=edit Bug 12614: Remove CGI::scrolling_list from auth_subfields_structure.pl This patch removes all instances on this file. Even removes some commented out instances. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > Authority types 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 031 5. Clic 'Edit subfields' button Now the tests proper 6. 'Help input' box (editor bottom): Eight(8) scrolling_list removed, they use to feed the four pulldowns, so check each one 'Koha field' is new (for me at last) 'Authorised value', 'Thesaurus' (is this valid/useful here?) 'Plugin' There is a difference between existing subtags and a new subtag, the 'id' of the pulldowns (so the 8 scrolling list removed) Check assign/remove/save/load values, search for regressions If you edit subtag 942, it has a value on kohafield (default fw) I think that this box could be prettified with fixed width for pulldowns. 7. No more functional tests, there are 4 scrolling_list removed that are commented (removed also commented code on tt file), and two instances that are similar to previously removed instances, evidently with no effect. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Not sure about the new Koha field entry... All works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30130|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30234&action=edit [PASSED QA] Bug 12614: Remove CGI::scrolling_list from auth_subfields_structure.pl This patch removes all instances on this file. Even removes some commented out instances. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > Authority types 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 031 5. Clic 'Edit subfields' button Now the tests proper 6. 'Help input' box (editor bottom): Eight(8) scrolling_list removed, they use to feed the four pulldowns, so check each one 'Koha field' is new (for me at last) 'Authorised value', 'Thesaurus' (is this valid/useful here?) 'Plugin' There is a difference between existing subtags and a new subtag, the 'id' of the pulldowns (so the 8 scrolling list removed) Check assign/remove/save/load values, search for regressions If you edit subtag 942, it has a value on kohafield (default fw) I think that this box could be prettified with fixed width for pulldowns. 7. No more functional tests, there are 4 scrolling_list removed that are commented (removed also commented code on tt file), and two instances that are similar to previously removed instances, evidently with no effect. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Not sure about the new Koha field entry... All works as expected. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All works as expected. About Koha field: I think it makes sense to have it in the form, so you can configure the fields for new authority types. In my database I have mappings on authtypecode and authid. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12091 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org