[Bug 11231] New: notes should be reservenotes in pendingreserves.pl and reserveratios.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Bug ID: 11231 Summary: notes should be reservenotes in pendingreserves.pl and reserveratios.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.saby@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In pendingreserves.pl and reserveratios.pl there is SQL query returning "notes". The only notes field in the query are from biblio and biblioitems table. I suppose the expected result is the note about the reserve. It is in "reserves.reservenote" M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Francesca <francescalamoore@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francescalamoore@gmail.com --- Comment #1 from Francesca <francescalamoore@gmail.com> --- the notes don't display on the page(pull reserves) at all, so you are currently asking for data that isn't displayed. Also, when I changed "notes," for "reserves.reservenote", the page didn't display the reserve at all. I'm just a bit confused over why this fix needs to be done now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Carrying over a comment I made in IRC, the holds to pull report originally took the note field from the bib record. However, that's not necessarily all that useful, and the notes were removed from the template by commit a13c0db. However, that commit did not remove the notes column from the SQL. One reasonable resolution would be to simply remove 'notes' from the SQL query. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Ditto for the hold ratios report; at present I don't see any particular reason why either bib-level or request-level notes need to be displayed in that report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Francesca <francescalamoore@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 --- Comment #4 from Francesca <francescalamoore@gmail.com> --- Created attachment 24325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24325&action=edit 11231 notes should be reservenotes notes have been removed as they were not displaying in the first place. 1.apply patch 2.verify that both reports work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24325|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25958&action=edit Bug 11231 - notes should be reservenotes in pendingreserves.pl and reserveratios.pl notes have been removed as they were not displaying in the first place. 1.apply patch 2.verify that both reports work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |francescalamoore@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25958|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26412&action=edit Bug 11231 - notes should be reservenotes in pendingreserves.pl and reserveratios.pl notes have been removed as they were not displaying in the first place. 1.apply patch 2.verify that both reports work Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Francesca! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Picked for 3.12.15! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org