https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23328 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23328 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91583|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91671&action=edit Bug 23328: Some check-in messages should be dismissable There are several cases where the check-in process displays a modal asking for confirmation. There are several cases where confirming or dismissing the modal unnecessarily reloads the page. In cases where no server-side action is necessary, the modal should be dismissed without submitting a form. To test, apply the patch and go to Circulation -> Check in With AutomaticItemReturn enabled and AllowReturnToBranch set to "any library," - Check in an item which belongs at another library and is not already in-transit. In the confirmation modal which appears, clicking the "OK" button should close the modal without reloading the page. - Check in another item from anther branch. In the confirmation modal clicking the "Print slip" button should trigger a pop-up window for printing a slip but the modal should be dismissed without reloading the page. - Check in an item which is already in-transit to another branch. In the confirmation modal, clicking either the "OK" or "Print transfer slip" buttons should dismiss the modal without reloading the page. - Clicking the "Cancel transfer" button should work as before: The page reloads and the transfer is canceled. With AutomaticItemReturn disabled, - Check in an item belonging to another library. The confirmation modal should ask you whether you want to "Transfer now?" Clicking "No" should dismiss the modal without reloading the page. The other options should reload the page and initiate the transfer. With AllowReturnToBranch set to "only the library the item is from," - Check in an item belonging to another library. You should see a "Cannot check in" modal. Clicking the "OK" button should close the modal without reloading the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23328 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23328 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91671|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91869&action=edit Bug 23328: Some check-in messages should be dismissable There are several cases where the check-in process displays a modal asking for confirmation. There are several cases where confirming or dismissing the modal unnecessarily reloads the page. In cases where no server-side action is necessary, the modal should be dismissed without submitting a form. To test, apply the patch and go to Circulation -> Check in With AutomaticItemReturn enabled and AllowReturnToBranch set to "any library," - Check in an item which belongs at another library and is not already in-transit. In the confirmation modal which appears, clicking the "OK" button should close the modal without reloading the page. - Check in another item from anther branch. In the confirmation modal clicking the "Print slip" button should trigger a pop-up window for printing a slip but the modal should be dismissed without reloading the page. - Check in an item which is already in-transit to another branch. In the confirmation modal, clicking either the "OK" or "Print transfer slip" buttons should dismiss the modal without reloading the page. - Clicking the "Cancel transfer" button should work as before: The page reloads and the transfer is canceled. With AutomaticItemReturn disabled, - Check in an item belonging to another library. The confirmation modal should ask you whether you want to "Transfer now?" Clicking "No" should dismiss the modal without reloading the page. The other options should reload the page and initiate the transfer. With AllowReturnToBranch set to "only the library the item is from," - Check in an item belonging to another library. You should see a "Cannot check in" modal. Clicking the "OK" button should close the modal without reloading the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23328 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23399 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 [Bug 23399] Reindent returns.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23328 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23328 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.