https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|gmcharlt@gmail.com |agustinmoyano@theke.io --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Maybe using this? https://www.npmjs.com/package/simple-keyboard-layouts -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #3 from Agustín Moyano <agustinmoyano@theke.io> --- I see advanced editor already has this functionality.. Is this intended for basic editor, or is this duplicate of 18417? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a popup/keyboard |Add a popup/keyboard |shortcuts for diacritics |shortcuts for diacritics |and symbols in the |and symbols in the advanced |cataloging editor |cataloging editor -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #5 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89784&action=edit Bug 17178: Add shortcut to keyboard_shortcut table This patch adds Ctrl-K shortcut to toggle virtual keyboard shortcut Sponsored-by: Round Rock Public Library -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch --- Comment #7 from Agustín Moyano <agustinmoyano@theke.io> ---

Please use https://gitlab.com/thekesolutions/Koha/tree/bug-17178

I dont know if I expressed my self correctly.. I ment use this repo https://gitlab.com/thekesolutions/Koha with branch bug-17178 Thanks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Hi, For the Māori keyboard, I didn't see how to add the tohutō, we may need to add a layout for it like they recommend here? https://github.com/hodgef/simple-keyboard-layouts/wiki/Supported-Layouts I know that it's a relatively obscure language to ensure support for, but it's important because Koha comes from New Zealand. Otherwise, functionally this works fine. I think if we just add a layout for Māori, either just for us or to the originating project, this should be good to go. I might be convinced to make all of that a follow up bug as well, so this one can move on. :) Does anyone else have opinions about this? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Liz Rea from comment #8)

I know that it's a relatively obscure language to ensure support for, but it's important because Koha comes from New Zealand.

We should support it.

Otherwise, functionally this works fine. I think if we just add a layout for Māori, either just for us or to the originating project, this should be good to go.

I might be convinced to make all of that a follow up bug as well, so this one can move on. :)

This seriously belongs to a separate bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Change sponsored?|Sponsored |--- --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- The feature works well and it will be a relatively small job to add the Māori keyboard layout, good for the academy possibly. Will file another bug to be sure we add it. Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #12 from Liz Rea <wizzyrea@gmail.com> --- still a problem with request entity too large, but you can get the patch (which should have an implied sign off from me) from Theke's gitlab. Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Attachment #89795|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Just one question: why are all the language and layout files added to the codebase, when you need only the ones named all.js? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Agustín Moyano from comment #14)

(In reply to Josef Moravec from comment #13)

...

Just one question:

why are all the language and layout files added to the codebase, when you need only the ones named all.js?

Hi Josef, all.js is constructed by concatenating all js files..

So, if you want to modify one language, or add a new one you should:

1. remove all.js 2. place the new file in that directory (or modify an existing file) 3. cat *.js > all.js

Agustin, I think Josef's question is if we really need to ship those files with the project, or we can just remove them to save space. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Agustín Moyano from comment #16)

(In reply to Tomás Cohen Arazi from comment #15)

...

(In reply to Agustín Moyano from comment #14)

...

(In reply to Josef Moravec from comment #13)

...

Just one question:

why are all the language and layout files added to the codebase, when you need only the ones named all.js?

Hi Josef, all.js is constructed by concatenating all js files..

So, if you want to modify one language, or add a new one you should:

1. remove all.js 2. place the new file in that directory (or modify an existing file) 3. cat *.js > all.js

Agustin, I think Josef's question is if we really need to ship those files with the project, or we can just remove them to save space.

If modifications from layout / languages are required, it would be rather inconvenient to have to import those files, make the adjustments and remove them...

I'm not sure which is best..

To make modifications, surely the most convenient option is to have those files, but it's clear there are a lot of files..

maybe we could have a separate repo somehow and import / copy the resultant all.js

But why don't to contribute back to Mottie Keyboard? Also, these files are minified, I don't think anybody would like to edit minified files... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Josef Moravec from comment #17)

...

I'm not sure which is best..

To make modifications, surely the most convenient option is to have those files, but it's clear there are a lot of files..

maybe we could have a separate repo somehow and import / copy the resultant all.js

But why don't to contribute back to Mottie Keyboard?

Also, these files are minified, I don't think anybody would like to edit minified files...

Josef, Agustin removed the files from the commit and only have all.js now. We propose to keep our own community fork (in next dev meeting agenda) just in case someone wants to add any special layout that doesn't fit upstream, and we will document how all.js is generated (basically cat *.js > all.js) so we can keep it up-to-date with upstream (probably automated build of all.js). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 90976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90976&action=edit Bug 17178: Add virtual keyboard to advanced cataloguing editor This patch adds Mottie keyboard (https://github.com/Mottie/Keyboard) to advanced editor. To test: 1) Apply patches 2) perl install/data/mysql/updatedatabase.pl 3) Enable EnableAdvancedCatalogingEditor system preference 4) Go to cataloguing and to Advanced editor 5) Click on Keyboard shortcuts SUCCESS => the keyboard shortcut "Ctrl-K" should be displayed, with "Toggle keyboard" as description 6) press Ctrl-K SUCCESS => a virtual keyboard should be displayed, and a new toolbar button labeled "Keyboard layout" should appear. => when you press a letter on both the physical and virtual keyboard, they should be added to the editor. 7) Click on "Keyboard layout" SUCCESS => a modal should appear, where you can filter and select keyboard layouts. => when you select a layout, it should be reflected on the keyboard. => when you close the modal without selecting a layout, it should keep using the previous layout. 8) Sign off Sponsored-by: Round Rock Public Library -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90976|0 |1 is obsolete| | --- Comment #23 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 91004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91004&action=edit Bug 17178: Add virtual keyboard to advanced cataloguing editor This patch adds Mottie keyboard (https://github.com/Mottie/Keyboard) to advanced editor. To test: 1) Apply patches 2) perl install/data/mysql/updatedatabase.pl 3) Enable EnableAdvancedCatalogingEditor system preference 4) Go to cataloguing and to Advanced editor 5) Click on Keyboard shortcuts SUCCESS => the keyboard shortcut "Ctrl-K" should be displayed, with "Toggle keyboard" as description 6) press Ctrl-K SUCCESS => a virtual keyboard should be displayed, and a new toolbar button labeled "Keyboard layout" should appear. => when you press a letter on both the physical and virtual keyboard, they should be added to the editor. 7) Click on "Keyboard layout" SUCCESS => a modal should appear, where you can filter and select keyboard layouts. => when you select a layout, it should be reflected on the keyboard. => when you close the modal without selecting a layout, it should keep using the previous layout. 8) Sign off Sponsored-by: Round Rock Public Library Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Josef Moravec from comment #24)

I am not big fan of forking, but if community will be OK with, I am OK with it too.

Well, there's no actual fork anyway. We were just thinking in advance about the case someone wants to add new layouts that don't match upstream requirements. So we are good. We forgot to add Liz's SO line from when the patches were in a remote branch due to size limitations in Bugzilla. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also, maybe I read too fast the comments from this bug report, but can you explain: Why https://github.com/Mottie/Keyboard over https://www.npmjs.com/package/simple-keyboard-layouts finally? (In reply to Tomás Cohen Arazi from comment #25)

Well, there's no actual fork anyway. We were just thinking in advance about the case someone wants to add new layouts that don't match upstream requirements. So we are good.

Why are we talking about forking? What are those requirements? Did we contact them? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #29 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #27)

Why are we talking about forking? What are those requirements? Did we contact them?

In order to have a list of available layouts, and have a modal window to select and filter them, you have to load them in advance. I could have had perl scan layouts directory, get all files in an array and pass it to the template to make the apropiate includes, or what I thought it was simpler.. to just "cat *.js > all.min.js" and include that single file. If everyone thinks the first choice is best, I have absolutly no problem to chenge the code. I'm still new to developing in Koha and Perl (coming from NodeJS universe, this still feels a little strange, hehe), so please be patient with me. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Agustín Moyano from comment #29)

(In reply to Jonathan Druart from comment #27)

...

Why are we talking about forking? What are those requirements? Did we contact them?

In order to have a list of available layouts, and have a modal window to select and filter them, you have to load them in advance.

I could have had perl scan layouts directory, get all files in an array and pass it to the template to make the apropiate includes, or what I thought it was simpler.. to just "cat *.js > all.min.js" and include that single file.

If everyone thinks the first choice is best, I have absolutly no problem to chenge the code.

I'm still new to developing in Koha and Perl (coming from NodeJS universe, this still feels a little strange, hehe), so please be patient with me.

I think I prefer an explicit list of layouts. We could even have a syspref later, to select some of them instead of all (?) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We're not quite there yet with this one... setting back to NSO. There appears to still be some conversations going on here and I'd really like to see a clear route for ongoing maintenance of this new dependancy mapped out before pushing it. Also, I've gone for NSO as Liz's SO line is still missing and I believe the patch has changed somewhat since she tested.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #35 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 91078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91078&action=edit Bug 17178: Add virtual keyboard to advanced cataloguing editor This patch adds Mottie keyboard (https://github.com/Mottie/Keyboard) to advanced editor. To test: 1) Apply patches 2) perl install/data/mysql/updatedatabase.pl 3) Enable EnableAdvancedCatalogingEditor system preference 4) Go to cataloguing and to Advanced editor 5) Click on Keyboard shortcuts SUCCESS => the keyboard shortcut "Ctrl-K" should be displayed, with "Toggle keyboard" as description 6) press Ctrl-K SUCCESS => a virtual keyboard should be displayed, and a new toolbar button labeled "Keyboard layout" should appear. => when you press a letter on both the physical and virtual keyboard, they should be added to the editor. 7) Click on "Keyboard layout" SUCCESS => a modal should appear, where you can filter and select keyboard layouts. => when you select a layout, it should be reflected on the keyboard. => when you close the modal without selecting a layout, it should keep using the previous layout. 8) Sign off Sponsored-by: Round Rock Public Library Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 --- Comment #37 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 91080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91080&action=edit Bug 17178: Add virtual keyboard to advanced cataloguing editor This patch adds Mottie keyboard (https://github.com/Mottie/Keyboard) to advanced editor. To test: 1) Apply patches 2) perl install/data/mysql/updatedatabase.pl 3) Enable EnableAdvancedCatalogingEditor system preference 4) Go to cataloguing and to Advanced editor 5) Click on Keyboard shortcuts SUCCESS => the keyboard shortcut "Ctrl-K" should be displayed, with "Toggle keyboard" as description 6) press Ctrl-K SUCCESS => a virtual keyboard should be displayed, and a new toolbar button labeled "Keyboard layout" should appear. => when you press a letter on both the physical and virtual keyboard, they should be added to the editor. 7) Click on "Keyboard layout" SUCCESS => a modal should appear, where you can filter and select keyboard layouts. => when you select a layout, it should be reflected on the keyboard. => when you close the modal without selecting a layout, it should keep using the previous layout. 8) Sign off Sponsored-by: Round Rock Public Library Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91080|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 91107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91107&action=edit Bug 17178: Add virtual keyboard to advanced cataloguing editor This patch adds Mottie keyboard (https://github.com/Mottie/Keyboard) to advanced editor. To test: 1) Apply patches 2) perl install/data/mysql/updatedatabase.pl 3) Enable EnableAdvancedCatalogingEditor system preference 4) Go to cataloguing and to Advanced editor 5) Click on Keyboard shortcuts SUCCESS => the keyboard shortcut "Ctrl-K" should be displayed, with "Toggle keyboard" as description 6) press Ctrl-K SUCCESS => a virtual keyboard should be displayed, and a new toolbar button labeled "Keyboard layout" should appear. => when you press a letter on both the physical and virtual keyboard, they should be added to the editor. 7) Click on "Keyboard layout" SUCCESS => a modal should appear, where you can filter and select keyboard layouts. => when you select a layout, it should be reflected on the keyboard. => when you close the modal without selecting a layout, it should keep using the previous layout. 8) Sign off Sponsored-by: Round Rock Public Library Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Right.. Thanks for the rapid follow correcting the shortcut. Signing off and passing QA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23232 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23232 [Bug 23232] Enable the option to use the onscreen keyboard on the basic cataloguing editor -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #43 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored by Round Rock | release notes|Public Library. | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored by: Round Rock | release notes|Public Library | |<https://www.roundrocktexas | |.gov/departments/library/> | -- You are receiving this mail because: You are watching all bug changes.