https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36229 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36229 --- Comment #1 from Imani <imani.thomas@bywatersolutions.com> --- Created attachment 176230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176230&action=edit Bug 36229: Move koha-run-backups to the top of the cron test plan: 1. check run order of scripts in the cron 2. apply patch 3. koha-run-backups is now at the beginning of the cron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36229 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176230|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 176284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176284&action=edit Bug 36229: Move koha-run-backups to the top of the cron test plan: 1. check run order of scripts in the cron 2. apply patch 3. koha-run-backups is now at the beginning of the cron Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36229 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36229 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the order of the release notes| |daily cron jobs | |(/etc/cron.daily/koha-commo | |n) so that koha-run-backups | |is run first. | | | |Reasons for | |this include: | | | |1. The | |koha-run-backups cron job | |takes a backup before | |running scripts that change | |database contents. If there | |is a problem with those | |scripts, you'll have a very | |recent backup on which to | |fallback. | | | |2. It's a | |resource intensive job. If | |you have a lot of Koha | |instances, this means | |you're running your most | |intensive job at the end of | |the job run, which might be | |a lot later in the day than | |you anticipate. (Of course, | |you can update /etc/crontab | |to change when | |/etc/cron.daily is run, but | |this will help reduce | |impact in the meantime.) CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- I've added a release note, but a quick question: Will this change only fix this for new installations? If it does, I'll add a note that this change will need to be made manually for existing installations. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36229 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the order of the |This fixes the order of the release notes|daily cron jobs |daily cron jobs |(/etc/cron.daily/koha-commo |(/etc/cron.daily/koha-commo |n) so that koha-run-backups |n) so that koha-run-backups |is run first. |is run first. | | |Reasons for |Reasons for |this include: |this include: | | |1. The |1. The |koha-run-backups cron job |koha-run-backups cron job |takes a backup before |takes a backup before |running scripts that change |running scripts that change |database contents. If there |database contents. If there |is a problem with those |is a problem with those |scripts, you'll have a very |scripts, you'll have a very |recent backup on which to |recent backup on which to |fallback. |fallback. | | |2. It's a |2. It's a |resource intensive job. If |resource intensive job. If |you have a lot of Koha |you have a lot of Koha |instances, this means |instances, this means |you're running your most |you're running your most |intensive job at the end of |intensive job at the end of |the job run, which might be |the job run, which might be |a lot later in the day than |a lot later in the day than |you anticipate. (Of course, |you anticipate. (Of course, |you can update /etc/crontab |you can update /etc/crontab |to change when |to change when |/etc/cron.daily is run, but |/etc/cron.daily is run, but |this will help reduce |this will help reduce |impact in the meantime.) |impact in the meantime.) | | | |Deployment of this change: | |- New installations: This | |change will seamlessly | |apply for new | |installations. | |- Existing | |installations: | | . You | |HAVEN'T manually modified | |the crontab: it will | |seamlessly apply. | | . You | |HAVE manually modified the | |crontab: you will be | |prompted, and will need to | |decide about applying the | |change. | | . Where | |deployment tools are used | |(such as Ansible): this | |will depend on what tools | |you use and how they are | |configured. --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to David Cook from comment #6)

(In reply to David Nind from comment #5)

...

I've added a release note, but a quick question: Will this change only fix this for new installations?

If it does, I'll add a note that this change will need to be made manually for existing installations.

It's complicated.

It will seamlessly apply for new installations, it will seamlessly apply for existing installations where the crontab hasn't been previously manually modified.

For existing installations where the crontab has been previously manually modified, sysadmins will be prompted to decide whether or not to apply the change. (Deployment tools like Ansible are often set to automatically accept changes, so automated deployments often will apply the change, but it will vary by individual implementation.)

Thanks for the great explanation David! I've updated the release note to hopefully reflect this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36229 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.