[Bug 36163] New: Usage statistics - Not possible to select a country
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Bug ID: 36163 Summary: Usage statistics - Not possible to select a country Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: koha.gehim@erine.email QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Site: .../cgi-bin/koha/admin/usage_statistics.pl If you try to select a country, you get an error: == The value of your system preference 'UsageStatsCountry' is not valid (Germany). Please select a valid one. == It doesn't matter which country you chose, no country is valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.11 |master Severity|minor |normal --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed. There is also an error message: Note: The value of your system preference 'UsageStatsCountry' is not valid (Algeria). Please select a valid one. The pull down appears to be the same as for UsageStatsCountry system preference. Not sure what the right fix here would be. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 176822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176822&action=edit Bug 36163: Usage statistics - Not possible to select a country Site: .../cgi-bin/koha/admin/usage_statistics.pl If you try to select a country, you get an error: == The value of your system preference 'UsageStatsCountry' is not valid (Germany). Please select a valid one. == It doesn't matter which country you chose, no country is valid. Test plan: ========== 1. Select a country for UsageStatsCountry system preference. 2. Go to http://<your addr>:8081/cgi-bin/koha/admin/usage_statistics.pl 3. Confirm the issue. 4. Apply the patch ; restart_all. 5. Repeat p. 2. 6. Confirm that the issue has been solved. Sponsored-by: Ignatianum University in Cracow -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | Change sponsored?|--- |Sponsored CC| |januszop@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176822|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 176831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176831&action=edit Bug 36163: Usage statistics - Not possible to select a country Site: .../cgi-bin/koha/admin/usage_statistics.pl If you try to select a country, you get an error: == The value of your system preference 'UsageStatsCountry' is not valid (Germany). Please select a valid one. == It doesn't matter which country you chose, no country is valid. Test plan: ========== 1. Select a country for UsageStatsCountry system preference. 2. Go to http://<your addr>:8081/cgi-bin/koha/admin/usage_statistics.pl 3. Confirm the issue. 4. Apply the patch ; restart_all. 5. Repeat p. 2. 6. Confirm that the issue has been solved. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Then I think should remove the trim later: <option value="[% country.trim | html %]" selected="selected">[% country.trim | html %]</option> IMO the best solution would be to trim at the beginning of the loop, but I guess yours also works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176831|0 |1 is obsolete| | --- Comment #5 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 176954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176954&action=edit Bug 36163: Usage statistics - Not possible to select a country Site: .../cgi-bin/koha/admin/usage_statistics.pl If you try to select a country, you get an error: == The value of your system preference 'UsageStatsCountry' is not valid (Germany). Please select a valid one. == It doesn't matter which country you chose, no country is valid. Test plan: ========== 1. Select a country for UsageStatsCountry system preference. 2. Go to http://<your addr>:8081/cgi-bin/koha/admin/usage_statistics.pl 3. Confirm the issue. 4. Apply the patch ; restart_all. 5. Repeat p. 2. 6. Confirm that the issue has been solved. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 --- Comment #6 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Jonathan Druart from comment #4)
Then I think should remove the trim later:
<option value="[% country.trim | html %]" selected="selected">[% country.trim | html %]</option>
IMO the best solution would be to trim at the beginning of the loop, but I guess yours also works.
Updated. Thanks, Jonathan. The mine didn't work for Zimbabwe (last from the list) anyway - there must have been a space added that obviously was not removed by split. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176954|0 |1 is obsolete| | --- Comment #7 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 176955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176955&action=edit Bug 36163: Usage statistics - Not possible to select a country Site: .../cgi-bin/koha/admin/usage_statistics.pl If you try to select a country, you get an error: == The value of your system preference 'UsageStatsCountry' is not valid (Germany). Please select a valid one. == It doesn't matter which country you chose, no country is valid. Test plan: ========== 1. Select a country for UsageStatsCountry system preference. 2. Go to http://<your addr>:8081/cgi-bin/koha/admin/usage_statistics.pl 3. Confirm the issue. 4. Apply the patch ; restart_all. 5. Repeat p. 2. 6. Confirm that the issue has been solved. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176956&action=edit Bug 36163: Chomp country list I found the same code in preferences.tt, actually we don't need to trim if the list is properly generated (ie. without extra spaces) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Janusz, I think this is actually the correct fix, what do you think? Ideally country-list.inc could return an array but I think it will be problematic to have a TT directive on several lines (it breaks the translation script). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 --- Comment #10 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Jonathan Druart from comment #9)
Janusz, I think this is actually the correct fix, what do you think?
Sure, it's simpler and cleaner with ~ . The main point is that the issue is identified and resolved :) Thanks, Jonathan, for having a deeper look into it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Usage statistics - Not |Can't select a country for |possible to select a |usage statistics |country | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Really glad to see this fixed after such a long time! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjnkml@gmail.com --- Comment #13 from Roman Dolny <roman.dolny@jezuici.pl> --- *** Bug 39013 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Michał <schodkowy.omegi-0r@icloud.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35213 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36163 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org